Skip to content

[HOLD for payment 2024-05-09] [$250] iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list #40597

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to FAB > Start chat
  3. Go offline

Expected Result:

Offline indicator will not overlap with navigation bar

Actual Result:

Offline indicator overlaps with navigation bar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6455127_1713545718946!IMG_3213

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011f820b0b52933326
  • Upwork Job ID: 1781781063752663040
  • Last Price Increase: 2024-04-20
  • Automatic offers:
    • Krishna2323 | Contributor | 0

Activity

  1. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 19, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. lanitochka17 commented on Apr 19, 2024

    @lanitochka17
    Author

    @srikarparsi FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Apr 19, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. lanitochka17 commented on Apr 19, 2024

    @lanitochka17
    Author

    Production:

    img_2993_720

  6. Krishna2323 commented on Apr 19, 2024

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list

    What is the root cause of that problem?

    We haven't wrapped NewChatPage with ScreenWrapper component. We have ScreenWrapper in WorkspaceNewRoomPage.

    return (
    <View
    style={styles.flex1}
    testID={NewChatPage.displayName}
    >
    <KeyboardAvoidingView
    style={styles.flex1}
    behavior="padding"
    // Offset is needed as KeyboardAvoidingView in nested inside of TabNavigator instead of wrapping whole screen.
    // This is because when wrapping whole screen the screen was freezing when changing Tabs.
    keyboardVerticalOffset={variables.contentHeaderHeight + (insets?.top ?? 0) + variables.tabSelectorButtonHeight + variables.tabSelectorButtonPadding}
    >
    <SelectionList<OptionsListUtils.Option & ListItem>
    ListItem={UserListItem}
    sections={areOptionsInitialized ? sections : CONST.EMPTY_ARRAY}
    textInputValue={searchTerm}
    textInputHint={isOffline ? `${translate('common.youAppearToBeOffline')} ${translate('search.resultsAreLimited')}` : ''}
    onChangeText={setSearchTerm}
    textInputLabel={translate('optionsSelector.nameEmailOrPhoneNumber')}
    headerMessage={headerMessage}
    onSelectRow={createChat}
    onConfirm={(e, option) => (selectedOptions.length > 0 ? createGroup() : createChat(option))}
    rightHandSideComponent={itemRightSideComponent}
    footerContent={footerContent}
    showLoadingPlaceholder={!areOptionsInitialized}
    shouldPreventDefaultFocusOnSelectRow={!DeviceCapabilities.canUseTouchScreen()}
    isLoadingNewOptions={!!isSearchingForReports}
    initiallyFocusedOptionKey={firstKeyForList}
    />
    {isSmallScreenWidth && <OfflineIndicator />}
    </KeyboardAvoidingView>
    </View>
    );
    }

    What changes do you think we should make in order to solve the problem?

    Instead of View, we should wrap the component with ScreenWrapper like we do in WorkspaceNewRoomPage.

    What alternative solutions did you explore? (Optional)

    Result

    bottom_padding_offline_indidcator
  7. srikarparsi commented on Apr 19, 2024

    @srikarparsi
    Contributor

    I believe this has to do with this PR. cc @Luke9389 @rushatgabhane. Is there a reason we don't use the shouldShowOfflineIndicator property in the outer NewChatSelectorPage.

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 20, 2024
  9. melvin-bot commented on Apr 20, 2024

    @melvin-bot
  10. changed the title [-]iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list[/-] [+][$250] iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list[/+] on Apr 20, 2024
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 20, 2024
  12. 23 remaining items

  13. Krishna2323 commented on May 3, 2024

    @Krishna2323
    Contributor

    @srikarparsi @mountiny, PR was deployed to production on 22nd April, this is ready for the payments process. I guess no one is assigned yet to handle the payment.

  14. Krishna2323 commented on May 9, 2024

    @Krishna2323
    Contributor

    @srikarparsi @mountiny, friendly bump for payments.

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 9, 2024
  16. melvin-bot commented on May 9, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  17. changed the title [-][$250] iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list[/-] [+][HOLD for payment 2024-05-09] [$250] iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list[/+] on May 9, 2024
  18. mountiny commented on May 9, 2024

    @mountiny
    Contributor
  19. sakluger commented on May 9, 2024

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor: @Krishna2323 $250, paid via Upwork
    Contributor+: @allroundexperts $250, please complete BZ checklist and request payment via Newdot

  20. allroundexperts commented on May 10, 2024

    @allroundexperts
    Contributor

    Checklist

    1. As mentioned by @srikarparsi, this is caused by New chat page list refactor 2 #38610
    2. N/A
    3. N/A
    4. A regression test would be helpful. The steps given in the OP look clear enough to me.
  21. sakluger commented on May 10, 2024

    @sakluger
    Contributor

    Thanks! Closing.

  22. JmillsExpensify commented on Jun 28, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions