Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewHas a PR in review
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.63-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
- Launch New Expensify app
- Go to FAB > Start chat
- Go offline
Expected Result:
Offline indicator will not overlap with navigation bar
Actual Result:
Offline indicator overlaps with navigation bar
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~011f820b0b52933326
- Upwork Job ID: 1781781063752663040
- Last Price Increase: 2024-04-20
- Automatic offers:
- Krishna2323 | Contributor | 0
Metadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewHas a PR in review

Activity
melvin-bot commentedon Apr 19, 2024
Triggered auto assignment to @srikarparsi (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 19, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Apr 19, 2024
@srikarparsi FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Apr 19, 2024
We think that this bug might be related to #vip-vsp
lanitochka17 commentedon Apr 19, 2024
Production:
Krishna2323 commentedon Apr 19, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list
What is the root cause of that problem?
We haven't wrapped
NewChatPagewithScreenWrappercomponent. We haveScreenWrapperinWorkspaceNewRoomPage.App/src/pages/NewChatPage.tsx
Lines 278 to 311 in 4350e96
What changes do you think we should make in order to solve the problem?
Instead of
View, we should wrap the component withScreenWrapperlike we do inWorkspaceNewRoomPage.What alternative solutions did you explore? (Optional)
Result
srikarparsi commentedon Apr 19, 2024
I believe this has to do with this PR. cc @Luke9389 @rushatgabhane. Is there a reason we don't use the shouldShowOfflineIndicator property in the outer NewChatSelectorPage.
melvin-bot commentedon Apr 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~011f820b0b52933326
[-]iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list[/-][+][$250] iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list[/+]23 remaining items
Krishna2323 commentedon May 3, 2024
@srikarparsi @mountiny, PR was deployed to production on 22nd April, this is ready for the payments process. I guess no one is assigned yet to handle the payment.
Krishna2323 commentedon May 9, 2024
@srikarparsi @mountiny, friendly bump for payments.
melvin-bot commentedon May 9, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-][$250] iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list[/-][+][HOLD for payment 2024-05-09] [$250] iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list[/+]mountiny commentedon May 9, 2024
$250 to @Krishna2323 and to @allroundexperts
sakluger commentedon May 9, 2024
Summarizing payment on this issue:
Contributor: @Krishna2323 $250, paid via Upwork
Contributor+: @allroundexperts $250, please complete BZ checklist and request payment via Newdot
allroundexperts commentedon May 10, 2024
Checklist
sakluger commentedon May 10, 2024
Thanks! Closing.
JmillsExpensify commentedon Jun 28, 2024
$250 approved for @allroundexperts