You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Distance - The route image is cropped in the IOU preview #40791
Version Number: 1.4.64-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4502640 Issue reported by: Applause - Internal Team
Action Performed:
Prerequisites:
Create WS collect, invite an employee
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@Gonals FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Please re-state the problem that we are trying to solve in this issue.
The route image is cropped in the IOU preview
What is the root cause of that problem?
In this PR #35041, Object position top is added to resolve the issue of the receipt thumbnail not displaying its top portion. However, this causes the map distance request to appear cropped in the IOU preview.
What changes do you think we should make in order to solve the problem?
First, we need to update ReceiptImage to accept a new additional prop objectPosition. We will use this to change the objectPosition of ThumbnailImage.
Then, in DistanceEReceipt, we can use the prop we just added and set it to CONST.IMAGE_OBJECT_POSITION.INITIAL.
Next, in the ReceiptUtils.getThumbnailAndImageURIs function, we need to update this line to return transaction. We will use this to check if the transaction is a distanceRequest in ReportActionItemImage.
changed the title [-]Distance - The route image is cropped in the IOU preview[/-][+][$250] Distance - The route image is cropped in the IOU preview[/+]on Apr 23, 2024
Activity
melvin-bot commentedon Apr 23, 2024
Triggered auto assignment to @Gonals (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 23, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Apr 23, 2024
@Gonals FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Apr 23, 2024
We think that this bug might be related to #wave-collect - Release 1
ra-md commentedon Apr 23, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The route image is cropped in the IOU preview
What is the root cause of that problem?
In this PR #35041, Object position top is added to resolve the issue of the receipt thumbnail not displaying its top portion. However, this causes the map distance request to appear cropped in the IOU preview.
What changes do you think we should make in order to solve the problem?
First, we need to update
ReceiptImageto accept a new additional propobjectPosition. We will use this to change theobjectPositionofThumbnailImage.Then, in
DistanceEReceipt, we can use the prop we just added and set it toCONST.IMAGE_OBJECT_POSITION.INITIAL.Next, in the
ReceiptUtils.getThumbnailAndImageURIsfunction, we need to update this line to return transaction. We will use this to check if the transaction is a distanceRequest inReportActionItemImage.Finally, in here, we will set the objectPosition to
CONST.IMAGE_OBJECT_POSITION.INITIALif the request is a distance request.What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon Apr 23, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0160841ad69bf530a2
[-]Distance - The route image is cropped in the IOU preview[/-][+][$250] Distance - The route image is cropped in the IOU preview[/+]melvin-bot commentedon Apr 23, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (
External)3 remaining items
Gonals commentedon Apr 23, 2024
@Pujan92, what do you think of @ra-md's proposal?
Pujan92 commentedon Apr 23, 2024
@ra-md Object position top is added to fix issue #34120.
@Gonals This seems to be a regression from #35041
cc: @dukenv0307
ra-md commentedon Apr 23, 2024
@Pujan92 Oh, I see. 😅
Gonals commentedon Apr 23, 2024
I think this may not be a blocker, since it just kinda moves an existing bug a few pixels 😆. What do you think, @mountiny?
Beamanator commentedon Apr 23, 2024
Aah this could be related to my Web-PDFs change where I centered receipts to the top - https://github.com/Expensify/Web-PDFs/pull/572
I also don't think this is a blocker
neil-marcellini commentedon Apr 23, 2024
The root cause is on the backend and already on prod so yeah, not a blocker. It would be great to fix soon though. It looks bad for distance requests.
ra-md commentedon Apr 23, 2024
proposal updated based on this comment
Beamanator commentedon Apr 24, 2024
I believe this should be handled by @dukenv0307 in #34120 since this is a regression of a PR from that issue
dukenv0307 commentedon Apr 24, 2024
@Beamanator I will add the fix in this PR #40763.
garrettmknight commentedon Apr 24, 2024
Cool, closing this one in favor of the other then.