Skip to content

Chat - User mention is not highlighted as mention when mentioning someone in edited comment #40861

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat.
  3. Send a message.
  4. Right click on the message > Edit comment.
  5. Type @.
  6. Select a user from the suggestion list.
  7. Save the edit.

Expected Result:

The user mention in the edited message will be highlighted as mention.

Actual Result:

The user mention in the edited message is not highlighted as mention.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6459940_1713948778458.mention_2.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 24, 2024
  2. melvin-bot commented on Apr 24, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 24, 2024

    @melvin-bot

    Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 24, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 24, 2024

    @izarutskaya
    Author

    @adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 24, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb.

  7. izarutskaya commented on Apr 24, 2024

    @izarutskaya
    Author

    Production
    image (10)

  8. mountiny commented on Apr 24, 2024

    @mountiny
    Contributor

    This is technically not in production so its not a blocker but I agree this should be addressed in the PR

  9. mountiny commented on Apr 24, 2024

    @mountiny
    Contributor

    We are going to revert this PR #35226 and @dukenv0307 can you please work on implementing this in there too as I think it should be part of the initial implementation (it looks weird when you choose the mention and its not saved that way)

  10. melvin-bot commented on May 8, 2024

    @melvin-bot

    @madmax330 @adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  11. mountiny commented on May 8, 2024

    @mountiny
    Contributor

    I see the new Pr links this issue so I think we can close it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions