Skip to content

Track expense - In track expense, edit amount shows dollar briefly #40873

Closed as not planned

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #39956
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap on a chat --- tap the FAB > track expense
  3. Enter an amount > change currency to RP> tap next
  4. Tap track expense (add a merchant when required)
  5. Tap on newly created expense to open epense details
  6. Tap amount to edit the currency
  7. Choose RP > Save
  8. Tap on amount to edit current
  9. Choose RP > Save
  10. Notice the $ shows for a brief moment after Saving expense and while the changes loading

Expected Result:

In track expense when clicking indian Rupee (RP), edit amount should not show any other currency

Actual Result:

In track expense while the amount in Indian Rupee (RP), edit amount shows dollar briefly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6460041_1713952899660.dollar.mp4
RPReplay_Final1714710485.MP4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 24, 2024
  2. melvin-bot commented on Apr 24, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 24, 2024

    @melvin-bot

    Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 24, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 24, 2024

    @izarutskaya
    Author

    @Christinadobrzyn I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 24, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb.

  7. mountiny commented on Apr 24, 2024

    @mountiny
    Contributor

    Seems like a second regression from #39956 @shubham1206agra @thienlnam @allroundexperts

    Its minor as well, can you follow up with a quick fix

  8. mountiny commented on Apr 24, 2024

    @mountiny
    Contributor

    demoting this as its minor but @shubham1206agra @allroundexperts assinging you as this is most likely coming from your PR

  9. 6 remaining items

  10. melvin-bot commented on Apr 29, 2024

    @melvin-bot

    @allroundexperts, @thienlnam, @Christinadobrzyn, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

  11. Christinadobrzyn commented on Apr 30, 2024

    @Christinadobrzyn
    Contributor

    Just checking, are we creating a new PR for this issue? @allroundexperts @shubham1206agra?

  12. allroundexperts commented on Apr 30, 2024

    @allroundexperts
    Contributor

    I think @shubham1206agra were unable to reproduce this. Is this correct @shubham1206agra?

  13. shubham1206agra commented on Apr 30, 2024

    @shubham1206agra
    Contributor

    I was unable to repro this

  14. Christinadobrzyn commented on Apr 30, 2024

    @Christinadobrzyn
    Contributor

    I can't reproduce this either. I'll ask QA to test - https://expensify.slack.com/archives/C9YU7BX5M/p1714468168251599

  15. kavimuru commented on Apr 30, 2024

    @kavimuru

    Bug is still reproduced.

    can.mp4
  16. Christinadobrzyn commented on May 2, 2024

    @Christinadobrzyn
    Contributor

    I'm still not able to reproduce this... @shubham1206agra or @allroundexperts can you test again and let me know if you get this?

  17. Christinadobrzyn commented on May 3, 2024

    @Christinadobrzyn
    Contributor

    Okay, I was able to reproduce this again when testing on iOS app - I uploaded the video to the OP and updated the steps.

    Since this only seems to be affecting RP currency, I'm inclined to close this as a not critical, edge case, not part of our ROI. We can reevaluate it at a later time.

    @thienlnam @allroundexperts what are your thoughts?

  18. thienlnam commented on May 6, 2024

    @thienlnam
    Contributor

    I agree, doesn't seem like something we need to fix at this time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions