You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Sign up - An error appears in Concierge chat when pass onboarding modal with spaces #41024
Version Number: 1.4.66-0 Reproducible in staging?: Y Reproducible in production?: N
**If this was caught during regression testing, add the test name, ID and link from TestRail:*(https://expensify.testrail.io/index.php?/cases/view/2616817) Issue reported by: Applause - Internal Team
Action Performed:
Sign up new Gmail account
On onboarding modal click on the "Chat and split bills with friends" option (or another non-ws option)
Enter space in First and Last name fields and click Continue
Dismiss video
Expected Result:
No errors in Concierge chat
Actual Result:
There are errors in Concierge chat
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
I'm able to reproduce on dev, the backend is returning 402 Missing firstName. I'm not 100% sure anymore about the requirement to enter a first and last name, bringing it to discussion in Slack here.
@marcaaron check out #41047. We'll need a backend change to allow blank last names, I'll send you a PR shortly as well but then we won't need to block the deploy on that.
This issue has not been updated in over 15 days. @marcaaron eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Apr 25, 2024
Triggered auto assignment to @marcaaron (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 25, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Apr 25, 2024
@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Apr 25, 2024
We think that this bug might be related to #vip-vsp
marcaaron commentedon Apr 25, 2024
@francoisl maybe somehow related to #38414?
We should ask QA what account they used.
I tried to repro on staging and could not.
However, I did see
OpenReportgetting called over and over again - super weird...2024-04-25_12-44-58.mp4
marcaaron commentedon Apr 25, 2024
Asking for re-test here. So far, I am not sure I would block the deploy on it unless it's reliably reproducible. But also looks like a server issue.
francoisl commentedon Apr 26, 2024
I'm able to reproduce on dev, the backend is returning
402 Missing firstName. I'm not 100% sure anymore about the requirement to enter a first and last name, bringing it to discussion in Slack here.francoisl commentedon Apr 26, 2024
@marcaaron check out #41047. We'll need a backend change to allow blank last names, I'll send you a PR shortly as well but then we won't need to block the deploy on that.
kavimuru commentedon Apr 26, 2024
Error message is still reproducible. But now first name is required and throws error if not entered.
empty.name.mp4
francoisl commentedon Apr 26, 2024
This is normal for now, see this note in the PR (it's easy to miss it I guess)
We already have a backend change in review to fix this, but for now we can mark this as passing.
melvin-bot commentedon May 20, 2024
This issue has not been updated in over 15 days. @marcaaron eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
melvin-bot commentedon Jul 17, 2024
@marcaaron, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.