Skip to content

[HOLD for payment 2024-06-03] [QBO] Not all default settings & accounts are selected when establishing the connection to QBO #41046

Closed

Description

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.66-1
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714060188157459?thread_ts=1714057353.559839&cid=C036QM0SLJK & https://expensify.slack.com/archives/C036QM0SLJK/p1714091531288649?thread_ts=1713799261.297609&cid=C036QM0SLJK

Action Performed:

  1. Connect to QBO
  2. Go to Export
  3. Observe not all settings are selected by default
  4. Choose an export method for, say, company card export
  5. Observe the account selection is not selected

Expected Result:

  1. The following export settings should also be set by default when making a connection to QBO:

Export page

  • Preferred exporter = [policyOwner]
  • Date = Export date
  • Export out of pocket expenses as =
    • Export as = Vendor bill
    • Accounts payable = [first applicable account in the list is selected] Note: This select list appears to be completely blank right now, let's fix that
  • Export invoices as = [first applicable account in the list is selected]
  • Export company cards as =
    • Export as = Credit card
    • Account = [first applicable account in the list is selected]
  1. Then when choosing alternative export options, let's make sure the first applicable account in the list is selected as well:

"Export out of pocket expenses as" alt settings

  • Export as = Journal entry

  • Accounts payable = [first applicable account in the list is selected]

  • Export as = Check

  • Accounts payable = [first applicable account in the list is selected]

"Export company cards as" alt settings

  • Export as = Debit card

  • Account = [first applicable account in the list is selected]

  • Export as = Vendor bill

  • Accounts payable = [first applicable account in the list is selected]

  • Default vendor (if enabled, disabled by default)

    • Vendor = [first applicable account in the list is selected]
  1. Let's make sure we apply these changes on the "Advanced" page as well where applicable:
  • Sync reimbursed reports (setting should be toggled on by default) =
    • QuickBooks bill payment account = [first applicable account in the list is selected]
    • QuickBooks invoice collections account = [first applicable account in the list is selected]
  1. When someone changes a configuration setting (i.e updates exporting from Credit card to Vendor bill, make sure the value in the push input for the associated account selection is also updated along with the push label change. I.e
  • Export as = Credit card

  • Account = Amex Card Account

  • Export as = Vendor bill

  • Accounts payable = [first applicable account in the vendor list is selected]

Actual Result:

  1. Only the value in the Preferred exporter list looks to be selected by default on the export settings page
  2. When choosing an export method (i.e Credit Card) the first value in the sub-account that's revealed is not selected
  3. Sync reimbursed reports is not enabled by default on the Advanced page, and the two associated accounts with that setting aren't selected by default either
  4. Previously selected values are not cleared from the push input as the push label updates

Workaround:

Yes, they can select values and change values.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2024-04-26_01-51-56.mp4

View all open jobs on GitHub

CC: @hayata-suenaga @aldo-expensify @s77rt @teneeto @narefyev91 @zanyrenney

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 26, 2024
  2. melvin-bot commented on Apr 26, 2024

    @melvin-bot

    Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

  3. aldo-expensify commented on Apr 26, 2024

    @aldo-expensify
    Contributor
  4. aldo-expensify commented on Apr 26, 2024

    @aldo-expensify
    Contributor

    Created draft PR for the integration server to select the default values during the first import: https://github.com/Expensify/Integration-Server/pull/7882

  5. moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collecton Apr 26, 2024
  6. melvin-bot commented on Apr 29, 2024

    @melvin-bot

    @trjExpensify, @s77rt Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. trjExpensify commented on Apr 29, 2024

    @trjExpensify
    ContributorAuthor

    Whoops! We need to assign Aldo here, he's actively working on PRs to address these. :)

  8. aldo-expensify commented on Apr 29, 2024

    @aldo-expensify
    Contributor

    For choosing the defaults, what I did is:

    1. Connect a QBO to a policy in OldDot
    2. The configuration modal opens automatically after.
    3. Save the configuration modal without touching it

    The configuration at this point is what I used as a reference for the default in the QBO flow from NewDot. Do you think that is correct?

  9. 33 remaining items

  10. melvin-bot commented on May 27, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on May 27, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-03. 🎊

    For reference, here are some details about the assignees on this issue:

    • @s77rt requires payment (Needs manual offer from BZ)
  12. melvin-bot commented on May 27, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
    • [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@s77rt] Determine if we should create a regression test for this bug.
    • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. hayata-suenaga commented on May 27, 2024

    @hayata-suenaga
    Contributor

    tested well for me

    test.1.mov
  14. hayata-suenaga commented on May 29, 2024

    @hayata-suenaga
    Contributor

    We keep this issue open to handle the payment for @s77tr for this App PR.

  15. s77rt commented on May 29, 2024

    @s77rt
    Member
    • The PR that introduced the bug has been identified: I think this existed from the start. I found this PR Fix QBO config types + fix inputs in config pages #41463 that changed the navigation logic but not the real culprit
    • The offending PR has been commented on: n/a
    • A discussion in #expensify-bugs has been started: n/a
    • Determine if we should create a regression test for this bug: No
  16. melvin-bot commented on Jun 3, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • ROLE: @s77rt paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@trjExpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. trjExpensify commented on Jun 3, 2024

    @trjExpensify
    ContributorAuthor

    Payment summary as follows:

    • $250 to @s77rt for the C+ review

    Offer sent!

  18. s77rt commented on Jun 3, 2024

    @s77rt
    Member

    @trjExpensify Accepted! Thanks!

  19. trjExpensify commented on Jun 3, 2024

    @trjExpensify
    ContributorAuthor

    Paid. Closing!

  20. moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collecton Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions