Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.66-1
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714060188157459?thread_ts=1714057353.559839&cid=C036QM0SLJK & https://expensify.slack.com/archives/C036QM0SLJK/p1714091531288649?thread_ts=1713799261.297609&cid=C036QM0SLJK
Action Performed:
- Connect to QBO
- Go to Export
- Observe not all settings are selected by default
- Choose an export method for, say, company card export
- Observe the account selection is not selected
Expected Result:
- The following export settings should also be set by default when making a connection to QBO:
Export page
Preferred exporter=[policyOwner]Date=Export dateExport out of pocket expenses as=Export as=Vendor billAccounts payable=[first applicable account in the list is selected]Note: This select list appears to be completely blank right now, let's fix that
Export invoices as=[first applicable account in the list is selected]Export company cards as=Export as=Credit cardAccount=[first applicable account in the list is selected]
- Then when choosing alternative export options, let's make sure the first applicable account in the list is selected as well:
"Export out of pocket expenses as" alt settings
-
Export as=Journal entry -
Accounts payable=[first applicable account in the list is selected] -
Export as=Check -
Accounts payable=[first applicable account in the list is selected]
"Export company cards as" alt settings
-
Export as=Debit card -
Account=[first applicable account in the list is selected] -
Export as=Vendor bill -
Accounts payable=[first applicable account in the list is selected] -
Default vendor(if enabled, disabled by default)Vendor=[first applicable account in the list is selected]
- Let's make sure we apply these changes on the "Advanced" page as well where applicable:
Sync reimbursed reports(setting should be toggled on by default) =QuickBooks bill payment account=[first applicable account in the list is selected]QuickBooks invoice collections account=[first applicable account in the list is selected]
- When someone changes a configuration setting (i.e updates exporting from
Credit cardtoVendor bill, make sure the value in the push input for the associated account selection is also updated along with the push label change. I.e
-
Export as=Credit card -
Account=Amex Card Account -
Export as=Vendor bill -
Accounts payable=[first applicable account in the vendor list is selected]
Actual Result:
- Only the value in the
Preferred exporterlist looks to be selected by default on the export settings page - When choosing an export method (i.e
Credit Card) the first value in the sub-account that's revealed is not selected - Sync reimbursed reports is not enabled by default on the Advanced page, and the two associated accounts with that setting aren't selected by default either
- Previously selected values are not cleared from the push input as the push label updates
Workaround:
Yes, they can select values and change values.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
2024-04-26_01-51-56.mp4
CC: @hayata-suenaga @aldo-expensify @s77rt @teneeto @narefyev91 @zanyrenney
Issue Owner
Current Issue Owner: @trjExpensifyMetadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Apr 26, 2024
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
aldo-expensify commentedon Apr 26, 2024
I think here is the OldDot code choosing the default settings: https://github.com/Expensify/Web-Expensify/blob/52310ff233e1bca38dd0c3238336646c1c66e640/site/deprecated/lib_policy_quickbooksOnline.js#L370-L409
aldo-expensify commentedon Apr 26, 2024
Created draft PR for the integration server to select the default values during the first import: https://github.com/Expensify/Integration-Server/pull/7882
melvin-bot commentedon Apr 29, 2024
@trjExpensify, @s77rt Whoops! This issue is 2 days overdue. Let's get this updated quick!
trjExpensify commentedon Apr 29, 2024
Whoops! We need to assign Aldo here, he's actively working on PRs to address these. :)
aldo-expensify commentedon Apr 29, 2024
For choosing the defaults, what I did is:
The configuration at this point is what I used as a reference for the default in the QBO flow from NewDot. Do you think that is correct?
33 remaining items
melvin-bot commentedon May 27, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 27, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-03. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 27, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
hayata-suenaga commentedon May 27, 2024
tested well for me
test.1.mov
hayata-suenaga commentedon May 29, 2024
We keep this issue open to handle the payment for @s77tr for this App PR.
s77rt commentedon May 29, 2024
melvin-bot commentedon Jun 3, 2024
Payment Summary
Upwork Job
BugZero Checklist (@trjExpensify)
trjExpensify commentedon Jun 3, 2024
Payment summary as follows:
Offer sent!
s77rt commentedon Jun 3, 2024
@trjExpensify Accepted! Thanks!
trjExpensify commentedon Jun 3, 2024
Paid. Closing!