You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Any links pasted into e.cash that includes a colon : break causing only the portion before the colon to be hyperlinked #4105
Notice that the links are cut off after the colon and therefore don't hyperlink correctly.
Expected Result:
Links including colons should be correctly hyperlinked. In this example when clicked, should redirect to:
A. The cat island in Japan (and yes, it's an island full of cats)
B. The Flying Saucer in South Haven, MI
Actual Result:
Both links are not hyperlinked correctly and cut off after the colon.
Workaround:
User has to manually select the full link and paste it in the URL bar.
Platform:
Where is this issue occurring?
Web ✔️
iOS ✔️
Android ✔️
Desktop App ✔️
Mobile Web ✔️
Notes/Photos/Videos:
Most Google Maps links are affected by this because they contain colons in the URL.
Please check the screenshot in Actual result.
I will try different links from other sites and, if I find more affected by this, will post the ones that have the same issue in comments.
I'm thinking, for issues like this that are likely to be recurring as we find variations, we shouldn't continue to reopen this one but open a new one each time. In the new issue, we can link back to this, gather examples then decide if/when we want a contributor to work on.
I agree with @mallenexpensify opening new tickets for other scenarios are easier to follow than reopening old ones. Let me know if we should start with this variation and create another ticket.
I'm thinking, for issues like this that are likely to be recurring as we find variations, we shouldn't continue to reopen this one but open a new one each time. In the new issue, we can link back to this, gather examples then decide if/when we want a contributor to work on.
Sure. This link maybe looks like it's broken for another reason so we can close this.
Activity
MelvinBot commentedon Jul 16, 2021
Triggered auto assignment to @Gonals (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Jul 19, 2021
Triggered auto assignment to @trjExpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.Gonals commentedon Jul 19, 2021
We'll probably have to tweak the markdown a bit to get this to work correctly.
Sending to the pool!
22 remaining items
isagoico commentedon Nov 4, 2021
Reopening this issue since @mallenexpensify was able to reproduce here https://expensify.slack.com/archives/C01GTK53T8Q/p1635954172411200
mallenexpensify commentedon Nov 4, 2021
I'm thinking, for issues like this that are likely to be recurring as we find variations, we shouldn't continue to reopen this one but open a new one each time. In the new issue, we can link back to this, gather examples then decide if/when we want a contributor to work on.
@marcaaron @trjExpensify @parasharrajat , y'all agree?
trjExpensify commentedon Nov 4, 2021
parasharrajat commentedon Nov 4, 2021
I think parsing links is really giving us a hard time and we are hitting limitations of js regex. Should we reconsider md parser for links?
No preference @mallenexpensify
mallenexpensify commentedon Nov 4, 2021
Also... here's the link
https://www.google.com/maps/place/Poster+Auctions+International,+Inc./@40.7384572,-73.9942151,20.17z/data=!4m13!1m7!3m6!1s0x89c259a2c5fdee77:0x1439488db9133bae!2s26+W+17th+St,+New+York,+NY+10011!3b1!8m2!3d40.7383679!4d-73.993907!3m4!1s0x89c259a2c438eb63:0x115ba65a3675338b!8m2!3d40.7384793!4d-73.9937764
isagoico commentedon Nov 4, 2021
I agree with @mallenexpensify opening new tickets for other scenarios are easier to follow than reopening old ones. Let me know if we should start with this variation and create another ticket.
Also, able to reproduce with Matt's link

marcaaron commentedon Nov 4, 2021
Sure. This link maybe looks like it's broken for another reason so we can close this.
mallenexpensify commentedon Nov 4, 2021
@isagoico can you create a brand new issue and include a link back to this? Thanks
isagoico commentedon Nov 4, 2021
Issue created here 🔝