Skip to content

Any links pasted into e.cash that includes a colon : break causing only the portion before the colon to be hyperlinked  #4105

Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to e.cash and navigate to a conversation
  2. Paste and send these links that contain colons:
    A. https://www.google.com/maps/place/%E9%9D%92%E5%B3%B6%E9%80%A3%E7%B5%A1%E8%88%B9%E4%B9%97%E5%A0%B4/@33.7363156,132.4877213,17.78z/data=!4m5!3m4!1s0x3545615c8c65bf7f:0xb89272c1a705a33f!8m2!3d33.7366776!4d132.4878843
    B. https://www.google.com/maps/place/The+Flying+Saucer/@42.4043314,-86.2742418,15z/data=!4m5!3m4!1s0x0:0xe28f6108670216bc!8m2!3d42.4043316!4d-86.2742121
  3. Notice that the links are cut off after the colon and therefore don't hyperlink correctly.

Expected Result:

Links including colons should be correctly hyperlinked. In this example when clicked, should redirect to:
A. The cat island in Japan (and yes, it's an island full of cats)
B. The Flying Saucer in South Haven, MI

Actual Result:

Both links are not hyperlinked correctly and cut off after the colon.
image

Workaround:

User has to manually select the full link and paste it in the URL bar.

Platform:

Where is this issue occurring?

Web ✔️
iOS ✔️
Android ✔️
Desktop App ✔️
Mobile Web ✔️

Version Number: 1.0.79-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Most Google Maps links are affected by this because they contain colons in the URL.
Please check the screenshot in Actual result.
I will try different links from other sites and, if I find more affected by this, will post the ones that have the same issue in comments.

Upwork Post: https://www.upwork.com/jobs/~017aff792b5b4f4a79

View all open jobs on Upwork


From @mallenexpensify https://expensify.slack.com/archives/C01GTK53T8Q/p1626278479245000

Links pasted into chats sometimes get cut off and the full link isn't properly hyperlinked in a message, especially for Google Maps links.

Activity

  1. MelvinBot commented on Jul 16, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. removed their assignment
    on Jul 19, 2021
  3. added
    ImprovementItem broken or needs improvement.
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 19, 2021
  4. MelvinBot commented on Jul 19, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  5. added and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 19, 2021
  6. Gonals commented on Jul 19, 2021

    @Gonals
    Contributor

    We'll probably have to tweak the markdown a bit to get this to work correctly.
    Sending to the pool!

  7. 22 remaining items

  8. isagoico commented on Nov 4, 2021

    @isagoico
    Author

    Reopening this issue since @mallenexpensify was able to reproduce here https://expensify.slack.com/archives/C01GTK53T8Q/p1635954172411200

    image

  9. mallenexpensify commented on Nov 4, 2021

    @mallenexpensify
    Contributor

    I'm thinking, for issues like this that are likely to be recurring as we find variations, we shouldn't continue to reopen this one but open a new one each time. In the new issue, we can link back to this, gather examples then decide if/when we want a contributor to work on.

    @marcaaron @trjExpensify @parasharrajat , y'all agree?

  10. trjExpensify commented on Nov 4, 2021

    @trjExpensify
    Contributor
  11. parasharrajat commented on Nov 4, 2021

    @parasharrajat
    Member

    I think parsing links is really giving us a hard time and we are hitting limitations of js regex. Should we reconsider md parser for links?

    No preference @mallenexpensify

  12. isagoico commented on Nov 4, 2021

    @isagoico
    Author

    I agree with @mallenexpensify opening new tickets for other scenarios are easier to follow than reopening old ones. Let me know if we should start with this variation and create another ticket.

    Also, able to reproduce with Matt's link
    image

  13. marcaaron commented on Nov 4, 2021

    @marcaaron
    Contributor

    I'm thinking, for issues like this that are likely to be recurring as we find variations, we shouldn't continue to reopen this one but open a new one each time. In the new issue, we can link back to this, gather examples then decide if/when we want a contributor to work on.

    Sure. This link maybe looks like it's broken for another reason so we can close this.

  14. mallenexpensify commented on Nov 4, 2021

    @mallenexpensify
    Contributor

    @isagoico can you create a brand new issue and include a link back to this? Thanks

  15. isagoico commented on Nov 4, 2021

    @isagoico
    Author

    Issue created here 🔝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions