You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[QBO] Error message appears when change any of the configuration on Advanced tab #41092
Version Number: v1.4.66-3 Reproducible in staging?: y Reproducible in production?: n Issue found when executing PR:#41002 Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]QBO - Error message appears when change any of the configuration on Advanced tab[/-][+][QBO] Error message appears when change any of the configuration on Advanced tab[/+]on Apr 26, 2024
[OOPS!] API Threw: Auth UpdatePolicyConnectionConfiguration returned an error ExpException - 83187a0d1e744a12a5bd7f3d584d169d ~~ message: '400 Current value and value are using different types, expected both to be JSON' exceptionMessage: 'Auth UpdatePolicyConnectionConfiguration returned an error' exceptionFile: '/git/releases/expensify.com/b62fe01/lib/Auth.php' exceptionLine: '125' exceptionCode: '400'
JSON::Value currentValueJSON(JSON::NIL);
try {
currentValueJSON = JSON::Value::parse(currentSettingValue);
} catch (...) {
// We're catching this so the comand doesn't fail, we just want to try to parse it and see if it's the same type
}
if (currentValueJSON.type() != requestValueJSON.type()) {
STHROW("400 Current value and value are using different types, expected both to be JSON");
}
Maybe something to do with this is wrong, or that settingValue=true which seems like a boolean and not a string maybe?
I also have another example here for settingName exportCompanyCardAccount, but that doesn't have a settingValue in the logs at all 🤔
PolicyAPI::updatePolicyConnectionConfiguration(): Argument #5 ($settingValue) must be of type string, null given, called in /git/releases/expensify.com/b62fe01/api.php on line 2159"
requestID: "87a809c5d8a64164-LHR"
maybe there is something when we're storing the boolean? the type of value received and the value read from the database isn't matching for some reason in this line
we can also log the type if that helps with debugging. What do you thing @aldo-expensify ?
P.S - @narefyev91 PR here that you can test an adhoc build of here has cleared up a lot of the below type of error for me, as the account is selected when the export type is selected.
PolicyAPI::updatePolicyConnectionConfiguration(): Argument #5 ($settingValue) must be of type string, null given, called in /git/releases/expensify.com/b62fe01/api.php on line 2159"
Mainly want errors remain for me on that build are:
That invalid setting name error for exportAccountPayable for company card export
Toggling off default vendor shows an error
Automatically create entities on the Advanced page shows an error when toggled on
Activity
melvin-bot commentedon Apr 26, 2024
Triggered auto assignment to @rlinoz (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 26, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
kbecciv commentedon Apr 26, 2024
We think that this bug might be related to #wave-collect - Release 1
mountiny commentedon Apr 26, 2024
I believe some of these errors are known, the backend is not fully supporting this. cc @hayata-suenaga @aldo-expensify @trjExpensify @teneeto @narefyev91
mountiny commentedon Apr 26, 2024
Its behind beta so not a blocker
rlinoz commentedon Apr 26, 2024
FWIW the error is
400 Current value and value are using different types, expected both to be JSON[-]QBO - Error message appears when change any of the configuration on Advanced tab[/-][+][QBO] Error message appears when change any of the configuration on Advanced tab[/+]trjExpensify commentedon Apr 26, 2024
I was just looking at that as well when testing to try and figure it out.
Network tab:
Here are the logs from a recent attempt.
Comes from here in Auth.
Maybe something to do with this is wrong, or that
settingValue=truewhich seems like a boolean and not a string maybe?I also have another example here for settingName
exportCompanyCardAccount, but that doesn't have asettingValuein the logs at all 🤔hayata-suenaga commentedon Apr 26, 2024
maybe there is something when we're storing the boolean? the type of value received and the value read from the database isn't matching for some reason in this line
we can also log the type if that helps with debugging. What do you thing @aldo-expensify ?
trjExpensify commentedon Apr 26, 2024
Another one:
Choosing an Accounts Payable account to export as is throwing the invalid setting name this time.
Logs
So that one is down to the settingName
exportAccountPayablemissing from here which we need to add.trjExpensify commentedon Apr 26, 2024
P.S - @narefyev91 PR here that you can test an adhoc build of here has cleared up a lot of the below type of error for me, as the account is selected when the export type is selected.
Mainly want errors remain for me on that build are:
exportAccountPayablefor company card exportmelvin-bot commentedon Apr 29, 2024
@aldo-expensify, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!
hayata-suenaga commentedon Apr 29, 2024
The error is coming from the following lines in the Auth code:
https://github.com/Expensify/Auth/blob/12244a365ca86635b327d6782a1dc66588a5f9f2/auth/command/UpdatePolicyConnectionConfiguration.cpp#L47-L49
The issue might be solved by this PR which was already merged
-> Yes! the missing keys were added in this PR around these lines of code
aldo-expensify commentedon Apr 29, 2024
I don't see new errors for the missing settings after the deploy: https://www.expensify.com/_devportal/tools/logSearch/#query=blob%3A%20%22400%20Invalid%20setting%20name%22%20AND%20timestamp%3A%5B2024-04-25T00%3A00%20TO%202024-04-30T23%3A59%5D&index=_all
Please reopen if we find new missing settings