Skip to content

[HOLD for payment 2024-06-20] [$250] iPhone 13 PRO/chrome - Continue button is cut off at the bottom in sign in screen #41108

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713929851923959

Action Performed:

Precondition: User should have saved credentials in keychain or password

  1. Go to staging.new.expensify.com on IOS Chrome
  2. Tap on the key icon to choose saved credentials

Expected Result:

Continue button is visible

Actual Result:

Keyboard covers half of the continue button

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0197bc982a483fb96d
  • Upwork Job ID: 1787806860579430400
  • Last Price Increase: 2024-05-21
  • Automatic offers:
    • eh2077 | Reviewer | 102437874
    • suneox | Contributor | 102437878
Issue OwnerCurrent Issue Owner: @miljakljajic

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 26, 2024
  2. melvin-bot commented on Apr 26, 2024

    @melvin-bot

    Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Apr 26, 2024

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. melvin-bot commented on Apr 29, 2024

    @melvin-bot

    @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. miljakljajic commented on Apr 30, 2024

    @miljakljajic
    Contributor

    I wasn't able to reproduce this. I'll see if anyone in QA can.

  6. melvin-bot commented on May 3, 2024

    @melvin-bot

    @miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on May 7, 2024
  8. changed the title [-]iPhone 13 PRO/chrome - `Continue` button is cut off at the bottom in sign in screen[/-] [+][$250] iPhone 13 PRO/chrome - `Continue` button is cut off at the bottom in sign in screen[/+] on May 7, 2024
  9. 46 remaining items

  10. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-20. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@suneox / @eh2077] The PR that introduced the bug has been identified. Link to the PR:
    • [@suneox / @eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@suneox / @eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@suneox / @eh2077] Determine if we should create a regression test for this bug.
    • [@suneox / @eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. eh2077 commented on Jun 14, 2024

    @eh2077
    Contributor

    Checklist

    • [@suneox / @eh2077] The PR that introduced the bug has been identified. Link to the PR: I don't think there's a PR responsible for it as this is just an edge use case we missed
    • [@suneox / @eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • [@suneox / @eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@suneox / @eh2077] Determine if we should create a regression test for this bug. No, we don't a regression test for it
  14. eh2077 commented on Jun 20, 2024

    @eh2077
    Contributor

    Not overdue, we're just waiting for @miljakljajic to handle the payment

  15. miljakljajic commented on Jun 21, 2024

    @miljakljajic
    Contributor

    payment completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions