You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-20] [$250] iPhone 13 PRO/chrome - Continue button is cut off at the bottom in sign in screen #41108
changed the title [-]iPhone 13 PRO/chrome - `Continue` button is cut off at the bottom in sign in screen[/-][+][$250] iPhone 13 PRO/chrome - `Continue` button is cut off at the bottom in sign in screen[/+]on May 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@suneox / @eh2077] The PR that introduced the bug has been identified. Link to the PR:
[@suneox / @eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@suneox / @eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@suneox / @eh2077] Determine if we should create a regression test for this bug.
[@suneox / @eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@suneox / @eh2077] The PR that introduced the bug has been identified. Link to the PR: I don't think there's a PR responsible for it as this is just an edge use case we missed
[@suneox / @eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@suneox / @eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@suneox / @eh2077] Determine if we should create a regression test for this bug. No, we don't a regression test for it
Activity
melvin-bot commentedon Apr 26, 2024
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Apr 26, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
melvin-bot commentedon Apr 29, 2024
@miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
miljakljajic commentedon Apr 30, 2024
I wasn't able to reproduce this. I'll see if anyone in QA can.
melvin-bot commentedon May 3, 2024
@miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]iPhone 13 PRO/chrome - `Continue` button is cut off at the bottom in sign in screen[/-][+][$250] iPhone 13 PRO/chrome - `Continue` button is cut off at the bottom in sign in screen[/+]46 remaining items
melvin-bot commentedon Jun 13, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
eh2077 commentedon Jun 14, 2024
Checklist
eh2077 commentedon Jun 20, 2024
Not overdue, we're just waiting for @miljakljajic to handle the payment
miljakljajic commentedon Jun 21, 2024
payment completed