You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [HOLD for payment 2024-10-17] Report actions pagination improvements #41153
We currently have an issue where pagination methods (GetNewerActions, GetOlderActions) are called unconditionally even if we should know that no newer or older messages are available.
Solution
To improve this OpenReport, GetNewerActions, GetOlderActions should all return pagination info. This should be stored in the REPORT_METADATA onyx collection.
For OpenReport it should be hasNewerActions and hasOlderActions.
For GetNewerActions it should be hasNewerActions.
For GetOlderActions it should be hasOlderActions.
Then in loadNewerChats and loadOlderChats we should check that newer / older actions are available before loading them.
This will reduce the call to these methods significantly. For regular chats we never should have newer actions since we start loading from the start of the chat so GetNewerActions will never be called. If we are in a short chat, we probably loaded all messages initially so we don't need to call GetOlderActions. For comment linking we should still call both GetNewerActions and GetOlderActions since we are probably in the middle of a chat.
Activity
melvin-bot commentedon May 3, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Jul 15, 2024
@janicduplessis, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
roryabraham commentedon Aug 27, 2024
put a PR in review for this: https://github.com/Expensify/Auth/pull/12239
48 remaining items
CortneyOfstad commentedon Oct 14, 2024
@ishpaul777 — sent you an offer in Upwork, please let me know once you accept!
ishpaul777 commentedon Oct 15, 2024
Accepted Thanks!
CortneyOfstad commentedon Oct 15, 2024
I am heading OoO (10/15 to 10/23), so going to get this reassigned so the payment can be made!
melvin-bot commentedon Oct 15, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lschurr commentedon Oct 15, 2024
Payment summary:
lschurr commentedon Oct 15, 2024
Oops I read the date wrong and paid it today. We'll just leave this open to make sure there are no regressions.
lschurr commentedon Oct 17, 2024
Closing :)