Skip to content

[$250] [HOLD for payment 2024-10-17] Report actions pagination improvements #41153

Closed

Description

@janicduplessis

Problem

We currently have an issue where pagination methods (GetNewerActions, GetOlderActions) are called unconditionally even if we should know that no newer or older messages are available.

Solution

To improve this OpenReport, GetNewerActions, GetOlderActions should all return pagination info. This should be stored in the REPORT_METADATA onyx collection.

  • For OpenReport it should be hasNewerActions and hasOlderActions.
  • For GetNewerActions it should be hasNewerActions.
  • For GetOlderActions it should be hasOlderActions.

Then in loadNewerChats and loadOlderChats we should check that newer / older actions are available before loading them.

This will reduce the call to these methods significantly. For regular chats we never should have newer actions since we start loading from the start of the chat so GetNewerActions will never be called. If we are in a short chat, we probably loaded all messages initially so we don't need to call GetOlderActions. For comment linking we should still call both GetNewerActions and GetOlderActions since we are probably in the middle of a chat.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021845841739039769728
  • Upwork Job ID: 1845841739039769728
  • Last Price Increase: 2024-10-14
Issue OwnerCurrent Issue Owner: @

Activity

  1. melvin-bot commented on May 3, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  2. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    @janicduplessis, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  3. self-assigned this
    on Aug 16, 2024
  4. roryabraham commented on Aug 27, 2024

    @roryabraham
    Contributor
  5. 48 remaining items

  6. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 14, 2024
  7. CortneyOfstad commented on Oct 14, 2024

    @CortneyOfstad
    Contributor

    @ishpaul777 — sent you an offer in Upwork, please let me know once you accept!

  8. ishpaul777 commented on Oct 15, 2024

    @ishpaul777
    Contributor

    Accepted Thanks!

  9. CortneyOfstad commented on Oct 15, 2024

    @CortneyOfstad
    Contributor

    I am heading OoO (10/15 to 10/23), so going to get this reassigned so the payment can be made!

  10. removed their assignment
    on Oct 15, 2024
  11. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 15, 2024
  12. melvin-bot commented on Oct 15, 2024

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  13. lschurr commented on Oct 15, 2024

    @lschurr
    Contributor

    Payment summary:

  14. lschurr commented on Oct 15, 2024

    @lschurr
    Contributor

    Oops I read the date wrong and paid it today. We'll just leave this open to make sure there are no regressions.

  15. lschurr commented on Oct 17, 2024

    @lschurr
    Contributor

    Closing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions