You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting Payment 30th May] [Search v1] Chat - "From" link in IOU report details page navigates to the main chat twice #41198
Please re-state the problem that we are trying to solve in this issue.
The navigation to the parent report happens twice.
What is the root cause of that problem?
When we press the "From" link, it will call goBack with the report screen as the fallback which will be used twice. One without the report action ID and the other one with the report action ID for comment linking.
// In case if type is 'FORCED_UP' we replace current screen with the provided. This means the current screen no longer exists in the stack
if(type===CONST.NAVIGATION.TYPE.FORCED_UP){
action.type=CONST.NAVIGATION.ACTION_TYPE.REPLACE;
// If this action is navigating to the report screen and the top most navigator is different from the one we want to navigate - PUSH the new screen to the top of the stack
Previously, we only compare the report ID to decide whether to push the report screen or not.
What changes do you think we should make in order to solve the problem?
I think we want to have the old behavior, that is to push the report screen only if the topmost report ID is different than the destination report ID, if it's other screen, then we will use the current condition.
changed the title [-]Chat - "From" link in IOU report details page navigates to the main chat twice[/-][+][$250] Chat - "From" link in IOU report details page navigates to the main chat twice[/+]on May 3, 2024
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
changed the title [-][Search v1] Chat - "From" link in IOU report details page navigates to the main chat twice[/-][+][Awaiting Payment 30th May] [Search v1] Chat - "From" link in IOU report details page navigates to the main chat twice[/+]on Jun 3, 2024
Activity
melvin-bot commentedon Apr 29, 2024
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.izarutskaya commentedon Apr 29, 2024
We think this issue might be related to the #collect project.
bernhardoj commentedon Apr 29, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The navigation to the parent report happens twice.
What is the root cause of that problem?
When we press the "From" link, it will call goBack with the report screen as the fallback which will be used twice. One without the report action ID and the other one with the report action ID for comment linking.
App/src/components/ParentNavigationSubtitle.tsx
Lines 38 to 43 in 35890a0
The issue happens after this PR where we will push the screen if the params is different, in this case, the report action ID param.
App/src/libs/Navigation/linkTo.ts
Lines 155 to 176 in 35890a0
Previously, we only compare the report ID to decide whether to push the report screen or not.
What changes do you think we should make in order to solve the problem?
I think we want to have the old behavior, that is to push the report screen only if the topmost report ID is different than the destination report ID, if it's other screen, then we will use the current condition.
melvin-bot commentedon May 2, 2024
@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
trjExpensify commentedon May 3, 2024
@luacmartins @grgia putting this on your radar! I'll file it under Search v1.
melvin-bot commentedon May 3, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01c414e0c471cc81d1
[-]Chat - "From" link in IOU report details page navigates to the main chat twice[/-][+][$250] Chat - "From" link in IOU report details page navigates to the main chat twice[/+]21 remaining items
bernhardoj commentedon May 10, 2024
PR is ready
cc: @s77rt
melvin-bot commentedon Jun 3, 2024
This issue has not been updated in over 15 days. @trjExpensify, @s77rt, @luacmartins, @bernhardoj eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
[-][Search v1] Chat - "From" link in IOU report details page navigates to the main chat twice[/-][+][Awaiting Payment 30th May] [Search v1] Chat - "From" link in IOU report details page navigates to the main chat twice[/+]trjExpensify commentedon Jun 3, 2024
Payment summary as follows:
Paid. Closing!