Skip to content

CRITICAL: [API Reliability] Workspace room does not load older messages due to infinite GetOlderActions calls #41254

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.67-2
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714419709483439

Action Performed:

  1. Open new dot app
  2. Go to the workspace chat NewDot Test - Expensify US policy`

Expected Result:

The workspace chat should load all historical messages and requests

Actual Result:

The workspace chat is stuck looping through OpenReport over and over again. It will not load previous messages or requests, but it will load a recent receipt I uploaded today

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

CleanShot.2024-04-29.at.15.34.58.mp4

logs-2024-04-29 19_35_32.431.txt

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @roryabraham

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 29, 2024
  2. melvin-bot commented on Apr 29, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Apr 29, 2024

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. shawnborton commented on Apr 29, 2024

    @shawnborton
    Contributor

    cc @JmillsExpensify in case you want to add your case here too

  5. trjExpensify commented on May 1, 2024

    @trjExpensify
    Contributor

    I've just experienced this as well in a pretty brand new test account. Logs here:

    logs-2024-05-01 16_24_37.825.txt

    Looks like OpenReport and GetOlderActions are in a constant loop:

    2024-05-01_17-28-05.mp4

    When I click on one of those Fetch finished loading: POST "<URL>?". rows in the console, I see this error as well:

    {"code":666,"jsonCode":403,"type":"Expensify\\Libs\\Error\\ExpError","UUID":"da7984df-628f-41f6-a2b8-ecd4499f7975","message":"Report not found","title":"","data":{"onyxData":[{"onyxMethod":"merge","key":"report_0","value":{"errorFields":{"notFound":{"1714580833933154":"Report not found"}}}}]},"htmlMessage":"","requestID":"87d123434d9c4164-LHR"}
    
  6. muttmuure commented on May 2, 2024

    @muttmuure
    Contributor

    I hit this one too. @gedu @adhorodyski @janicduplessis @Szymon20000 could your teams take a look at this?

  7. muttmuure commented on May 2, 2024

    @muttmuure
    Contributor

    posted a CPU profile to #newdot-performance https://expensify.slack.com/archives/C05LX9D6E07/p1714656403682529

  8. changed the title [-]Workspace room does not load older messages[/-] [+]HIGH: [API Reliability] Workspace room does not load older messages due to infinite `GetOlderActions` calls[/+] on May 2, 2024
  9. janicduplessis commented on May 2, 2024

    @janicduplessis
    Contributor

    I will investigate this today

  10. 57 remaining items

  11. roryabraham commented on Jul 12, 2024

    @roryabraham
    Contributor

    Now that #41962 is on prod, this should be fixed. Requested a retest: https://expensify.slack.com/archives/C9YU7BX5M/p1720819446079169

  12. shawnborton commented on Jul 15, 2024

    @shawnborton
    Contributor

    So I can easily see the historical chats in my Workspace chat, but one interesting thing is that it doesn't load the receipt images for my expenses unless I click into each expense:
    CleanShot 2024-07-15 at 07 48 20@2x

    Thoughts?

  13. roryabraham commented on Jul 15, 2024

    @roryabraham
    Contributor

    That looks like a real but separate bug (but a legit one we should report in #expensify-bugs). Going to close this issue as complete

  14. moved this from CRITICAL to DONE in [#whatsnext] #vip-vsbon Jul 15, 2024
  15. shawnborton commented on Jul 15, 2024

    @shawnborton
    Contributor

    Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions