You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-20] [$250] Track expense - Tracking report does not appear in LHN when the tracking is created offlne #41284
Version Number: 1.4.68-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Track expense - Tracking report does not appear in LHN when the tracking is created offlne[/-][+][$250] Track expense - Tracking report does not appear in LHN when the tracking is created offlne[/+]on May 2, 2024
changed the title [-][$250] Track expense - Tracking report does not appear in LHN when the tracking is created offlne[/-][+][HOLD for payment 2024-06-20] [$250] Track expense - Tracking report does not appear in LHN when the tracking is created offlne[/+]on Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
[@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jayeshmangwani] Determine if we should create a regression test for this bug.
[@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: Not able to find any PR that directly causes this issue. In my opinion, this issue is an edge case arising from outdated data provided by the withOnyx HOC.
[@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: To catch the issue in the future, a regression test should be enough
[@jayeshmangwani] Determine if we should create a regression test for this bug.
[@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Open App -> Go offline
Go to FAB -> Track expense
Track a manual expense.
Click on the preview to open the tracked expense.
Verify that the tracked expense has appeared in the LHN and is highlighted as the "active" chat.
@trjExpensify Is it possible to get paid through NewDot for this job instead of Upwork?
since the issue was created before I was getting paid through ND and I received an Upwork offer. If not, no problem—we can go through Upwork.
Activity
melvin-bot commentedon Apr 30, 2024
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Apr 30, 2024
@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Apr 30, 2024
We think that this bug might be related to #vip-vsp
trjExpensify commentedon May 2, 2024
I can repro this under the first pre-condition in the OP:
CC: @thienlnam
[-]Track expense - Tracking report does not appear in LHN when the tracking is created offlne[/-][+][$250] Track expense - Tracking report does not appear in LHN when the tracking is created offlne[/+]melvin-bot commentedon May 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01b8a455d33344f1fa
melvin-bot commentedon May 2, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)62 remaining items
[-][$250] Track expense - Tracking report does not appear in LHN when the tracking is created offlne[/-][+][HOLD for payment 2024-06-20] [$250] Track expense - Tracking report does not appear in LHN when the tracking is created offlne[/+]melvin-bot commentedon Jun 13, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jayeshmangwani commentedon Jun 20, 2024
Regression Test Proposal
Do we agree 👍 or 👎
jayeshmangwani commentedon Jun 20, 2024
@trjExpensify Is it possible to get paid through NewDot for this job instead of Upwork?
since the issue was created before I was getting paid through ND and I received an Upwork offer. If not, no problem—we can go through Upwork.
trjExpensify commentedon Jun 20, 2024
Yeah, totally. Go ahead and request on NewDot, and decline the offer on Upwork. 👍
Payment summary as follows:
Regression test issue created here: https://github.com/Expensify/Expensify/issues/406236
Closing!
jayeshmangwani commentedon Jun 22, 2024
Requested on NewDot
JmillsExpensify commentedon Jun 24, 2024
$250 approved for @jayeshmangwani