Skip to content

[HOLD for payment 2024-06-20] [$250] Track expense - Tracking report does not appear in LHN when the tracking is created offlne #41284

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.68-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #40988

Action Performed:

Precondition:

  • User has not opened the selfDM previously (this can also be done by a re-logging in or simply resetting the app from the Troubleshoot menu).
  • selfDM must be in skeleton in offline mode. didn't matter for me
  • Use a new expensifail account didn't matter for me
  1. Go to staging.new.expensify.com
  2. Go offline
  3. Go to FAB > Track expense
  4. Track a manual expense
  5. Click on the preview to open the tracked expense

Expected Result:

The tracked expense should appear in the LHN and be highlighted as the "active" chat.

Actual Result:

The tracked expense does not appear in the LHN when created offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6466077_1714438018700.hiuhwi.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b8a455d33344f1fa
  • Upwork Job ID: 1785823144724504576
  • Last Price Increase: 2024-05-09
  • Automatic offers:
    • jayeshmangwani | Reviewer | 0
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 30, 2024
  2. melvin-bot commented on Apr 30, 2024

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Apr 30, 2024

    @lanitochka17
    Author

    @trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Apr 30, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 2, 2024
  6. trjExpensify commented on May 2, 2024

    @trjExpensify
    Contributor

    I can repro this under the first pre-condition in the OP:

    image

    CC: @thienlnam

  7. changed the title [-]Track expense - Tracking report does not appear in LHN when the tracking is created offlne[/-] [+][$250] Track expense - Tracking report does not appear in LHN when the tracking is created offlne[/+] on May 2, 2024
  8. melvin-bot commented on May 2, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 2, 2024
  10. melvin-bot commented on May 2, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

  11. 62 remaining items

  12. changed the title [-][$250] Track expense - Tracking report does not appear in LHN when the tracking is created offlne[/-] [+][HOLD for payment 2024-06-20] [$250] Track expense - Tracking report does not appear in LHN when the tracking is created offlne[/+] on Jun 13, 2024
  13. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-20. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
    • [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@jayeshmangwani] Determine if we should create a regression test for this bug.
    • [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. jayeshmangwani commented on Jun 20, 2024

    @jayeshmangwani
    Contributor
    • [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: Not able to find any PR that directly causes this issue. In my opinion, this issue is an edge case arising from outdated data provided by the withOnyx HOC.
    • [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: To catch the issue in the future, a regression test should be enough
    • [@jayeshmangwani] Determine if we should create a regression test for this bug.
    • [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Open App -> Go offline
    2. Go to FAB -> Track expense
    3. Track a manual expense.
    4. Click on the preview to open the tracked expense.
    5. Verify that the tracked expense has appeared in the LHN and is highlighted as the "active" chat.

    Do we agree 👍 or 👎

  17. jayeshmangwani commented on Jun 20, 2024

    @jayeshmangwani
    Contributor

    @trjExpensify Is it possible to get paid through NewDot for this job instead of Upwork?
    since the issue was created before I was getting paid through ND and I received an Upwork offer. If not, no problem—we can go through Upwork.

  18. trjExpensify commented on Jun 20, 2024

    @trjExpensify
    Contributor

    Yeah, totally. Go ahead and request on NewDot, and decline the offer on Upwork. 👍

    Payment summary as follows:

    Regression test issue created here: https://github.com/Expensify/Expensify/issues/406236

    Closing!

  19. jayeshmangwani commented on Jun 22, 2024

    @jayeshmangwani
    Contributor

    Requested on NewDot

  20. JmillsExpensify commented on Jun 24, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @jayeshmangwani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions