Skip to content

[HOLD for payment 2024-06-03] [$250] Workspace - Workspace name is truncated inconsistently in mWeb and android #41327

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.68
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open mweb and android app
  2. Tap profile --- Workspaces---new Workspace
  3. Tap profile
  4. Paste text in both mweb and app-RtTest Workspace testingtestingtestingtestingtestingtestinggghhhhhhggggggf722222222222mmmmmmmmmmmmm7

Expected Result:

Workspace name truncated must be consistent in mweb and android

Actual Result:

Workspace name is truncated inconsistently in mweb and android

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6466484_1714480580012!Screenshot_2024-04-30-18-05-58-555_com android chrome-edit

Bug6466484_1714480627044!Screenshot_2024-04-30-18-06-38-862_com expensify chat-edit

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0106a5ae69cbfb2cf2
  • Upwork Job ID: 1785354421533896704
  • Last Price Increase: 2024-04-30
  • Automatic offers:
    • getusha | Reviewer | 0
    • Krishna2323 | Contributor | 0
Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 30, 2024
  2. melvin-bot commented on Apr 30, 2024

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Apr 30, 2024

    @lanitochka17
    Author

    @garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Apr 30, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 30, 2024
  6. melvin-bot commented on Apr 30, 2024

    @melvin-bot
  7. changed the title [-]Workspace - Workspace name is truncated inconsistently in mWeb and android[/-] [+][$250] Workspace - Workspace name is truncated inconsistently in mWeb and android[/+] on Apr 30, 2024
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 30, 2024
  9. melvin-bot commented on Apr 30, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

  10. Krishna2323 commented on Apr 30, 2024

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace - Workspace name is truncated inconsistently in mWeb and android

    What is the root cause of that problem?

    The title doesn't take the full width because flex1 isn't applied to workspaceTitleStyle.

    App/src/styles/index.ts

    Lines 4851 to 4854 in 1abad69

    workspaceTitleStyle: {
    ...headlineFont,
    fontSize: variables.fontSizeXLarge,
    },

    What changes do you think we should make in order to solve the problem?

    Apply flex:1/styles.flex1 to workspaceTitleStyle style object and also check for similar issues in other fields.

    What alternative solutions did you explore? (Optional)

    Add flex1 to menu item title and description if needed.

    Before

    before_workspace_title_truncate_issue.mp4

    After

    after_workspace_title_truncate_issue.mp4
  11. 39 remaining items

  12. garrettmknight commented on Jun 12, 2024

    @garrettmknight
    Contributor

    Just waiting for NewDot Payment.

  13. hayata-suenaga commented on Jun 24, 2024

    @hayata-suenaga
    Contributor

    Melvin, we're just waiting for payment 😄

  14. garrettmknight commented on Jun 24, 2024

    @garrettmknight
    Contributor

    Yep, just waiting for payment!

  15. getusha commented on Jun 27, 2024

    @getusha
    Contributor

    @garrettmknight just found out i should be paid via UW on issues assigned before 2024-05-25
    could you send the upwork offer? i am unable to find it. thanks!

  16. garrettmknight commented on Jun 27, 2024

    @garrettmknight
    Contributor
  17. getusha commented on Jun 27, 2024

    @getusha
    Contributor

    Accepted!

  18. garrettmknight commented on Jun 28, 2024

    @garrettmknight
    Contributor

    All paid out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions