You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Workspace - Workspace avatar is different when viewed in full screen mode #41387
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@sakluger I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
The PR updates the logic on how the workspace vatar color is generated. It was generated based on workspace names and now it's based on PolicyID instead of Workspace Name
The new logic is not applied to the avatar inside 1. AttachmentView
Activity
melvin-bot commentedon May 1, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 1, 2024
Triggered auto assignment to @cristipaval (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon May 1, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon May 1, 2024
@sakluger I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon May 1, 2024
We think this issue might be related to the #collect project.
dragnoir commentedon May 1, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace avatar is different when viewed in full screen mode
What is the root cause of that problem?
Offended PR: #39637
The PR updates the logic on how the workspace vatar color is generated. It was generated based on workspace names and now it's based on PolicyID instead of Workspace Name
The new logic is not applied to the avatar inside 1. AttachmentView
App/src/components/Attachments/AttachmentView/index.tsx
Lines 117 to 130 in 5f50430
What changes do you think we should make in order to solve the problem?
We shoudl apply the new logic to
AttachmentViewtoo.We can update the
defaultWorkspaceAvatarColorandiconFillColorwith the new logic hereWe replace the
file.namebu thepolicyIDPOC video:
20240501_102634.mp4
34 remaining items
melvin-bot commentedon May 20, 2024
@puneetlath, @sakluger, @rushatgabhane, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!
rushatgabhane commentedon May 22, 2024
PR merged last week but not on staging yet
sakluger commentedon Jun 4, 2024
Removed @puneetlath since I'm back from OOO.
Sounds like we still just need to wait for the PR to be deployed. May be a bit longer with the current freeze.
sakluger commentedon Jun 12, 2024
PR was deployed to prod! Closing.