Skip to content

Workspace - Workspace avatar is different when viewed in full screen mode #41387

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.69-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Workspaces.
  3. Create a new workspace.
  4. Go to workspace chat.
  5. Click on the chat header.
  6. Click on the workspace avatar.

Expected Result:

Workspace avatar will be the same when viewed in full screen mode.

Actual Result:

Workspace avatar is different when viewed in full screen mode.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6467471_1714543808530.ws_pic.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 1, 2024
  2. melvin-bot commented on May 1, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 1, 2024

    @melvin-bot

    Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on May 1, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on May 1, 2024

    @izarutskaya
    Author

    @sakluger I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on May 1, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. dragnoir commented on May 1, 2024

    @dragnoir
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace avatar is different when viewed in full screen mode

    What is the root cause of that problem?

    Offended PR: #39637

    The PR updates the logic on how the workspace vatar color is generated. It was generated based on workspace names and now it's based on PolicyID instead of Workspace Name

    The new logic is not applied to the avatar inside 1. AttachmentView

    const defaultWorkspaceAvatarColor = StyleUtils.getDefaultWorkspaceAvatarColor(file.name ?? '');
    iconFillColor = defaultWorkspaceAvatarColor.fill;
    additionalStyles = [defaultWorkspaceAvatarColor];
    }
    return (
    <Icon
    src={source}
    height={variables.defaultAvatarPreviewSize}
    width={variables.defaultAvatarPreviewSize}
    fill={iconFillColor}
    additionalStyles={additionalStyles}
    />
    );

    What changes do you think we should make in order to solve the problem?

    We shoudl apply the new logic to AttachmentView too.

    We can update the defaultWorkspaceAvatarColor and iconFillColor with the new logic here

    We replace the file.name bu the policyID

    StyleUtils.getDefaultWorkspaceAvatarColor(policyID?.toString() ??  '');

    POC video:

    20240501_102634.mp4
  8. 34 remaining items

  9. melvin-bot commented on May 20, 2024

    @melvin-bot

    @puneetlath, @sakluger, @rushatgabhane, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. rushatgabhane commented on May 22, 2024

    @rushatgabhane
    Member

    PR merged last week but not on staging yet

  11. sakluger commented on Jun 4, 2024

    @sakluger
    Contributor

    Removed @puneetlath since I'm back from OOO.

    Sounds like we still just need to wait for the PR to be deployed. May be a bit longer with the current freeze.

  12. sakluger commented on Jun 12, 2024

    @sakluger
    Contributor

    PR was deployed to prod! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions