Skip to content

[Awaiting Checklist Completion] Workspace - Unsupported browser notification appears on the Xero setup page (Android) #41512

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


issue found when validating #41415
Version Number: 1.4.70-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal
Slack conversation:

Action Performed:

  1. Log in with a new expensifail account
  2. Create a workspace
  3. Enable "Accounting" on the WS settings page
  4. Navigate to "Accounting"
  5. Tap on the "Set up" button next to Xero

Expected Result:

The browser should be switched to a supported one or if it's not possible, the notification shouldn't appear for users.

Actual Result:

Unsupported browser notification appears on the Xero setup page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6468935_1714661231507!Screenshot_20240502_164159_New_Expensify

Screen_Recording_20240502_233840_New.Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01609688787adfdcff
  • Upwork Job ID: 1786384710813405184
  • Last Price Increase: 2024-05-03
  • Automatic offers:
    • gijoe0295 | Contributor | 0
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 2, 2024
  2. melvin-bot commented on May 2, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. m-natarajan commented on May 2, 2024

    @m-natarajan
    Author

    @twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. m-natarajan commented on May 2, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #wave-collect - Release 1

  5. twisterdotcom commented on May 3, 2024

    @twisterdotcom
    Contributor

    Trying to recreate on iOS, my Android phone is at home. Added my test domain to the xero beta

  6. twisterdotcom commented on May 3, 2024

    @twisterdotcom
    Contributor

    Hmm, not an issue on iOS:
    IMG_1383

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 3, 2024
  8. changed the title [-]Workspace - Unsupported browser notification appears on the Xero setup page[/-] [+][$250] Workspace - Unsupported browser notification appears on the Xero setup page[/+] on May 3, 2024
  9. melvin-bot commented on May 3, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 3, 2024
  11. melvin-bot commented on May 3, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  12. 25 remaining items

  13. melvin-bot commented on May 15, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on May 15, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-05-22. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on May 15, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
    • [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mananjadhav] Determine if we should create a regression test for this bug.
    • [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. twisterdotcom commented on May 22, 2024

    @twisterdotcom
    Contributor

    Payment Summary:

  17. twisterdotcom commented on May 22, 2024

    @twisterdotcom
    Contributor

    Waiting on you @mananjadhav for the checklist.

  18. changed the title [-][HOLD for payment 2024-05-22] Workspace - Unsupported browser notification appears on the Xero setup page (Android)[/-] [+][Awaiting Checklist Completion] Workspace - Unsupported browser notification appears on the Xero setup page (Android)[/+] on May 22, 2024
  19. mananjadhav commented on May 25, 2024

    @mananjadhav
    Collaborator

    There is no offending PR for this one. We're using WebView and we added this as a follow up. Additionally we don't need a regression test for this one.

    @twisterdotcom Payout for me will be after the whole Xero as a flat fee.

  20. melvin-bot commented on May 28, 2024

    @melvin-bot

    @mananjadhav, @twisterdotcom, @lakchote, @gijoe0295 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions