You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Chat - Unable to navigate to LHN, back button loops between WS details & main chat page #41514
But the navigation type will be changed to PUSH because the params are different. The topmost report has reportID and reportActionID in the params (linked message), but we navigate to a report without reportActionID.
If we update the logic to only compares the reportID, this issue won't happen anymore, but it will remove the reportActionID from the param, so the message won't be linked anymore.
What changes do you think we should make in order to solve the problem?
To solve the issue correctly, we just need to remove shouldNavigateToTopMostReport from the details page.
if we want the user to see the report screen when going back after refresh, then it should be handled in this issue
changed the title [-]Chat - Unable to navigate to LHN, back button loops between WS details & main chat page[/-][+][$250] Chat - Unable to navigate to LHN, back button loops between WS details & main chat page[/+]on May 7, 2024
changed the title [-][HOLD for payment 2024-06-18] [$250] Chat - Unable to navigate to LHN, back button loops between WS details & main chat page[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Chat - Unable to navigate to LHN, back button loops between WS details & main chat page[/+]on Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
[@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rayane-djouah] Determine if we should create a regression test for this bug.
[@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
1. Open a workspace chat
2. Request money
3. Press the request preview
4. Press the "From" link on the header
5. Press the chat header to open the details
6. Go back
7. Verify the request preview is still highlighted
8. (small screen) Go back again
9. Verify you are navigated to the LHN
Activity
melvin-bot commentedon May 2, 2024
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.izarutskaya commentedon May 2, 2024
We think this issue might be related to the #vip-vsb.
bernhardoj commentedon May 3, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The back button loops if we open the report detail page after visiting a linked message of a report.
What is the root cause of that problem?
If we open the detail page from a report,
shouldNavigateToTopMostReportwill be true.App/src/pages/ReportDetailsPage.tsx
Lines 269 to 270 in 7483d10
shouldNavigateToTopMostReportwill navigate to the topmost report ID.App/src/components/HeaderWithBackButton/index.tsx
Lines 154 to 157 in 7483d10
But the navigation type will be changed to PUSH because the params are different. The topmost report has reportID and reportActionID in the params (linked message), but we navigate to a report without reportActionID.
App/src/libs/Navigation/linkTo.ts
Lines 166 to 179 in 7483d10
If we update the logic to only compares the reportID, this issue won't happen anymore, but it will remove the reportActionID from the param, so the message won't be linked anymore.
What changes do you think we should make in order to solve the problem?
To solve the issue correctly, we just need to remove
shouldNavigateToTopMostReportfrom the details page.if we want the user to see the report screen when going back after refresh, then it should be handled in this issue
melvin-bot commentedon May 7, 2024
@johncschuster Eep! 4 days overdue now. Issues have feelings too...
[-]Chat - Unable to navigate to LHN, back button loops between WS details & main chat page[/-][+][$250] Chat - Unable to navigate to LHN, back button loops between WS details & main chat page[/+]melvin-bot commentedon May 7, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0110f0cb9e34f0e6c4
melvin-bot commentedon May 7, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (
External)36 remaining items
[-][HOLD for payment 2024-06-18] [$250] Chat - Unable to navigate to LHN, back button loops between WS details & main chat page[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Chat - Unable to navigate to LHN, back button loops between WS details & main chat page[/+]melvin-bot commentedon Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
rayane-d commentedon Jun 17, 2024
Regression Test Proposal
1. Open a workspace chat
2. Request money
3. Press the request preview
4. Press the "From" link on the header
5. Press the chat header to open the details
6. Go back
7. Verify the request preview is still highlighted
8. (small screen) Go back again
9. Verify you are navigated to the LHN
Do we agree 👍 or 👎
johncschuster commentedon Jun 20, 2024
I've added the QA issue and will work on payment shortly.
johncschuster commentedon Jun 21, 2024
@hayata-suenaga I'm trying to make sense of the payment here. As far as I can tell, it looks like @rayane-djouah introduced the bug in this PR, which was reviewed by @rushatgabhane.
It also looks like @bernhardoj has worked on the fix for the regression (here), and @rayane-djouah reviewed that PR. Have I understood that correctly?
hayata-suenaga commentedon Jun 24, 2024
Yes that seems to be correct. The C+ authored a PR that introduced the regression and the same C+ reviewed the PR that fixed it.
hayata-suenaga commentedon Jun 24, 2024
Melvin, we're just handling payments 😄
johncschuster commentedon Jun 24, 2024
Ok! Thanks for confirming my understanding, @hayata-suenaga!
Payment Summary:
@rayane-djouah was originally paid in this issue
@rushatgabhane was originally paid in this issue
@bernhardoj needs to be compensated - $250 via Upwork - THIS HAS BEEN PAID