Skip to content

[HOLD for payment 2024-06-06] [$250] BNP - Delay in showing new currency when selecting a new currency #41515

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.70-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Issue reported by: Applause internal team

Action Performed:

  1. Launch New Expensify app.
  2. Go to FAB.
  3. Tap Submit expense.
  4. Tap on the currency.
  5. Select a different currency.
  6. Expected Result:
  7. When navigating back to BNP, the new currency will appear instantly in BNP.

Actual Result:

When navigating back to BNP, the old currency is still seen in BNP for a while before it changes to the new currency.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Attaching both staging and production behavior videos

Bug6469039_1714666065979.prod.mp4
Bug6469039_1714666065966.staging.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @laurenreidexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0192c095a5bdaf7ab7
  • Upwork Job ID: 1787480317266833408
  • Last Price Increase: 2024-05-06
  • Automatic offers:
    • rojiphil | Reviewer | 0
    • ZhenjaHorbach | Contributor | 0

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on May 2, 2024
  2. melvin-bot commented on May 2, 2024

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 2, 2024

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on May 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on May 2, 2024

    @m-natarajan
    Author

    @amyevans FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. m-natarajan commented on May 2, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #vip-vsb

  7. amyevans commented on May 2, 2024

    @amyevans
    Contributor

    I can repro (tried on staging iOS native), but honestly it's barely noticeable, not worth blocking deploy over.

  8. 41 remaining items

  9. melvin-bot commented on May 30, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on May 30, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-06. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on May 30, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rojiphil] The PR that introduced the bug has been identified. Link to the PR:
    • [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rojiphil] Determine if we should create a regression test for this bug.
    • [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. laurenreidexpensify commented on Jun 7, 2024

    @laurenreidexpensify
    Contributor

    Payment Summary:

    C+ $250 @rojiphil pls accept offer in upwork + confirm regression steps thanks
    Contributor $250 @ZhenjaHorbach to be paid via upwork (upwork currently being unstable, will aim to issue payment again later)

  13. rojiphil commented on Jun 7, 2024

    @rojiphil
    Contributor
    • [@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
    • [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
    • [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist is good enough to capture such issues.
    • [@rojiphil] Determine if we should create a regression test for this bug. : The changes are not in a defect-prone or a change-prone area and do not impact the critical functionality. I think we can skip regression steps here.
    • [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. NA
  14. rojiphil commented on Jun 7, 2024

    @rojiphil
    Contributor

    pls accept offer in upwork + confirm regression steps thanks

    @laurenreidexpensify Accepted offer and completed BZ checklist. Thanks.

  15. laurenreidexpensify commented on Jun 10, 2024

    @laurenreidexpensify
    Contributor

    Payment Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions