You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-05] [$250] iOS - Expense - Chat header appears after delay when opening expense report #41523
Version Number: 1.4.70-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Launch New Expensify app
Submit two expenses to a user with no chat history
In 1:1 DM, tap on the expense preview
Expected Result:
Expense report header will appear instantly
Actual Result:
The report content is displayed first, then followed by the chat header
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
However, there is currently a bug in withOnyx where a falsey initial value is ignored. I previously fixed it here to fix #35906, but gets reverted because of some bugs that appear in the App where it expects the falsey initial value to not work. So, in the new PR, I use useOnyx hook instead that doesn't have this falsey initial value issue. So, we can do the same by using useOnyx here.
We can consider this as a migration issue from withOnyx to useOnyx
changed the title [-][$250] iOS - Expense - Chat header appears after delay when opening expense report[/-][+][HOLD for payment 2024-06-05] [$250] iOS - Expense - Chat header appears after delay when opening expense report[/+]on May 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
(Web/Desktop/mWeb) Refresh the app (iOS/Android) Close the app and reopen the app
Verify the header/top bar of the home page/LHN is shown immediately
Activity
melvin-bot commentedon May 2, 2024
Triggered auto assignment to @puneetlath (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon May 2, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon May 2, 2024
@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon May 2, 2024
We think that this bug might be related to #vip-vsp
puneetlath commentedon May 2, 2024
I'm not able to reproduce this on my iOS app.
francoisl commentedon May 3, 2024
Can't repro either with Browserstack. I get a "Review required" violation on each expense, but that's unrelated, and violations are still in beta.
bernhardoj commentedon May 3, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The money report header shows with a delay.
What is the root cause of that problem?
The money report header connects to several onyx data,
App/src/components/MoneyReportHeader.tsx
Lines 318 to 331 in 0f39e43
and if the data is not available yet, withOnyx will return null. In this case, nextStep data is not available yet.
This has the same root cause as #41397
This also happens in the transaction header and the one that's not available yet is shownHoldUseExplanation
App/src/components/MoneyRequestHeader.tsx
Lines 246 to 249 in 0f39e43
What changes do you think we should make in order to solve the problem?
Set an initial value of the missing data.
For the nextStep, we can set it to an empty object.
App/src/components/MoneyReportHeader.tsx
Lines 322 to 324 in 0f39e43
For the shownHoldUseExplanation, we can set it to false.
App/src/components/MoneyRequestHeader.tsx
Lines 246 to 249 in 0f39e43
However, there is currently a bug in withOnyx where a falsey initial value is ignored. I previously fixed it here to fix #35906, but gets reverted because of some bugs that appear in the App where it expects the falsey initial value to not work. So, in the new PR, I use
useOnyxhook instead that doesn't have this falsey initial value issue. So, we can do the same by usinguseOnyxhere.We can consider this as a migration issue from withOnyx to useOnyx
50 remaining items
[-][$250] iOS - Expense - Chat header appears after delay when opening expense report[/-][+][HOLD for payment 2024-06-05] [$250] iOS - Expense - Chat header appears after delay when opening expense report[/+]melvin-bot commentedon May 29, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-05. 🎊
For reference, here are some details about the assignees on this issue:
puneetlath commentedon Jun 5, 2024
@DylanDylann bump on the checklist!
DylanDylann commentedon Jun 5, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Do we agree 👍 or 👎
DylanDylann commentedon Jun 5, 2024
@puneetlath thanks for your reminder
puneetlath commentedon Jun 10, 2024
All paid. Thanks everyone!