You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-11] [Xero] Provide access to Xero related screens only if the integration connected is Xero #41726
Right now, components that use <SelectionScreen> do not check if the current integration connected is Xero.
Solution
As discussed here, we'll need to add the corresponding checks and modify shouldBeBlocked in the components that use <SelectionScreen>, to make sure we can only access the related screens if we have the Xero integration connected.
changed the title [-]Provide access to Xero related screens only if the integration connected is Xero[/-][+][Xero] Provide access to Xero related screens only if the integration connected is Xero[/+]on May 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Issue is ready for payment but no BZ is assigned. @MitchExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Activity
melvin-bot commentedon May 7, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @ishpaul777 (
Internal)mananjadhav commentedon May 7, 2024
@lakchote I can take this up for development.
hungvu193 commentedon May 8, 2024
I believe we should also update the logic of
ConnectionLayoutas well not onlySelectionScreenmananjadhav commentedon May 8, 2024
I'll take care of both in all screens.
mananjadhav commentedon May 9, 2024
I raised one of the last PRs on the Xero screen. Once I receive feedback on that I'll start working on this one.
mananjadhav commentedon May 13, 2024
Waiting for this large PR to get merged #42043. Will start this tomorrow.
[-]Provide access to Xero related screens only if the integration connected is Xero[/-][+][Xero] Provide access to Xero related screens only if the integration connected is Xero[/+]11 remaining items
melvin-bot commentedon Jun 4, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 4, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 11, 2024
Issue is ready for payment but no BZ is assigned. @MitchExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Jun 11, 2024
Payment Summary
Upwork Job
BugZero Checklist (@MitchExpensify)
ishpaul777 commentedon Jun 11, 2024
No payment due to me
mananjadhav commentedon Jun 11, 2024
@MitchExpensify There won't be any payout for this one. This is handled centrally as a flat fee.
mananjadhav commentedon Jun 12, 2024
We're good to close this one out.