Skip to content

[HOLD for payment 2024-06-11] [Xero] Provide access to Xero related screens only if the integration connected is Xero #41726

Closed

Description

@lakchote

Problem

Right now, components that use <SelectionScreen> do not check if the current integration connected is Xero.

Solution

As discussed here, we'll need to add the corresponding checks and modify shouldBeBlocked in the components that use <SelectionScreen>, to make sure we can only access the related screens if we have the Xero integration connected.

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on May 7, 2024
  2. self-assigned this
    on May 7, 2024
  3. melvin-bot commented on May 7, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @ishpaul777 (Internal)

  4. moved this to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collecton May 7, 2024
  5. mananjadhav commented on May 7, 2024

    @mananjadhav
    Collaborator

    @lakchote I can take this up for development.

  6. hungvu193 commented on May 8, 2024

    @hungvu193
    Contributor

    I believe we should also update the logic of ConnectionLayout as well not only SelectionScreen

  7. mananjadhav commented on May 8, 2024

    @mananjadhav
    Collaborator

    I'll take care of both in all screens.

  8. mananjadhav commented on May 9, 2024

    @mananjadhav
    Collaborator

    I raised one of the last PRs on the Xero screen. Once I receive feedback on that I'll start working on this one.

  9. mananjadhav commented on May 13, 2024

    @mananjadhav
    Collaborator

    Waiting for this large PR to get merged #42043. Will start this tomorrow.

  10. changed the title [-]Provide access to Xero related screens only if the integration connected is Xero[/-] [+][Xero] Provide access to Xero related screens only if the integration connected is Xero[/+] on May 17, 2024
  11. 11 remaining items

  12. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-11. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @ishpaul777 requires payment (Needs manual offer from BZ)
  14. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @MitchExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  15. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@MitchExpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. ishpaul777 commented on Jun 11, 2024

    @ishpaul777
    Contributor

    No payment due to me

  17. mananjadhav commented on Jun 11, 2024

    @mananjadhav
    Collaborator

    @MitchExpensify There won't be any payout for this one. This is handled centrally as a flat fee.

  18. mananjadhav commented on Jun 12, 2024

    @mananjadhav
    Collaborator

    We're good to close this one out.

  19. moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collecton Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions