You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD FOR #40565][$250] Chat - Mention is not displayed in compose box when editing a message #41793
Version Number: 1.4.71-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4546634 Issue reported by: Applause - Internal Team
Action Performed:
Log in to New Expensify
Navigate to any chat
Send a message with user mention
Edit the message
If the mention is displayed cancel the edit and repeat step 4
Expected Result:
Mentions should be displayed when editing messages
Actual Result:
Mention is not displayed in edit compose box
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Chat - Mention is not displayed in compose box when editing a message[/-][+][$250] Chat - Mention is not displayed in compose box when editing a message[/+]on May 8, 2024
changed the title [-][$250] Chat - Mention is not displayed in compose box when editing a message[/-][+][HOLD FOR #40565][$250] Chat - Mention is not displayed in compose box when editing a message[/+]on May 8, 2024
This issue has not been updated in over 15 days. @hungvu193, @jliexpensify eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
To add more context. expensify-common was updated to handle the case of editing mentions but Expensify App is not yet updated so that's why @hidden is displayed. Everything will be fine when my PR is merged (hopefully early next week)
Activity
melvin-bot commentedon May 7, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon May 7, 2024
@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon May 7, 2024
We think that this bug might be related to #vip-vsp
jliexpensify commentedon May 8, 2024
Ah weird, yes - can repro this.
[-]Chat - Mention is not displayed in compose box when editing a message[/-][+][$250] Chat - Mention is not displayed in compose box when editing a message[/+]melvin-bot commentedon May 8, 2024
Job added to Upwork: https://www.upwork.com/jobs/~013489c9a79accb0a7
melvin-bot commentedon May 8, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (
External)c3024 commentedon May 8, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Mention is not displayed in edit compose box
What is the root cause of that problem?
We return an empty string when there is no match for the account in the map here
https://github.com/Expensify/expensify-common/blob/182ef7f5824617b8893abaedee9855b5d66faf95/lib/ExpensiMark.js#L488
and we are not passing any
extrashereApp/src/pages/home/report/ContextMenu/ContextMenuActions.tsx
Line 241 in e0b6a06
so
extrastake the default{}herehttps://github.com/Expensify/expensify-common/blob/182ef7f5824617b8893abaedee9855b5d66faf95/lib/ExpensiMark.js#L865
and
accountToNameMapbecomesundefinedherehttps://github.com/Expensify/expensify-common/blob/182ef7f5824617b8893abaedee9855b5d66faf95/lib/ExpensiMark.js#L486-L488
and the mention is replaced by
''What changes do you think we should make in order to solve the problem?
We should create an
accountIdToNamemap and pass it inextrastoparser.htmlToMarkdownat all places.What alternative solutions did you explore? (Optional)
1 remaining item
robertKozik commentedon May 8, 2024
Yes @hungvu193 #40565 should handle this case
@war-in CMIIW
jliexpensify commentedon May 8, 2024
Thanks gents, will drop a HOLD on this
[-][$250] Chat - Mention is not displayed in compose box when editing a message[/-][+][HOLD FOR #40565][$250] Chat - Mention is not displayed in compose box when editing a message[/+]melvin-bot commentedon May 31, 2024
This issue has not been updated in over 15 days. @hungvu193, @jliexpensify eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
hungvu193 commentedon May 31, 2024
Still hold for #40565
lanitochka17 commentedon Jun 7, 2024
QA team faced similar problem: On editing mention message, hidden is displayed
Is it the same? or open new issue
war-in commentedon Jun 7, 2024
Hi @lanitochka17 👋
I'm currently working on this in my Editing mentions PR.
To add more context.
expensify-commonwas updated to handle the case of editing mentions but Expensify App is not yet updated so that's why@hiddenis displayed. Everything will be fine when my PR is merged (hopefully early next week)hungvu193 commentedon Jul 9, 2024
Linked PR is merged and deployed, please verify this @lanitochka17. I think we can close this issue. cc @jliexpensify
Screen.Recording.2024-07-09.at.16.29.18.mov
jliexpensify commentedon Jul 9, 2024
Nice, thanks @hungvu193