Skip to content

[HOLD FOR #40565][$250] Chat - Mention is not displayed in compose box when editing a message #41793

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4546634
Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in to New Expensify
  2. Navigate to any chat
  3. Send a message with user mention
  4. Edit the message
  5. If the mention is displayed cancel the edit and repeat step 4

Expected Result:

Mentions should be displayed when editing messages

Actual Result:

Mention is not displayed in edit compose box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6473962_1715099426584.2024-05-07_18-28-32.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013489c9a79accb0a7
  • Upwork Job ID: 1788009417512591360
  • Last Price Increase: 2024-05-08
Issue OwnerCurrent Issue Owner: @hungvu193

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 7, 2024
  2. melvin-bot commented on May 7, 2024

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on May 7, 2024

    @lanitochka17
    Author

    @jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on May 7, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. jliexpensify commented on May 8, 2024

    @jliexpensify
    Contributor

    Ah weird, yes - can repro this.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 8, 2024
  7. changed the title [-]Chat - Mention is not displayed in compose box when editing a message[/-] [+][$250] Chat - Mention is not displayed in compose box when editing a message[/+] on May 8, 2024
  8. melvin-bot commented on May 8, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 8, 2024
  10. melvin-bot commented on May 8, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

  11. c3024 commented on May 8, 2024

    @c3024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Mention is not displayed in edit compose box

    What is the root cause of that problem?

    We return an empty string when there is no match for the account in the map here

    https://github.com/Expensify/expensify-common/blob/182ef7f5824617b8893abaedee9855b5d66faf95/lib/ExpensiMark.js#L488

    and we are not passing any extras here

    Report.saveReportActionDraft(reportID, reportAction, parser.htmlToMarkdown(getActionHtml(reportAction)));

    so extras take the default {} here

    https://github.com/Expensify/expensify-common/blob/182ef7f5824617b8893abaedee9855b5d66faf95/lib/ExpensiMark.js#L865

    and accountToNameMap becomes undefined here

    https://github.com/Expensify/expensify-common/blob/182ef7f5824617b8893abaedee9855b5d66faf95/lib/ExpensiMark.js#L486-L488
    and the mention is replaced by ''

    What changes do you think we should make in order to solve the problem?

    We should create an accountIdToName map and pass it in extras to parser.htmlToMarkdown at all places.

    What alternative solutions did you explore? (Optional)

  12. 1 remaining item

  13. robertKozik commented on May 8, 2024

    @robertKozik
    Contributor

    Yes @hungvu193 #40565 should handle this case

    @war-in CMIIW

  14. jliexpensify commented on May 8, 2024

    @jliexpensify
    Contributor

    Thanks gents, will drop a HOLD on this

  15. changed the title [-][$250] Chat - Mention is not displayed in compose box when editing a message[/-] [+][HOLD FOR #40565][$250] Chat - Mention is not displayed in compose box when editing a message[/+] on May 8, 2024
  16. added and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 8, 2024
  17. melvin-bot commented on May 31, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @hungvu193, @jliexpensify eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  18. hungvu193 commented on May 31, 2024

    @hungvu193
    Contributor

    Still hold for #40565

  19. lanitochka17 commented on Jun 7, 2024

    @lanitochka17
    Author

    QA team faced similar problem: On editing mention message, hidden is displayed
    Is it the same? or open new issue

    bandicam 2024-06-07 13-41-12-076

  20. war-in commented on Jun 7, 2024

    @war-in
    Contributor

    Hi @lanitochka17 👋

    I'm currently working on this in my Editing mentions PR.

    To add more context. expensify-common was updated to handle the case of editing mentions but Expensify App is not yet updated so that's why @hidden is displayed. Everything will be fine when my PR is merged (hopefully early next week)

  21. hungvu193 commented on Jul 9, 2024

    @hungvu193
    Contributor

    Linked PR is merged and deployed, please verify this @lanitochka17. I think we can close this issue. cc @jliexpensify

    Screen.Recording.2024-07-09.at.16.29.18.mov
  22. jliexpensify commented on Jul 9, 2024

    @jliexpensify
    Contributor

    Nice, thanks @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions