Skip to content

[Search v1] "__fake__" is displayed at From and To fields for split expenses #41796

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.71.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41615

Action Performed:

  1. Log in with an expensifail account with at one split expense
  2. Navigate to Profile - Troubleshoot - New Search page

Expected Result:

Fields should be populated with valid data

Actual Result:

"fake" is displayed at From and To fields for split expenses

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6474019_1715104138805!Capture

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on May 7, 2024
  2. melvin-bot commented on May 7, 2024

    @melvin-bot

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

    1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
      • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
    2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
      • You can adjust the urgency of the issue to better represent the gravity of the bug.
      • If the issue is super low priority, feel free to un-assign yourself.
      • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
      • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

    Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

  3. melvin-bot commented on May 7, 2024

    @melvin-bot

    Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on May 7, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. lanitochka17 commented on May 7, 2024

    @lanitochka17
    Author

    @roryabraham FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on May 7, 2024
  7. roryabraham commented on May 7, 2024

    @roryabraham
    Contributor

    not a blocker - hidden feature

  8. luacmartins commented on May 7, 2024

    @luacmartins
    Contributor

    @grgia this is still happening. I think the query we have for sharedReports is incorrect

  9. 14 remaining items

  10. melvin-bot commented on May 28, 2024

    @melvin-bot

    @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collecton May 28, 2024
  12. luacmartins commented on May 28, 2024

    @luacmartins
    Contributor

    Hmm so that PR didn't solve this issue. Gonna work on a separate fix.

  13. added
    ReviewingHas a PR in review
    and removed
    ReviewingHas a PR in review
    on May 28, 2024
  14. moved this from Done to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collecton Jun 3, 2024
  15. changed the title [-]Search - "__fake__" is displayed at From and To fields for split expenses[/-] [+][Search v1] "__fake__" is displayed at From and To fields for split expenses[/+] on Jun 3, 2024
  16. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

  17. melvin-bot commented on Jun 5, 2024

    @melvin-bot

    @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

  18. luacmartins commented on Jun 5, 2024

    @luacmartins
    Contributor

    I think we can close this one for now since the PR was merged. Maybe we'll have another edge case of this issue, but we can reopen it then.

  19. moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collecton Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions