You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Split expense - Merchant field is shown as required while making split expense #41886
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
You can adjust the urgency of the issue to better represent the gravity of the bug.
If the issue is super low priority, feel free to un-assign yourself.
Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@JmillsExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Let's examine the present scenario: when split bill in the expense report, an error regarding the required merchant field arises consistently. However, when splitting the bill in the announcement room, the error regarding the required merchant field appears and disappear after a moment
It seems that the merchant field is only mandatory in workspace chats. For non-workspace chats, it's only required when we explicitly scan a receipt and the scan is successful. However, for manual requests in non-workspace chats, it doesn't appear to be mandatory. I'll wait for confirmation from @JmillsExpensify. In any case, this issue doesn't seem to be a blocker, so I'll remove the label. Once Jason confirms, we can look into it further.
This is fixed in this PR #41945. The fix was that isPolicyExpenseChat should not be true when splitting from a workspace room. It should only be true if one of the participants is a policy expense chat.
Activity
melvin-bot commentedon May 9, 2024
Triggered auto assignment to @techievivek (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 9, 2024
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 9, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
github-actions commentedon May 9, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon May 9, 2024
@JmillsExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon May 9, 2024
We think this issue might be related to the #vip-split.
2 remaining items
cretadn22 commentedon May 9, 2024
record.mov
Let's examine the present scenario: when split bill in the expense report, an error regarding the required merchant field arises consistently. However, when splitting the bill in the announcement room, the error regarding the required merchant field appears and disappear after a moment
This flicker come from #40386.
@techievivek @JmillsExpensify, could you please verify the expected behavior regarding when and where the merchant field is required?
techievivek commentedon May 9, 2024
It seems that the merchant field is only mandatory in workspace chats. For non-workspace chats, it's only required when we explicitly scan a receipt and the scan is successful. However, for manual requests in non-workspace chats, it doesn't appear to be mandatory. I'll wait for confirmation from @JmillsExpensify. In any case, this issue doesn't seem to be a blocker, so I'll remove the label. Once Jason confirms, we can look into it further.
cretadn22 commentedon May 9, 2024
regression from #41723
youssef-lr commentedon May 9, 2024
This is fixed in this PR #41945. The fix was that
isPolicyExpenseChatshould not betruewhen splitting from a workspace room. It should only be true if one of the participants is a policy expense chat.melvin-bot commentedon May 13, 2024
@JmillsExpensify, @youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
youssef-lr commentedon May 15, 2024
This is fixed.