You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] [HOLD for Payment 2024-06-21] LOW: [Performance] Improve the performance of getCachedCollection #41895
We have many calls to keysChanged function throughout the session and on an average it will be around ~800 ms. That’s a lot for a function which is called this many times. From the trace, this function is called roughly around 15 times.
Inside of this function we have getCachedCollection , which first calls Array.from on the Set then filter it out and then reduce the returned value.
Solution
We can improve this by doing only 1 loop directly on Set as it gives us forEach.
changed the title [-][Performance] Improve the performance of getCachedCollection[/-][+]LOW: [Performance] Improve the performance of getCachedCollection[/+]on May 12, 2024
changed the title [-][$250] [HOLD for Payment 2024-06-21] LOW: [Performance] Improve the performance of getCachedCollection[/-][+][HOLD for payment 2024-07-02] [$250] [HOLD for Payment 2024-06-21] LOW: [Performance] Improve the performance of getCachedCollection[/+]on Jun 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt / @ikevin127] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt / @ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt / @ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt / @ikevin127] Determine if we should create a regression test for this bug.
[@s77rt / @ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-07-02] [$250] [HOLD for Payment 2024-06-21] LOW: [Performance] Improve the performance of getCachedCollection[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] [HOLD for Payment 2024-06-21] LOW: [Performance] Improve the performance of getCachedCollection[/+]on Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt / @ikevin127] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt / @ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt / @ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt / @ikevin127] Determine if we should create a regression test for this bug.
[@s77rt / @ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon May 9, 2024
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.hurali97 commentedon May 9, 2024
@mountiny Please assign this to me 👋
[-][Performance] Improve the performance of getCachedCollection[/-][+]LOW: [Performance] Improve the performance of getCachedCollection[/+]mountiny commentedon May 13, 2024
Onyx PR merged, asking Ali to raise App onyx bump PR https://expensify.slack.com/archives/C05LX9D6E07/p1715605661167679?thread_ts=1715178705.054759&cid=C05LX9D6E07
55 remaining items
mallenexpensify commentedon Jun 21, 2024
Contributor: @ikevin127 paid $1000 via Upwork (per @mountiny 's comment above)
Contributor+: @s77rt due $250 via NewDot (also in Vit's comment)
Doesn't look like this needs a regression test, comment/reopen if anyone disagrees.
JmillsExpensify commentedon Jun 22, 2024
$250 approved for @s77rt
[-][$250] [HOLD for Payment 2024-06-21] LOW: [Performance] Improve the performance of getCachedCollection[/-][+][HOLD for payment 2024-07-02] [$250] [HOLD for Payment 2024-06-21] LOW: [Performance] Improve the performance of getCachedCollection[/+]melvin-bot commentedon Jun 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 25, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon Jun 27, 2024
Checklist ^ does not apply here. Not a bug
[-][HOLD for payment 2024-07-02] [$250] [HOLD for Payment 2024-06-21] LOW: [Performance] Improve the performance of getCachedCollection[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] [HOLD for Payment 2024-06-21] LOW: [Performance] Improve the performance of getCachedCollection[/+]melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: