You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd #41914
The workspace profile page showcases the workspace avatar, name, description and currency. This data is not loaded when we navigate to this page which can lead to potentially outdated.
This is also not aligned with other policy settings pages, where we fetch the up-to-date data when we navigate to the page ieOpenWorkspaceMembersPage
Solution
Create a new OpenWorkspaceProfilePage to follow the 1:1:1 which will read the necessary data for the profile page anytime we navigate to it.
changed the title [-][HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd[/+]on Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@hungvu193 / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@hungvu193 / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hungvu193 / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hungvu193 / @fedirjh] Determine if we should create a regression test for this bug.
[@hungvu193 / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon May 9, 2024
Job added to Upwork: https://www.upwork.com/jobs/~012e913b6015edda5e
melvin-bot commentedon May 9, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (
Internal)melvin-bot commentedon May 9, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mountiny commentedon May 13, 2024
I will look into this today or tomorrow
63 remaining items
[-][HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd[/+]melvin-bot commentedon Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 15, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
hungvu193 commentedon Jul 17, 2024
Requested on ND
JmillsExpensify commentedon Jul 19, 2024
$250 approved for @hungvu193
melvin-bot commentedon Jul 22, 2024
Payment Summary
Upwork Job
BugZero Checklist (@zanyrenney)
JmillsExpensify commentedon Jul 22, 2024
$250 approved for @fedirjh
zanyrenney commentedon Jul 23, 2024
post is closed on upwork.
I don't think we need a regression test here because its related to the API
zanyrenney commentedon Jul 23, 2024
Payment Summary
Upwork Job
Reviewer: @hungvu193 owed $250 via NewDot - paid via ND see comment above
Reviewer: @fedirjh owed $250 via NewDot (please request via ND)