Skip to content

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd #41914

Closed

Description

@mountiny

### Problem

The workspace profile page showcases the workspace avatar, name, description and currency. This data is not loaded when we navigate to this page which can lead to potentially outdated.

This is also not aligned with other policy settings pages, where we fetch the up-to-date data when we navigate to the page ieOpenWorkspaceMembersPage

Solution

Create a new OpenWorkspaceProfilePage to follow the 1:1:1 which will read the necessary data for the profile page anytime we navigate to it.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012e913b6015edda5e
  • Upwork Job ID: 1788566297116684288
  • Last Price Increase: 2024-05-09
Issue OwnerCurrent Issue Owner: @zanyrenney

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 9, 2024
  2. self-assigned this
    on May 9, 2024
  3. melvin-bot commented on May 9, 2024

    @melvin-bot
  4. melvin-bot commented on May 9, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (Internal)

  5. melvin-bot commented on May 9, 2024

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. mountiny commented on May 13, 2024

    @mountiny
    ContributorAuthor

    I will look into this today or tomorrow

  7. 63 remaining items

  8. changed the title [-][HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd[/-] [+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Create OpenPolicyProfilePage API comamnd[/+] on Jul 15, 2024
  9. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-22. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hungvu193 requires payment through NewDot Manual Requests
    • @fedirjh requires payment through NewDot Manual Requests
  10. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@hungvu193 / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
    • [@hungvu193 / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@hungvu193 / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@hungvu193 / @fedirjh] Determine if we should create a regression test for this bug.
    • [@hungvu193 / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. hungvu193 commented on Jul 17, 2024

    @hungvu193
    Contributor

    Requested on ND

  12. JmillsExpensify commented on Jul 19, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @hungvu193

  13. melvin-bot commented on Jul 22, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@zanyrenney)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1788566297116684288/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. JmillsExpensify commented on Jul 22, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @fedirjh

  15. zanyrenney commented on Jul 23, 2024

    @zanyrenney
    Contributor

    post is closed on upwork.
    I don't think we need a regression test here because its related to the API

  16. zanyrenney commented on Jul 23, 2024

    @zanyrenney
    Contributor

    Payment Summary
    Upwork Job

    Reviewer: @hungvu193 owed $250 via NewDot - paid via ND see comment above
    Reviewer: @fedirjh owed $250 via NewDot (please request via ND)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions