You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Task- User avatar when opening from task preview mention is not the same as chat header avatar #42027
Version Number: 1.4.72-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to FAB > Assign task
Enter title > Next
Click Assignee
Enter a random email address that does not have Expensify account
Create the task
After a while, click on the user mention in the task preview in the main chat
Expected Result:
User avatar when opening from task preview mention will be the same as chat header avatar
Actual Result:
User avatar when opening from task preview mention is not the same as chat header avatar
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
You can adjust the urgency of the issue to better represent the gravity of the bug.
If the issue is super low priority, feel free to un-assign yourself.
Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@jasperhuangg FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
In HeaderView, I'm seeing that the report has participantAccountIDs as [1024805772]
So it looks like the NEW accountID is returned in the CreateTask network request, but it looooks like the optimistic account ID isn't being removed, AND it's still being linked to in some places (the report screen header & the "This is the beginning of your chat" intro text avatar
changed the title [-][HOLD for payment 2024-06-18] [$250] Task- User avatar when opening from task preview mention is not the same as chat header avatar[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Task- User avatar when opening from task preview mention is not the same as chat header avatar[/+]on Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon May 12, 2024
Triggered auto assignment to @jasperhuangg (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 12, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
github-actions commentedon May 12, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon May 12, 2024
@jasperhuangg FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon May 12, 2024
We think that this bug might be related to #vip-vsp
Beamanator commentedon May 13, 2024
Interesting, so the first time I click on the mention, I see the accountID is 17146630 with avatar https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_23.png - in the profile page, which is correct according to onyx
But in the Report Screen header, in MultipleAvatars we're passing an accountID of 1024805772, which seems to be the optimistic accountID - which is in Onyx, and has a default avatar of https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_13.png
Beamanator commentedon May 13, 2024
In
HeaderView, I'm seeing that the report hasparticipantAccountIDsas[1024805772]So it looks like the NEW accountID is returned in the
CreateTasknetwork request, but it looooks like the optimistic account ID isn't being removed, AND it's still being linked to in some places (the report screen header & the "This is the beginning of your chat" intro text avatarBeamanator commentedon May 13, 2024
I did, however, just reproduce in production so this shouldn't be a blocker - i'm going to test again on another platform
68 remaining items
[-][HOLD for payment 2024-06-18] [$250] Task- User avatar when opening from task preview mention is not the same as chat header avatar[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Task- User avatar when opening from task preview mention is not the same as chat header avatar[/+]melvin-bot commentedon Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
CortneyOfstad commentedon Jun 19, 2024
@allroundexperts can you please complete the checklist by EOD so there is no delay in payment tomorrow? Thanks!
CortneyOfstad commentedon Jun 20, 2024
@allroundexperts bump on the checklist above ^^^
allroundexperts commentedon Jun 23, 2024
On it today!
allroundexperts commentedon Jun 23, 2024
Checklist
mergebeforeset.CortneyOfstad commentedon Jun 24, 2024
Payment Summary
@tienifr — paid $250 via Upwork
@allroundexperts — to be paid $250 via NewDot
JmillsExpensify commentedon Jul 20, 2024
$250 approved for @allroundexperts