You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-11] App crashes due to trying to access accountIdToName prop in epensimark on an undefined variable #42161
changed the title [-]App crashes due to trying to access accountIdToName prop in epensimark on an undefined variable[/-][+][HOLD for payment 2024-06-11] App crashes due to trying to access accountIdToName prop in epensimark on an undefined variable[/+]on Jun 4, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@iwiznia] The PR that introduced the bug has been identified. Link to the PR:
[@iwiznia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@iwiznia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@war-in] Determine if we should create a regression test for this bug.
[@war-in] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@twisterdotcom I reviewed the initial PR as C+ but it was reverted in #42914, therefore no payment is due here and the hold for payment can be removed.
Not sure if I'm still needed as reviewer for PR number 2 🤔
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon May 14, 2024
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.war-in commentedon May 14, 2024
Hi, I'm Marcin from Software Mansion and I would like to work on this
twisterdotcom commentedon May 14, 2024
Doesn't look like I'm needed here as no C+ reviewed these PRs, but LMK if anybody needs paying.
ahmedGaber93 commentedon May 14, 2024
@robertKozik @war-in I think we still have a type error as here we use
accountIdToNamewithId, but its type here defines asaccountIDToNamewithIDrobertKozik commentedon May 15, 2024
Yeah you're right, there is typo in the types. I'll spin up the PR soon
melvin-bot commentedon May 31, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
21 remaining items
[-]App crashes due to trying to access accountIdToName prop in epensimark on an undefined variable[/-][+][HOLD for payment 2024-06-11] App crashes due to trying to access accountIdToName prop in epensimark on an undefined variable[/+]melvin-bot commentedon Jun 4, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 4, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ikevin127 commentedon Jun 4, 2024
1st PR for this was reverted.
sonialiap commentedon Jun 10, 2024
I can't access a chat with a client, possible same issue https://github.com/Expensify/Expensify/issues/403390
iwiznia commentedon Jun 10, 2024
@war-in @blazejkustra we are missing re-updating the version of expensify commons the App uses, no?
war-in commentedon Jun 10, 2024
Afaik @blazejkustra updated the
expensify-commonin this PR. It includes a fix for this bug.And I'm almost finished with the mentions editing PR here
twisterdotcom commentedon Jun 11, 2024
Okay, Is this ready for payment yet or not? Does it even need payment? Perhaps only for @ikevin127 somewhere?
ikevin127 commentedon Jun 11, 2024
@twisterdotcom I reviewed the initial PR as C+ but it was reverted in #42914, therefore no payment is due here and the hold for payment can be removed.
Not sure if I'm still needed as reviewer for PR number 2 🤔
melvin-bot commentedon Jun 11, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
sonialiap commentedon Jun 13, 2024
I was able to load the chat today without issue 😁 thank you for the fix!
twisterdotcom commentedon Jun 13, 2024
Looks like it was internally reviewed. Okay, closing this then.