Skip to content

[HOLD for payment 2024-06-11] App crashes due to trying to access accountIdToName prop in epensimark on an undefined variable #42161

Closed

Description

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 14, 2024
  2. self-assigned this
    on May 14, 2024
  3. melvin-bot commented on May 14, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. war-in commented on May 14, 2024

    @war-in
    Contributor

    Hi, I'm Marcin from Software Mansion and I would like to work on this

  5. twisterdotcom commented on May 14, 2024

    @twisterdotcom
    Contributor

    Doesn't look like I'm needed here as no C+ reviewed these PRs, but LMK if anybody needs paying.

  6. ahmedGaber93 commented on May 14, 2024

    @ahmedGaber93
    Contributor

    @robertKozik @war-in I think we still have a type error as here we use accountIdToName with Id, but its type here defines as accountIDToName with ID

  7. robertKozik commented on May 15, 2024

    @robertKozik
    Contributor

    Yeah you're right, there is typo in the types. I'll spin up the PR soon

  8. melvin-bot commented on May 31, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. 21 remaining items

  10. changed the title [-]App crashes due to trying to access accountIdToName prop in epensimark on an undefined variable[/-] [+][HOLD for payment 2024-06-11] App crashes due to trying to access accountIdToName prop in epensimark on an undefined variable[/+] on Jun 4, 2024
  11. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-11. 🎊

    For reference, here are some details about the assignees on this issue:

    • @war-in does not require payment (Contractor)
  12. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@iwiznia] The PR that introduced the bug has been identified. Link to the PR:
    • [@iwiznia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@iwiznia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@war-in] Determine if we should create a regression test for this bug.
    • [@war-in] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. ikevin127 commented on Jun 4, 2024

    @ikevin127
    Contributor

    1st PR for this was reverted.

  14. sonialiap commented on Jun 10, 2024

    @sonialiap
    Contributor

    I can't access a chat with a client, possible same issue https://github.com/Expensify/Expensify/issues/403390

  15. iwiznia commented on Jun 10, 2024

    @iwiznia
    ContributorAuthor

    @war-in @blazejkustra we are missing re-updating the version of expensify commons the App uses, no?

  16. war-in commented on Jun 10, 2024

    @war-in
    Contributor

    Afaik @blazejkustra updated the expensify-common in this PR. It includes a fix for this bug.
    And I'm almost finished with the mentions editing PR here

  17. twisterdotcom commented on Jun 11, 2024

    @twisterdotcom
    Contributor

    Okay, Is this ready for payment yet or not? Does it even need payment? Perhaps only for @ikevin127 somewhere?

  18. ikevin127 commented on Jun 11, 2024

    @ikevin127
    Contributor

    @twisterdotcom I reviewed the initial PR as C+ but it was reverted in #42914, therefore no payment is due here and the hold for payment can be removed.

    Not sure if I'm still needed as reviewer for PR number 2 🤔

  19. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  20. sonialiap commented on Jun 13, 2024

    @sonialiap
    Contributor

    I was able to load the chat today without issue 😁 thank you for the fix!

  21. twisterdotcom commented on Jun 13, 2024

    @twisterdotcom
    Contributor

    Looks like it was internally reviewed. Okay, closing this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions