Skip to content

Workspace switcher - Workspace icon is displayed when Expensify filter is selected #42190

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.74-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • There is at least 1 workspace
  1. Go to staging.new.expensify.com
  2. Open workspace switcher
  3. Select a workspace
  4. Open workspace switcher again
  5. Select Expensify

Expected Result:

Expensify logo will display next to the breadcrumbs

Actual Result:

A workspace icon is displayed next to the breadcrumbs after switching from workspace back to Expensify

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6481505_1715771313081.E.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on May 15, 2024
  2. melvin-bot commented on May 15, 2024

    @melvin-bot

    Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on May 15, 2024

    @melvin-bot

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

    1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
      • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
    2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
      • You can adjust the urgency of the issue to better represent the gravity of the bug.
      • If the issue is super low priority, feel free to un-assign yourself.
      • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
      • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

    Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

  4. github-actions commented on May 15, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. lanitochka17 commented on May 15, 2024

    @lanitochka17
    Author

    @iwiznia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. lanitochka17 commented on May 15, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  7. Nodebrute commented on May 15, 2024

    @Nodebrute
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace icon is displayed when Expensify filter is selected

    What is the root cause of that problem?

    We are passing an empty string here. It should be undefined.

    What changes do you think we should make in order to solve the problem?

    We can remove PolicyID from here or set it to undefined.

  8. iwiznia commented on May 15, 2024

    @iwiznia
    Contributor

    I think the bug is coming from #41769 testing that theory now

  9. iwiznia commented on May 15, 2024

    @iwiznia
    Contributor

    Nope

  10. iwiznia commented on May 15, 2024

    @iwiznia
    Contributor

    ok @Nodebrute your fix works. I think we need to change this

    to policyID? too.
    Though I am a bit confused on what PR caused this though...

  11. Nodebrute commented on May 15, 2024

    @Nodebrute
    Contributor

    @iwiznia

    ok @Nodebrute your fix works. I think we need to change this

    to policyID? too.

    Correct.

  12. Nodebrute commented on May 15, 2024

    @Nodebrute
    Contributor

    @iwiznia I also struggle to find it, but I believe this is the correct RCA. This bug has always been present, but it's only now coming to light due to some recent PR. The workspace switcher policyID should always be undefined.

  13. Nodebrute commented on May 15, 2024

    @Nodebrute
    Contributor

    @iwiznia Could you assign me to work on the fix?"

  14. iwiznia commented on May 15, 2024

    @iwiznia
    Contributor

    Yep, assigned you, thanks!

  15. allgandalf commented on May 15, 2024

    @allgandalf
    Contributor

    I think this may be coming from #40016 @iwiznia

  16. iwiznia commented on May 15, 2024

    @iwiznia
    Contributor

    That's correct, thanks @GandalfGwaihir!

  17. Nodebrute commented on May 15, 2024

    @Nodebrute
    Contributor

    @iwiznia #42223 You can merge this PR in case you decide to go with this fix.

  18. iwiznia commented on May 16, 2024

    @iwiznia
    Contributor

    This is working now, just tested on staging

  19. removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions