You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Workspace switcher - Workspace icon is displayed when Expensify filter is selected #42190
Version Number: 1.4.74-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
There is at least 1 workspace
Go to staging.new.expensify.com
Open workspace switcher
Select a workspace
Open workspace switcher again
Select Expensify
Expected Result:
Expensify logo will display next to the breadcrumbs
Actual Result:
A workspace icon is displayed next to the breadcrumbs after switching from workspace back to Expensify
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
You can adjust the urgency of the issue to better represent the gravity of the bug.
If the issue is super low priority, feel free to un-assign yourself.
Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@iwiznia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
@iwiznia I also struggle to find it, but I believe this is the correct RCA. This bug has always been present, but it's only now coming to light due to some recent PR. The workspace switcher policyID should always be undefined.
Activity
melvin-bot commentedon May 15, 2024
Triggered auto assignment to @iwiznia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 15, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
github-actions commentedon May 15, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon May 15, 2024
@iwiznia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon May 15, 2024
We think that this bug might be related to #vip-vsp
Nodebrute commentedon May 15, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace icon is displayed when Expensify filter is selected
What is the root cause of that problem?
We are passing an empty string here. It should be undefined.
App/src/pages/WorkspaceSwitcherPage/index.tsx
Line 148 in 1ee5d03
What changes do you think we should make in order to solve the problem?
We can remove PolicyID from here or set it to undefined.
iwiznia commentedon May 15, 2024
I think the bug is coming from #41769 testing that theory now
iwiznia commentedon May 15, 2024
Nope
iwiznia commentedon May 15, 2024
ok @Nodebrute your fix works. I think we need to change this
App/src/pages/WorkspaceSwitcherPage/index.tsx
Line 26 in 6dfa942
policyID?too.Though I am a bit confused on what PR caused this though...
Nodebrute commentedon May 15, 2024
@iwiznia
Correct.
Nodebrute commentedon May 15, 2024
@iwiznia I also struggle to find it, but I believe this is the correct RCA. This bug has always been present, but it's only now coming to light due to some recent PR. The workspace switcher policyID should always be undefined.
Nodebrute commentedon May 15, 2024
@iwiznia Could you assign me to work on the fix?"
iwiznia commentedon May 15, 2024
Yep, assigned you, thanks!
allgandalf commentedon May 15, 2024
I think this may be coming from #40016 @iwiznia
iwiznia commentedon May 15, 2024
That's correct, thanks @GandalfGwaihir!
Nodebrute commentedon May 15, 2024
@iwiznia #42223 You can merge this PR in case you decide to go with this fix.
iwiznia commentedon May 16, 2024
This is working now, just tested on staging