You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Scan - "Only visible to you" whisper is not visible on multiple request report #42259
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
You can adjust the urgency of the issue to better represent the gravity of the bug.
If the issue is super low priority, feel free to un-assign yourself.
Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@grgia can you confirm expected behavior here? My understanding is with the updated pending transactions project, we should never see the "only you can see this" whisper pattern with scanning expenses.
Yes this is expected as of right now, since we're removing whispers from scan. We're still waiting on this BE change to remove the whisper logic entirely, but we stopped showing it in the FE
Nice, thanks - yeah since it looks like we're missing one place, @grgia do you think we should work on that in this issue OR create a fresh one for that 1 spot? OR do you think the backend PRs should fix this? 🙏
@grgia sorry but it's still not quite clear to me if the BE PR will fix the "bug" shown here - #42259 (comment) - that there is still 1 final place we DO show "Only visible to you" where we shouldn't.
If you can confirm that the BE PR will fix that, I think we're good to close this one out, yeah? 🙏
@Beamanator we're removing whispers from all newly created pending/scanning transactions, so we shouldn't see "only visible to you" at all. We could remove it from the UI as part of this issue for existing transactions though. Does that answer your question?
Yeah we can bring this up in slack, it honestly won't affect many reports since they are only pending or scanning for a day or two. I take it back on fixing it in this issue, I'm pretty sure we can close this one in favor of the BE changes @Beamanator. Happy to jump into a discussion in slack if there's still something that's uncertain here
Activity
melvin-bot commentedon May 16, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 16, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
melvin-bot commentedon May 16, 2024
Triggered auto assignment to @Beamanator (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon May 16, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
29 remaining items
Beamanator commentedon May 21, 2024
cc @yuwenmemon , maybe even @Expensify/design - can y'all confirm if ^ is a bug?
shawnborton commentedon May 21, 2024
@grgia can you confirm expected behavior here? My understanding is with the updated pending transactions project, we should never see the "only you can see this" whisper pattern with scanning expenses.
grgia commentedon May 21, 2024
Yes this is expected as of right now, since we're removing whispers from scan. We're still waiting on this BE change to remove the whisper logic entirely, but we stopped showing it in the FE
shawnborton commentedon May 21, 2024
Got it - thanks for confirming. Can you check the video in the bug report? It looks like maybe we missed a spot then?

Beamanator commentedon May 21, 2024
Nice, thanks - yeah since it looks like we're missing one place, @grgia do you think we should work on that in this issue OR create a fresh one for that 1 spot? OR do you think the backend PRs should fix this? 🙏
hungvu193 commentedon May 24, 2024
little bump @grgia
grgia commentedon May 24, 2024
@Beamanator the BE PR is removing whispers from pending/scanning receipts
hungvu193 commentedon May 27, 2024
@Beamanator I just want to clarify if this issue is treated as a regression, if yes please unassign me 😄
Beamanator commentedon May 27, 2024
@grgia sorry but it's still not quite clear to me if the BE PR will fix the "bug" shown here - #42259 (comment) - that there is still 1 final place we DO show "Only visible to you" where we shouldn't.
If you can confirm that the BE PR will fix that, I think we're good to close this one out, yeah? 🙏
hungvu193 commentedon May 29, 2024
@grgia can you please confirm above comment?
grgia commentedon May 29, 2024
@Beamanator we're removing whispers from all newly created pending/scanning transactions, so we shouldn't see "only visible to you" at all. We could remove it from the UI as part of this issue for existing transactions though. Does that answer your question?
Beamanator commentedon May 29, 2024
Ahhhh the point is that the whisper already exists for old transactions, but shouldn't happen for new ones, eh?
Has this been discussed anywhere in the doc or other threads @grgia ? If not, maybe we should bring it up somewhere?
grgia commentedon May 29, 2024
Yeah we can bring this up in slack, it honestly won't affect many reports since they are only pending or scanning for a day or two. I take it back on fixing it in this issue, I'm pretty sure we can close this one in favor of the BE changes @Beamanator. Happy to jump into a discussion in slack if there's still something that's uncertain here
Beamanator commentedon May 29, 2024
Ok cool I'm also down with closing in favor of BE changes, let's go for it 👍