Skip to content

[$250] Scan - "Only visible to you" whisper is not visible on multiple request report #42259

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.74-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4561920
Email or phone of affected tester (no customers): dave0123seife+employe16a@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Navigate to the workspace chat as the employee
  2. Submit a request using a scan
  3. While it is Scanning, There's a whisper message on top of the request "Only visible to you" (this might take a few sec to show up)
  4. Submit a manual request.
  5. Because we have not submitted the requests, Notice both requests are in one request conversation,
  6. Notice that there is no whisper message on top of the request "Only visible to you"

Expected Result:

"Only visible to you" whisper is visible on multiple request report

Actual Result:

"Only visible to you" whisper is not visible on multiple request report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6482265_1715826847238.Only_visible_to_You_issue.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ba739091862c309e
  • Upwork Job ID: 1791487887666659328
  • Last Price Increase: 2024-05-17
Issue OwnerCurrent Issue Owner: @hungvu193

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 16, 2024
  2. melvin-bot commented on May 16, 2024

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 16, 2024

    @melvin-bot

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

    1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
      • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
    2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
      • You can adjust the urgency of the issue to better represent the gravity of the bug.
      • If the issue is super low priority, feel free to un-assign yourself.
      • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
      • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

    Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

  4. melvin-bot commented on May 16, 2024

    @melvin-bot

    Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. github-actions commented on May 16, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. 29 remaining items

  7. Beamanator commented on May 21, 2024

    @Beamanator
    Contributor

    cc @yuwenmemon , maybe even @Expensify/design - can y'all confirm if ^ is a bug?

  8. shawnborton commented on May 21, 2024

    @shawnborton
    Contributor

    @grgia can you confirm expected behavior here? My understanding is with the updated pending transactions project, we should never see the "only you can see this" whisper pattern with scanning expenses.

  9. grgia commented on May 21, 2024

    @grgia
    Contributor

    Yes this is expected as of right now, since we're removing whispers from scan. We're still waiting on this BE change to remove the whisper logic entirely, but we stopped showing it in the FE

  10. shawnborton commented on May 21, 2024

    @shawnborton
    Contributor

    Got it - thanks for confirming. Can you check the video in the bug report? It looks like maybe we missed a spot then?
    CleanShot 2024-05-21 at 08 11 30@2x

  11. Beamanator commented on May 21, 2024

    @Beamanator
    Contributor

    Nice, thanks - yeah since it looks like we're missing one place, @grgia do you think we should work on that in this issue OR create a fresh one for that 1 spot? OR do you think the backend PRs should fix this? 🙏

  12. hungvu193 commented on May 24, 2024

    @hungvu193
    Contributor

    little bump @grgia

  13. grgia commented on May 24, 2024

    @grgia
    Contributor

    @Beamanator the BE PR is removing whispers from pending/scanning receipts

  14. hungvu193 commented on May 27, 2024

    @hungvu193
    Contributor

    @Beamanator I just want to clarify if this issue is treated as a regression, if yes please unassign me 😄

  15. Beamanator commented on May 27, 2024

    @Beamanator
    Contributor

    @grgia sorry but it's still not quite clear to me if the BE PR will fix the "bug" shown here - #42259 (comment) - that there is still 1 final place we DO show "Only visible to you" where we shouldn't.

    If you can confirm that the BE PR will fix that, I think we're good to close this one out, yeah? 🙏

  16. hungvu193 commented on May 29, 2024

    @hungvu193
    Contributor

    @grgia can you please confirm above comment?

  17. grgia commented on May 29, 2024

    @grgia
    Contributor

    @Beamanator we're removing whispers from all newly created pending/scanning transactions, so we shouldn't see "only visible to you" at all. We could remove it from the UI as part of this issue for existing transactions though. Does that answer your question?

  18. Beamanator commented on May 29, 2024

    @Beamanator
    Contributor

    Ahhhh the point is that the whisper already exists for old transactions, but shouldn't happen for new ones, eh?

    We could remove it from the UI as part of this issue for existing transactions though.

    Has this been discussed anywhere in the doc or other threads @grgia ? If not, maybe we should bring it up somewhere?

  19. grgia commented on May 29, 2024

    @grgia
    Contributor

    Yeah we can bring this up in slack, it honestly won't affect many reports since they are only pending or scanning for a day or two. I take it back on fixing it in this issue, I'm pretty sure we can close this one in favor of the BE changes @Beamanator. Happy to jump into a discussion in slack if there's still something that's uncertain here

  20. Beamanator commented on May 29, 2024

    @Beamanator
    Contributor

    Ok cool I'm also down with closing in favor of BE changes, let's go for it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions