You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-28] [$250] IOU-User is shown option to submit expense using group. #42261
changed the title [-]IOU-User is shown option to submit expense using group.[/-][+][$250] IOU-User is shown option to submit expense using group.[/+]on May 16, 2024
changed the title [-][HOLD for payment 2024-06-24] [$250] IOU-User is shown option to submit expense using group.[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] IOU-User is shown option to submit expense using group.[/+]on Jun 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
[@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ishpaul777] Determine if we should create a regression test for this bug.
[@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] IOU-User is shown option to submit expense using group.[/-][+][HOLD for payment 2024-06-28] [$250] IOU-User is shown option to submit expense using group.[/+]on Jun 26, 2024
[@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: I was only able to track this to a very old PR -#10784
[@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: I am not sure if the bug from that PR since group chat is a feature released after that so not commenting.
[@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
[@ishpaul777] Determine if we should create a regression test for this bug.- No , this was a very rare edge case.
[@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.- No
Activity
melvin-bot commentedon May 16, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.izarutskaya commentedon May 16, 2024
We think this issue might be related to the #vip-vsb.
melvin-bot commentedon May 16, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01099fb6a88b2692fc
[-]IOU-User is shown option to submit expense using group.[/-][+][$250] IOU-User is shown option to submit expense using group.[/+]melvin-bot commentedon May 16, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (
External)50 remaining items
[-][HOLD for payment 2024-06-24] [$250] IOU-User is shown option to submit expense using group.[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] IOU-User is shown option to submit expense using group.[/+]melvin-bot commentedon Jun 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 21, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
chiragsalian commentedon Jun 26, 2024
Not overdue, hold for payment.
[-][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] IOU-User is shown option to submit expense using group.[/-][+][HOLD for payment 2024-06-28] [$250] IOU-User is shown option to submit expense using group.[/+]sakluger commentedon Jun 26, 2024
The actual payment date is 6/28.
sakluger commentedon Jun 28, 2024
Summarizing payment on this issue:
Contributor: @nkdengineer $250, paid via Upwork
Contributor+: @ishpaul777 $250, paid via Upwork
@ishpaul777 could you please complete the BZ checklist today? Thanks!
ishpaul777 commentedon Jun 28, 2024
[@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: I was only able to track this to a very old PR -#10784
[@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: I am not sure if the bug from that PR since group chat is a feature released after that so not commenting.
[@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
[@ishpaul777] Determine if we should create a regression test for this bug.- No , this was a very rare edge case.
[@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.- No
sakluger commentedon Jun 28, 2024
Thank you!