Skip to content

[HOLD for payment 2024-06-28] [$250] IOU-User is shown option to submit expense using group. #42261

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.74-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Launch app
  2. Tap start chat
  3. Add a user and create group
  4. Tap header -- member -- invite
  5. Invite user A
  6. Login in mweb as user A
  7. As user A, note group chat in lhn
  8. As group admin, in Android app remove another user (not user A)
  9. In mweb, as member note green dot shown in LHN for removed user
  10. In mweb, tap on the chat and navigate to members page
  11. In Android app, as group admin tap back and "Leave group"
  12. In mweb, note in members page, now member is shown as "admin"
  13. Navigate to LHN
  14. Tap fab -- submit expense
  15. Enter an amount and tap next
  16. Select group shown in recent
  17. Tap submit

Expected Result:

User must not be shown option to submit expense using group.

In group user's LHN, when user removed green dot is shown.

Actual Result:

User is shown option to submit expense using group.

In group user's LHN, when user removed green dot must not be shown.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6482069_1715809572377.rename.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01099fb6a88b2692fc
  • Upwork Job ID: 1791216875339001856
  • Last Price Increase: 2024-05-16
  • Automatic offers:
    • ishpaul777 | Reviewer | 102546813
    • nkdengineer | Contributor | 102546815
Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 16, 2024
  2. melvin-bot commented on May 16, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. izarutskaya commented on May 16, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb.

  4. removed their assignment
    on May 16, 2024
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 16, 2024
  6. melvin-bot commented on May 16, 2024

    @melvin-bot
  7. changed the title [-]IOU-User is shown option to submit expense using group.[/-] [+][$250] IOU-User is shown option to submit expense using group.[/+] on May 16, 2024
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 16, 2024
  9. melvin-bot commented on May 16, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

  10. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 16, 2024
  11. 50 remaining items

  12. changed the title [-][HOLD for payment 2024-06-24] [$250] IOU-User is shown option to submit expense using group.[/-] [+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] IOU-User is shown option to submit expense using group.[/+] on Jun 21, 2024
  13. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-28. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
    • [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ishpaul777] Determine if we should create a regression test for this bug.
    • [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. chiragsalian commented on Jun 26, 2024

    @chiragsalian
    Contributor

    Not overdue, hold for payment.

  16. changed the title [-][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] IOU-User is shown option to submit expense using group.[/-] [+][HOLD for payment 2024-06-28] [$250] IOU-User is shown option to submit expense using group.[/+] on Jun 26, 2024
  17. sakluger commented on Jun 26, 2024

    @sakluger
    Contributor

    The actual payment date is 6/28.

  18. sakluger commented on Jun 28, 2024

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor: @nkdengineer $250, paid via Upwork
    Contributor+: @ishpaul777 $250, paid via Upwork

    @ishpaul777 could you please complete the BZ checklist today? Thanks!

  19. ishpaul777 commented on Jun 28, 2024

    @ishpaul777
    Contributor

    [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: I was only able to track this to a very old PR -#10784
    [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: I am not sure if the bug from that PR since group chat is a feature released after that so not commenting.
    [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
    [@ishpaul777] Determine if we should create a regression test for this bug.- No , this was a very rare edge case.
    [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.- No

  20. sakluger commented on Jun 28, 2024

    @sakluger
    Contributor

    Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions