Skip to content

[Xero] Import page error message RBR isn't always displayed #42268

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating #41917
Version Number: 1.4.74-1
Reproducible in staging?: yes
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Preconditions:

  1. Log in with an expensifail account
  2. Have a Collect workspace with accounting enabled and Xero connected.
  3. Simulate failing network requests is tuned on in the troubleshoot tab.
  4. Navigate to workspace settings - Accounting - Import turn on or off "Tracking categories" "Re-bill customers" and "Taxes"

Expected Result:

RBR should always show.

Actual Result:

Xero Import page error message RBR isn't always displayed. I was only able to get the RBR on iOS but only for one of the three import options.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6482451_1715843808825.HPWO1924.mp4

Bug6482451_1715843808811!IMG_0456

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 16, 2024
  2. melvin-bot commented on May 16, 2024

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 16, 2024

    @melvin-bot

    Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 16, 2024

    @melvin-bot

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

    1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
      • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
    2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
      • You can adjust the urgency of the issue to better represent the gravity of the bug.
      • If the issue is super low priority, feel free to un-assign yourself.
      • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
      • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

    Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

  5. github-actions commented on May 16, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. 29 remaining items

  7. added and removed on Jun 3, 2024
  8. trjExpensify commented on Jun 10, 2024

    @trjExpensify
    Contributor

    @m-natarajan did you get to retesting this?

  9. Julesssss commented on Jun 10, 2024

    @Julesssss
    Contributor

    Shared in QA here asking for a test

  10. muttmuure commented on Jun 19, 2024

    @muttmuure
    Contributor

    Waiting for retest

  11. Julesssss commented on Jun 28, 2024

    @Julesssss
    Contributor

    I asked for a retest today in #qa

  12. kbecciv commented on Jul 1, 2024

    @kbecciv

    Issue is reproducible

    bandicam.2024-07-01.17-20-52-006.1.mp4
  13. Julesssss commented on Jul 1, 2024

    @Julesssss
    Contributor

    Actual Result
    I was only able to get the RBR on iOS but only for one of the three import options.

    After re-reading @SzymczakJ's comment here I realise that this isn't a bug and we needed to retest with a 5 minute delay, instead of following the original steps.

    Rather than doing that again though, I say we just close. Reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions