You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-20] [$250] Quick action - Submit button displays different amount compared to amount in BNP #42283
For submitting an expense via a workspace, we do not show the amount in Submit button so to be consistent with that approach we won't show the amount in 1:1 requests as well.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Amount is displayed in Submit Button, this is inconsistent with other type of requests, we should not show it.
What is the root cause of that problem?
We decide the text of the submit button based on the function buttonText
This useMemo has a dependency for currency, so whenever the currency updated the latest amount in BNP gets updated but when we update the amount we do not have that action in useMemo dependency:
hence we do not see the amount change, but to be consistent with other type requests and the time we split request for the first time we should not show the amount in submit button.
What changes do you think we should make in order to solve the problem?
We need to remove the currency dependency if we decide to not show the amount at all when we update the currency.
Else we need to add dependency in the useMemo to call the buttonText whenever we update the amount, but I don't think so we want that!
What alternative solutions did you explore? (Optional)
@kevinksullivan this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
[@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@dukenv0307] Determine if we should create a regression test for this bug.
[@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR: N/A
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. No
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
Activity
melvin-bot commentedon May 16, 2024
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.izarutskaya commentedon May 16, 2024
We think this issue might be related to the #vip-vsb.
allgandalf commentedon May 16, 2024
For submitting an expense via a workspace, we do not show the amount in Submit button so to be consistent with that approach we won't show the amount in 1:1 requests as well.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Amount is displayed in Submit Button, this is inconsistent with other type of requests, we should not show it.
What is the root cause of that problem?
We decide the text of the submit button based on the function
buttonTextApp/src/pages/iou/MoneyRequestAmountForm.tsx
Line 231 in fb14d5a
This
useMemohas a dependency for currency, so whenever the currency updated the latest amount inBNPgets updated but when we update the amount we do not have that action inuseMemodependency:App/src/pages/iou/MoneyRequestAmountForm.tsx
Line 254 in fb14d5a
hence we do not see the amount change, but to be consistent with other type requests and the time we split request for the first time we should not show the amount in
submit button.What changes do you think we should make in order to solve the problem?
We need to remove the
currencydependency if we decide to not show the amount at all when we update the currency.Else we need to add dependency in the
useMemoto call thebuttonTextwhenever we update the amount, but I don't think so we want that!What alternative solutions did you explore? (Optional)
kevinksullivan commentedon May 20, 2024
chatting about this one here
https://expensify.slack.com/archives/C036QM0SLJK/p1716247123666409
melvin-bot commentedon May 24, 2024
@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon May 28, 2024
@kevinksullivan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon May 30, 2024
@kevinksullivan this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon May 30, 2024
@kevinksullivan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
melvin-bot commentedon Jun 3, 2024
@kevinksullivan 12 days overdue now... This issue's end is nigh!
42 remaining items
melvin-bot commentedon Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
cretadn22 commentedon Jun 24, 2024
@kevinksullivan Hi, the payment is ready.
melvin-bot commentedon Jun 24, 2024
@Beamanator, @kevinksullivan, @dukenv0307, @cretadn22 Huh... This is 4 days overdue. Who can take care of this?
kevinksullivan commentedon Jun 25, 2024
@dukenv0307 can you complete the checklist above please?
kevinksullivan commentedon Jun 25, 2024
Payments made to @cretadn22 and @dukenv0307 , just waiting on the checklist's completion.
dukenv0307 commentedon Jun 26, 2024
BugZero Checklist:
dukenv0307 commentedon Jun 26, 2024
@kevinksullivan Thanks for pointing that out. We're good to close this issue
kevinksullivan commentedon Jun 26, 2024
Thanks @dukenv0307 ! All set here.