Skip to content

[HOLD for payment 2024-06-06] [$250] [Banner] text overflow on native #42373

Closed

Description

@rushatgabhane

Coming from #41199 (review)

Problem

On native platforms, the text inside Banner component overflows.

Use the linked PR to test it.

image

image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01da04c416bad8e2f6
  • Upwork Job ID: 1792579160211070976
  • Last Price Increase: 2024-05-20
  • Automatic offers:
    • Krishna2323 | Contributor | 0
Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 20, 2024
  2. melvin-bot commented on May 20, 2024

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. Krishna2323 commented on May 20, 2024

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    [Banner] text overflow on native

    What is the root cause of that problem?

    This is a know issue in react native and is caused by using flexRow on parent view.

    What changes do you think we should make in order to solve the problem?

    We need to add {flex: 1, flexWrap: 'wrap'} style to Text inside Banner. Or { flexShrink: 1 }.

    <Text
    style={textStyles}
    onPress={onPress}
    suppressHighlighting
    >

    We also need to apply styles.justifyContentCenter to main View container.

    Or we can move <Tooltip text={translate('common.close')}> into the same view container which renders the icon and text and then refactor some stylings.

    What alternative solutions did you explore? (Optional)

    Result

    banner_text_overflow
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 20, 2024
  5. melvin-bot commented on May 20, 2024

    @melvin-bot
  6. changed the title [-][Banner] text overflow on native[/-] [+][$250] [Banner] text overflow on native[/+] on May 20, 2024
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 20, 2024
  8. melvin-bot commented on May 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  9. rushatgabhane commented on May 20, 2024

    @rushatgabhane
    MemberAuthor

    @sobitneupane jumping the gun here
    @Krishna2323 could you please raise a PR? It's blocking PR #41199 (review)

  10. rushatgabhane commented on May 20, 2024

    @rushatgabhane
    MemberAuthor

    🎀 👀 🎀

  11. 12 remaining items

  12. changed the title [-][$250] [Banner] text overflow on native[/-] [+][HOLD for payment 2024-06-06] [$250] [Banner] text overflow on native[/+] on May 30, 2024
  13. melvin-bot commented on May 30, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on May 30, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-06. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on May 30, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@francoisl] The PR that introduced the bug has been identified. Link to the PR:
    • [@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Krishna2323] Determine if we should create a regression test for this bug.
    • [@Krishna2323] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. rushatgabhane commented on May 30, 2024

    @rushatgabhane
    MemberAuthor

    @lschurr could you please assign me the issue for c+

  17. rushatgabhane commented on May 30, 2024

    @rushatgabhane
    MemberAuthor
    1. The PR that introduced the bug has been identified. Link to the PR: Render banner in Concierge chat #11363

    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/11363/files#r1621464572

    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A. PR was 2 years old

    4. Determine if we should create a regression test for this bug. Yes

    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

         1. Open the app in two devices.
         2. In the first device login with user A.
         3. Click fab > Start chat > Room.
         4. Type the room name and set "Who can post." to "Admin only" then complete creating proccess.
         5. Invite user B to the room.
         6. In the other device login with user B and go to the room and Verify that "admins only can post" message is displayed on chat footer rather than welcome message.
         7. Verify the banner text is wrapped into multiple lines and does not overflow on small width devices
      
  18. rushatgabhane commented on May 30, 2024

    @rushatgabhane
    MemberAuthor

    @lschurr could you please attach payment summary, thank you!

  19. lschurr commented on Jun 6, 2024

    @lschurr
    Contributor

    Looks like the automation didn't work.

    Payment summary:

  20. lschurr commented on Jun 6, 2024

    @lschurr
    Contributor

    Requested QA test be added. Closing this one out.

  21. JmillsExpensify commented on Jun 6, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions