Skip to content

[Awaiting Contributor Response for Payment - Payment 27th June] [$250] Incorrect video is paused after turning on and off full screen mode #42427

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.74-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @blimpich / @KMichel1030
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1716239323512349

Action Performed:

  1. Upload two videos (Video1, Video2)
  2. Play Video1
  3. Play Video2
  4. Click full screen mode button of Video1 while Video2 is playing
  5. Exit full screen mode by pressing Esc key
  6. Click play button of Video1

Expected Result:

Video1 should be played

Actual Result:

Video2 is played

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

bandicam.2024-05-17.08-42-04-936.mp4
Recording.97.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0153a7421c659e1e1b
  • Upwork Job ID: 1793023328329351168
  • Last Price Increase: 2024-05-28
  • Automatic offers:
    • hoangzinh | Reviewer | 102587027
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 21, 2024
  2. melvin-bot commented on May 21, 2024

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. trjExpensify commented on May 21, 2024

    @trjExpensify
    Contributor

    @KMichel1030 are you interesting in proposing a solution for this?

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 21, 2024
  5. changed the title [-]Incorrect video is paused after turning on and off full screen mode[/-] [+][$250] Incorrect video is paused after turning on and off full screen mode[/+] on May 21, 2024
  6. melvin-bot commented on May 21, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 21, 2024
  8. melvin-bot commented on May 21, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  9. jacobnguyen0000 commented on May 21, 2024

    @jacobnguyen0000
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Incorrect video is paused after turning on and off full screen mode

    What is the root cause of that problem?

    When entering full screen mode, currentlyPlayingURL is updated, but currentVideoPlayerRef is not updated because we have isFullScreenRef check here.
    Since we use currentVideoPlayerRef when play and pause video, incorrect video is paused.

    What changes do you think we should make in order to solve the problem?

    We should remove isFullScreenRef check here.
    We also need to modify last parameter of this line to prevent auto play when entering full screen mode.

    What alternative solutions did you explore? (Optional)

  10. melvin-bot commented on May 21, 2024

    @melvin-bot

    📣 @jacobnguyen0000! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  11. tienifr commented on May 22, 2024

    @tienifr
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    What is the root cause of that problem?

    • Let say we have two video A and B.

    • When we play B then enter the fullscreen mode with A, we call updateCurrentlyPlayingURL in here and we do not call shareVideoPlayerElements in here. Now currentlyPlayingURL refers to A, but currentVideoPlayerRef refers to B.

    • Then, after we turn off fullscreen mode, currentlyPlayingURL still refers to A, but currentVideoPlayerRef still refers to B.

    • So when we click on the "Play" button in A, in here, because isCurrentlyURLSet is true, so the updateCurrentlyPlayingURL(url) is not called.

    • So this useEffect is not called because one of its dependences, currentlyPlayingURL is not updated. That leads to currentVideoPlayerRef still refers to B. That why we click on "Play" button in A, B is played.

    What changes do you think we should make in order to solve the problem?

     if (!isUploading && shouldPlayVideo) { 
         playVideo(); 
     }
    
    • Then, we can call this logic manually in here with param shouldPlayVideo: false

    What alternative solutions did you explore? (Optional)

    • We can call updateCurrentlyPlayingURL(null) in here to reset the currently playing url.
  12. 62 remaining items

  13. trjExpensify commented on Jul 8, 2024

    @trjExpensify
    Contributor

    Cool, dropped to weekly. I'll likely just close this after a couple of weeks, and @jacobnguyen0000 can let me know when he's back if he wants to get paid.

  14. trjExpensify commented on Jul 19, 2024

    @trjExpensify
    Contributor

    Closing.

  15. jacobnguyen0000 commented on Aug 6, 2024

    @jacobnguyen0000
    Contributor

    Hi, @trjExpensify
    Sorry for late response. Can I get payment now?

    Contributor details
    Your Expensify account email: jacobnguyen0000@outlook.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~014cac515a92876fc5

  16. melvin-bot commented on Aug 6, 2024

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  17. jacobnguyen0000 commented on Aug 7, 2024

    @jacobnguyen0000
    Contributor

    @mallenexpensify
    It seems @trjExpensify is not here.
    Could you please complete payment here?

  18. trjExpensify commented on Aug 7, 2024

    @trjExpensify
    Contributor

    Sent an offer.

  19. jacobnguyen0000 commented on Aug 7, 2024

    @jacobnguyen0000
    Contributor

    Thank you, @trjExpensify.
    I've accepted offer.

  20. trjExpensify commented on Aug 7, 2024

    @trjExpensify
    Contributor

    Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions