You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-13] [$250] QBO - Default vendor toggle switch activation is delayed #42534
Issue was found when validating #41627 Version Number: 1.4.75-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Precondition: Have a Collect workspace with Quickbooks enabled
Log in with an expensifail account
Navigate to Workspace settings - Accounting - Export - Export company cards as
Click on "Export company cards as"
Click on "Vendor bill"
Click on the "Default vendor" toggle switch
Click on it again
Expected Result:
It should be instant.
Actual Result:
Default vendor toggle switch takes 1-2 seconds to activate after interacting with it.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
You can adjust the urgency of the issue to better represent the gravity of the bug.
If the issue is super low priority, feel free to un-assign yourself.
Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$250] QBO - Default vendor toggle switch activation is delayed[/-][+][HOLD for payment 2024-06-13] [$250] QBO - Default vendor toggle switch activation is delayed[/+]on Jun 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thesahindia] Determine if we should create a regression test for this bug.
[@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@thesahindia can you please have the checklist completed at your earliest convenience? This will help avoid any delays in payment early next week. Thanks!
I'll be OOO from June 10th to June 13th and will return on Friday. I think I'm not needed anymore, but I just wanted to inform you of my upcoming absence. 😄
Activity
melvin-bot commentedon May 23, 2024
Triggered auto assignment to @hayata-suenaga (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 23, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 23, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
github-actions commentedon May 23, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
35 remaining items
[-][$250] QBO - Default vendor toggle switch activation is delayed[/-][+][HOLD for payment 2024-06-13] [$250] QBO - Default vendor toggle switch activation is delayed[/+]melvin-bot commentedon Jun 6, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 6, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
CortneyOfstad commentedon Jun 7, 2024
@thesahindia can you please have the checklist completed at your earliest convenience? This will help avoid any delays in payment early next week. Thanks!
thesahindia commentedon Jun 7, 2024
It's from #39219. It was a big PR and it's easy to miss such small cases.
I don't think we need a test case for this.
hayata-suenaga commentedon Jun 7, 2024
I'll be OOO from June 10th to June 13th and will return on Friday. I think I'm not needed anymore, but I just wanted to inform you of my upcoming absence. 😄
CortneyOfstad commentedon Jun 13, 2024
Payment Summary
@nkdengineer — paid $250 via Upwork
@thesahindia — to be paid $250 via NewDot
Thanks all!
JmillsExpensify commentedon Jun 18, 2024
$250 approved for @thesahindia