You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Workspace - No message is visible for the admin about the flagged invite message #42540
Version Number: 1.4.75-0 Reproducible in staging?: y Reproducible in production?: n (New Feature) If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Admin: Log in with an expensifail account
Admin: Create a new workspace
Admin: Invite a Gmail account to the workspace with "MODERATION_TEST" invite message
Member: Log in as the invited Gmail account
Member: Navigate to the workspace chat
Member: Right click on the invite message and click on "Flag as offensive"
Member: Choose any reason
Admin: Navigate to the workspace chat with the member
Expected Result:
The admin should receive a message about it.
Actual Result:
No message is visible for the admin about the flagged invite message.
Workaround:
none
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
You can adjust the urgency of the issue to better represent the gravity of the bug.
If the issue is super low priority, feel free to un-assign yourself.
Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
I think this shouldn't be a deploy blocker because its largely a new feature not a regression, but also I think the fact that its not working is related to our recent fires. This feature was dependent on an Auth PR that I think got reverted. So this probably doesn't work because of that.
@dangrous@jasperhuangg can you confirm that this is a result of the Auth PR revert? And if so @dangrous could you pick this up and close it out once you can confirm that all the requisite code is deployed that it isn't an issue?
Actually, not due to the revert! It's due to https://github.com/Expensify/Auth/pull/10829 - we removed the admin (flaggee) whisper. So this is working as expected. Apologies on not updating the testing steps.
(Let me know if I'm interpreting the bug correctly @blimpich but I believe this is it.)
Activity
melvin-bot commentedon May 23, 2024
Triggered auto assignment to @blimpich (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 23, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 23, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
github-actions commentedon May 23, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon May 23, 2024
@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
blimpich commentedon May 23, 2024
I think this shouldn't be a deploy blocker because its largely a new feature not a regression, but also I think the fact that its not working is related to our recent fires. This feature was dependent on an Auth PR that I think got reverted. So this probably doesn't work because of that.
@dangrous @jasperhuangg can you confirm that this is a result of the Auth PR revert? And if so @dangrous could you pick this up and close it out once you can confirm that all the requisite code is deployed that it isn't an issue?
dangrous commentedon May 23, 2024
Actually, not due to the revert! It's due to https://github.com/Expensify/Auth/pull/10829 - we removed the admin (flaggee) whisper. So this is working as expected. Apologies on not updating the testing steps.
(Let me know if I'm interpreting the bug correctly @blimpich but I believe this is it.)
blimpich commentedon May 23, 2024
Its a feature! Not a 🐛! My favorite 🙂
That makes sense to me, lets close this out