You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-09] [$250] Distance - Page is not scrollable after adding multiple stops #42577
Please re-state the problem that we are trying to solve in this issue.
Distance - Page is not scrollable after adding multiple stops
What is the root cause of that problem?
The footer (map) for android is rendered separately from the DraggableFlatList (not as a footer of the list) and DraggableFlatList and ListFooterComponent is wrapped in a View instead of ScrollView.
There will be a console error when we will use NestableDraggableFlatList.tsx and thats because of this code using findNodeHandle(scrollableRef.current); instead of passing scrollableRef.current directly to ontainerRef.current.measureLayout. It is also mentioned here. We can open an issue/PR to update that in react-native-draggable-flatlist.
Result
scroll_issue_distance_page.mp4Alternatives
What alternative solutions did you explore? (Optional)
changed the title [-]Distance - Page is not scrollable after adding multiple stops[/-][+][$250] Distance - Page is not scrollable after adding multiple stops[/+]on May 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
I couldn't find the offending PR.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
The regression step should be good.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Click on FAB > Submit expense > Distance tab
Add a start waypoint, a finish waypoint, and multiple stops
Verify page is scrollable after the content overflows
Activity
melvin-bot commentedon May 24, 2024
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.izarutskaya commentedon May 24, 2024
We think this issue might be related to the #collect project.
Krishna2323 commentedon May 24, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance - Page is not scrollable after adding multiple stops
What is the root cause of that problem?
The footer (map) for android is rendered separately from the
DraggableFlatList(not as a footer of the list) andDraggableFlatListandListFooterComponentis wrapped in aViewinstead ofScrollView.App/src/components/DraggableList/index.android.tsx
Lines 11 to 21 in 0cb2dc0
What changes do you think we should make in order to solve the problem?
We can use
NestableScrollContainer&NestableDraggableFlatList.There will be a console error when we will use
NestableDraggableFlatList.tsxand thats because of this code usingfindNodeHandle(scrollableRef.current);instead of passingscrollableRef.currentdirectly toontainerRef.current.measureLayout. It is also mentioned here. We can open an issue/PR to update that in react-native-draggable-flatlist.Result
scroll_issue_distance_page.mp4
Alternatives
What alternative solutions did you explore? (Optional)
ListFooterComponentbecause it was removed intentionally to solve [HOLD for payment 2024-05-20] CRITICAL: [P2P Distance] [$500] Enable immediate slide scrolling without tap #40211.App/src/components/DraggableList/index.android.tsx
Lines 11 to 20 in 525ad6f
To:
We can wrap both elements in
ScrollViewand disable the scroll functionality ofDraggableFlatList.Result
distance_rate_scroll_issue.mp4
allgandalf commentedon May 25, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Only for Android, Page is not scrollabe when we add multiple stops for distance request.What is the root cause of that problem?
This is bug is for android specific platform because in the Native file, we have wrapped the
DraggableListin aView:App/src/components/DraggableList/index.android.tsx
Lines 11 to 12 in 525ad6f
This was because we also display the component
ListFooterComponent:App/src/components/DraggableList/index.android.tsx
Lines 19 to 20 in 525ad6f
Due to which we are unable to scroll on
Android.What changes do you think we should make in order to solve the problem?
We need to make a function for
ListFooterComponentand pass it as a propListFooterComponenttoDraggableFlatList:Result Video
Details
Screen.Recording.2024-05-25.at.2.45.49.PM.mov
Krishna2323 commentedon May 25, 2024
Proposal updated
melvin-bot commentedon May 27, 2024
@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]Distance - Page is not scrollable after adding multiple stops[/-][+][$250] Distance - Page is not scrollable after adding multiple stops[/+]melvin-bot commentedon May 29, 2024
Job added to Upwork: https://www.upwork.com/jobs/~014d91998739178ee2
56 remaining items
melvin-bot commentedon Aug 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-09. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 2, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
stephanieelliott commentedon Aug 10, 2024
Summarizing payment on this issue:
Upwork job is here: https://www.upwork.com/jobs/~1737876297360310272
stephanieelliott commentedon Aug 10, 2024
@mollfpr can you please complete the BZ checklist for this issue?
mollfpr commentedon Aug 12, 2024
I couldn't find the offending PR.
The regression step should be good.
JmillsExpensify commentedon Aug 12, 2024
$250 approved for @mollfpr
melvin-bot commentedon Aug 13, 2024
@mollfpr, @stephanieelliott, @stitesExpensify, @Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
stephanieelliott commentedon Aug 13, 2024
Test case issue created: https://github.com/Expensify/Expensify/issues/420216
All done here, thanks!