You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [$250] Workspace's default currency isn't showing when submitting a request #42597
Please re-state the problem that we are trying to solve in this issue.
Policy currency is not being used when adding a money request and in teachers unite. Also, when workspace is made using iou report, then report currency is not being used.
What is the root cause of that problem?
Policy currency is not being used in initMoneyrequest:
Then, there's one more bug. When creating a workspace using report, the report's currency should be set as the default for the workspace but that is not happening as of now.
changed the title [-]Workspace's default currency isn't showing when submitting a request[/-][+][$250] Workspace's default currency isn't showing when submitting a request[/+]on May 30, 2024
changed the title [-][$250] Workspace's default currency isn't showing when submitting a request[/-][+][HOLD for payment 2024-07-10] [$250] Workspace's default currency isn't showing when submitting a request[/+]on Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Link to the PR: There was no PR that caused this bug. Instead, it seems to be more of a feature request than an actual bug.
Link to comment: N/A
Link to discussion: N/A
Determine if we should create a regression test for this bug: Yes
Regression Test Proposal
1. Navigate to the settings of any Workspace.
2. Modify the currency for that particular Workspace.
3. Access the Workspace chat dedicated to expense reports.
4. Click on the plus icon and proceed to submit an expense.
5. Confirm that the currency displayed in the amount step matches the updated value from Step 2.
Activity
melvin-bot commentedon May 24, 2024
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dukenv0307 commentedon May 24, 2024
I'm happy to take over this issue as C+ since I'm the reporter for this bug and have more context in this bug.
nkdengineer commentedon May 24, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The default currency in the amount step isn't the WS currency
What is the root cause of that problem?
When we init money request, we always set the default currency as the local currency of the user
App/src/libs/actions/IOU.ts
Line 320 in 8d73db3
What changes do you think we should make in order to solve the problem?
We should prioritize the policy's currency first instead of user's local currency
App/src/libs/actions/IOU.ts
Line 320 in 8d73db3
What alternative solutions did you explore? (Optional)
NA
ShridharGoel commentedon May 25, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Policy currency is not being used when adding a money request and in teachers unite. Also, when workspace is made using iou report, then report currency is not being used.
What is the root cause of that problem?
Policy currency is not being used in
initMoneyrequest:App/src/libs/actions/IOU.ts
Line 320 in 525ad6f
Also, policy currency is not being used in
TeachersUnite:App/src/libs/actions/TeachersUnite.ts
Line 98 in 525ad6f
Then, there's one more bug. When creating a workspace using report, the report's currency should be set as the default for the workspace but that is not happening as of now.
App/src/libs/actions/Policy.ts
Lines 2039 to 2040 in 525ad6f
Just the
localCurrencyCodeis being used.What changes do you think we should make in order to solve the problem?
We should use
policy?.outputCurrencyin the optimistic data when initing the money request:Update it in TeachersUnite.ts:
Pass currency via iouReport:
Now, it can be used in
buildOptimisticCustomUnits:melvin-bot commentedon May 27, 2024
@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon May 29, 2024
@puneetlath Huh... This is 4 days overdue. Who can take care of this?
[-]Workspace's default currency isn't showing when submitting a request[/-][+][$250] Workspace's default currency isn't showing when submitting a request[/+]melvin-bot commentedon May 30, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01ce85c0267e9bbc85
23 remaining items
[-][$250] Workspace's default currency isn't showing when submitting a request[/-][+][HOLD for payment 2024-07-10] [$250] Workspace's default currency isn't showing when submitting a request[/+]melvin-bot commentedon Jul 3, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
fedirjh commentedon Jul 10, 2024
BugZero Checklist:
Regression Test Proposal
puneetlath commentedon Jul 11, 2024
Payment summary:
Regression test: https://github.com/Expensify/Expensify/issues/412084
Thanks everyone!
JmillsExpensify commentedon Jul 11, 2024
$250 approved for @fedirjh