You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Context/popover menus have incorrect border radius #42716
changed the title [-]Context/popover menus have incorrect border radius[/-][+][$250] Context/popover menus have incorrect border radius[/+]on Jun 5, 2024
Damn it! We got the double post/title update thing happening again.
Contributor: @s77rt due $250 via NewDot.
Contributor+: @rojiphil paid $250 via Upwork
Unsure if we need/want a testcase for this, since it's design related. If so.. it'd be included in the monthly test that QA runs for design and edge cases. @rojiphil, can you complete the BZ checklist above plz?
@mallenexpensify Sorry for the delay here. Here is the BZ checklist
[@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
[@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
[@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist includes the provision to involve design team during styling changes which should catch such issues
[@rojiphil] Determine if we should create a regression test for this bug. : Since the changes are related to styling which is widely used, this is prone to regression. Let’s add regression test case for this.
[@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Click on Global FAB button to show the popover menu
Verify that the border radius is of size 16 (This can be verified via Inspect window in console on web versions) (#Test 1)
Navigate to a report with comments
Invoke the context menu for a comment.
Verify that the border radius is of size 16 (#Test 2)
Navigate to Settings and edit Avatar image to show the context menu
Verify that the border radius is of size 16 (#Test 3)
Navigate to Workspace. For a given workspace, invoke 3Dots Menu popover and select Delete workspace to display confirmation modal dialog.
Verify that the border radius is of size 16 (#Test 4)
Activity
melvin-bot commentedon May 28, 2024
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Krishna2323 commentedon May 28, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
The default value is always 12px in the file below.
App/src/styles/utils/generators/ModalStyleUtils.ts
Line 47 in f5d28de
What changes do you think we should make in order to solve the problem?
Update to the required number in all places where we use 12px.
What alternative solutions did you explore? (Optional)
Nodebrute commentedon May 28, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Context/popover menus have incorrect border radius
What is the root cause of that problem?
We are using 12 px in these places
App/src/styles/utils/generators/ModalStyleUtils.ts
Line 78 in f5d28de
App/src/styles/utils/generators/ModalStyleUtils.ts
Line 132 in f5d28de
App/src/styles/utils/generators/ModalStyleUtils.ts
Line 154 in f5d28de
App/src/styles/utils/generators/ModalStyleUtils.ts
Line 200 in f5d28de
What changes do you think we should make in order to solve the problem?
We should use 16 in all the above places
What alternative solutions did you explore? (Optional)
We can also use componentBorderRadiusLarge in all the above places
dragnoir commentedon May 28, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Context/popover menus have incorrect border radius
What is the root cause of that problem?
Wrong border radius on
App/src/styles/utils/generators/ModalStyleUtils.ts
Line 200 in deb4c79
What changes do you think we should make in order to solve the problem?
We need to update only this value to 16
componentBorderRadiusLargeApp/src/styles/utils/generators/ModalStyleUtils.ts
Line 200 in deb4c79
it's for
case CONST.MODAL.MODAL_TYPE.POPOVER:If we update the other value, it will effect other component and not Context/popover menus
melvin-bot commentedon May 31, 2024
@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jun 4, 2024
@JmillsExpensify Still overdue 6 days?! Let's take care of this!
JmillsExpensify commentedon Jun 5, 2024
Opening up to the community given that we have proposals.
melvin-bot commentedon Jun 5, 2024
Job added to Upwork: https://www.upwork.com/jobs/~015010f0cbb4319b2e
[-]Context/popover menus have incorrect border radius[/-][+][$250] Context/popover menus have incorrect border radius[/+]47 remaining items
mallenexpensify commentedon Jul 5, 2024
Damn it! We got the double post/title update thing happening again.
Contributor: @s77rt due $250 via NewDot.
Contributor+: @rojiphil paid $250 via Upwork
Unsure if we need/want a testcase for this, since it's design related. If so.. it'd be included in the monthly test that QA runs for design and edge cases. @rojiphil, can you complete the BZ checklist above plz?
@
melvin-bot commentedon Jul 9, 2024
@rojiphil, @s77rt, @mallenexpensify, @jasperhuangg Whoops! This issue is 2 days overdue. Let's get this updated quick!
mallenexpensify commentedon Jul 11, 2024
@rojiphil can you complete the BZ checklist above plz?
rojiphil commentedon Jul 11, 2024
@mallenexpensify Sorry for the delay here. Here is the BZ checklist
Inspectwindow in console on web versions) (#Test 1)Settingsand edit Avatar image to show the context menuWorkspace. For a given workspace, invoke 3Dots Menu popover and selectDelete workspaceto display confirmation modal dialog.mallenexpensify commentedon Jul 12, 2024
Thanks @rojiphil !
Commented that the test case is design/edge case and should likely be run monthly
https://github.com/Expensify/Expensify/issues/412266
JmillsExpensify commentedon Jul 16, 2024
$250 approved for @s77rt