Skip to content

[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Context/popover menus have incorrect border radius #42716

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.76-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dannymcclain
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1716913234239859

Action Performed:

  1. Go to NewDot
  2. Open context menu, Edit comment Global create (any context menu)

Expected Result:

Context/popover menus should use one of our predefined border radius variables. Not an engineer, but I would think componentBorderRadiusLarge (

componentBorderRadiusLarge: 16,
), which is 16px.

Actual Result:

The border radius of context menus is 12px.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
image (3)
Screenshot 2024-05-28 133907
Screenshot 2024-05-28 133946

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015010f0cbb4319b2e
  • Upwork Job ID: 1798225869486452736
  • Last Price Increase: 2024-06-05
  • Automatic offers:
    • rojiphil | Reviewer | 102612211
    • s77rt | Contributor | 102712893
Issue OwnerCurrent Issue Owner: @rojiphil

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 28, 2024
  2. melvin-bot commented on May 28, 2024

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. Krishna2323 commented on May 28, 2024

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    What is the root cause of that problem?

    The default value is always 12px in the file below.

    const createModalStyleUtils: StyleUtilGenerator<GetModalStylesStyleUtil> = ({theme, styles}) => ({

    What changes do you think we should make in order to solve the problem?

    Update to the required number in all places where we use 12px.

    What alternative solutions did you explore? (Optional)

  4. Nodebrute commented on May 28, 2024

    @Nodebrute
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Context/popover menus have incorrect border radius

    What is the root cause of that problem?

    We are using 12 px in these places


    borderRadius: isSmallScreenWidth ? 0 : 12,


    What changes do you think we should make in order to solve the problem?

    We should use 16 in all the above places

    What alternative solutions did you explore? (Optional)

    We can also use componentBorderRadiusLarge in all the above places

  5. dragnoir commented on May 28, 2024

    @dragnoir
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Context/popover menus have incorrect border radius

    What is the root cause of that problem?

    Wrong border radius on

    What changes do you think we should make in order to solve the problem?

    We need to update only this value to 16 componentBorderRadiusLarge

    it's for case CONST.MODAL.MODAL_TYPE.POPOVER:

    If we update the other value, it will effect other component and not Context/popover menus

  6. melvin-bot commented on May 31, 2024

    @melvin-bot

    @JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    @JmillsExpensify Still overdue 6 days?! Let's take care of this!

  8. JmillsExpensify commented on Jun 5, 2024

    @JmillsExpensify
    Contributor

    Opening up to the community given that we have proposals.

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 5, 2024
  10. melvin-bot commented on Jun 5, 2024

    @melvin-bot
  11. changed the title [-]Context/popover menus have incorrect border radius[/-] [+][$250] Context/popover menus have incorrect border radius[/+] on Jun 5, 2024
  12. 47 remaining items

  13. mallenexpensify commented on Jul 5, 2024

    @mallenexpensify
    Contributor

    Damn it! We got the double post/title update thing happening again.

    Contributor: @s77rt due $250 via NewDot.
    Contributor+: @rojiphil paid $250 via Upwork

    Unsure if we need/want a testcase for this, since it's design related. If so.. it'd be included in the monthly test that QA runs for design and edge cases. @rojiphil, can you complete the BZ checklist above plz?

    @

  14. melvin-bot commented on Jul 9, 2024

    @melvin-bot

    @rojiphil, @s77rt, @mallenexpensify, @jasperhuangg Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. mallenexpensify commented on Jul 11, 2024

    @mallenexpensify
    Contributor

    @rojiphil can you complete the BZ checklist above plz?

  16. rojiphil commented on Jul 11, 2024

    @rojiphil
    Contributor

    @mallenexpensify Sorry for the delay here. Here is the BZ checklist

    • [@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
    • [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
    • [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist includes the provision to involve design team during styling changes which should catch such issues
    • [@rojiphil] Determine if we should create a regression test for this bug. : Since the changes are related to styling which is widely used, this is prone to regression. Let’s add regression test case for this.
    • [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    1. Click on Global FAB button to show the popover menu
    2. Verify that the border radius is of size 16 (This can be verified via Inspect window in console on web versions) (#Test 1)
    3. Navigate to a report with comments
    4. Invoke the context menu for a comment.
    5. Verify that the border radius is of size 16 (#Test 2)
    6. Navigate to Settings and edit Avatar image to show the context menu
    7. Verify that the border radius is of size 16 (#Test 3)
    8. Navigate to Workspace. For a given workspace, invoke 3Dots Menu popover and select Delete workspace to display confirmation modal dialog.
    9. Verify that the border radius is of size 16 (#Test 4)
  17. mallenexpensify commented on Jul 12, 2024

    @mallenexpensify
    Contributor

    Thanks @rojiphil !

    Commented that the test case is design/edge case and should likely be run monthly
    https://github.com/Expensify/Expensify/issues/412266

  18. JmillsExpensify commented on Jul 16, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @s77rt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions