You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [HOLD for payment 2024-08-01] Group name - RBR doesn't disappear from LHN after removing error message #42765
Version Number: 1.4.77-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Rename the group to something invalid for example "adoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoaỏ"
Go online
Follow the RBR and remove the error message
Expected Result:
RBR on LHN gets removed from LHN as well
Actual Result:
RBR stays on LHN even after removing error message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@danieldoglas FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
@rojiphil , it looks like you just checked the box there. We also want reasoning if we don't create a test case. We want to err on the side of creating more test cases because the QA will know if it's needed. They also have a separate monthly test for edge cases.
Activity
melvin-bot commentedon May 29, 2024
Triggered auto assignment to @danieldoglas (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon May 29, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon May 29, 2024
@danieldoglas FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon May 29, 2024
We think that this bug might be related to #vip-vsp
Nodebrute commentedon May 29, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
RBR doesn't disappear from LHN after removing error message
What is the root cause of that problem?
Here we call
clearPolicyRoomNameErrorsApp/src/pages/settings/Report/ReportSettingsPage.tsx
Line 76 in 53f9e57
and in
clearPolicyRoomNameErrorswe only clear errorFields but not errorsApp/src/libs/actions/Report.ts
Lines 2220 to 2229 in c244fa1
and here when we fail we set
errorsto common.genericErrorMessageApp/src/libs/actions/Report.ts
Lines 665 to 667 in 169a3aa
So the RCA is when "x" is pressed we clear errorFields but not errors
What changes do you think we should make in order to solve the problem?
Solution 1
Instead of setting errors here set "errorFields" error to invalid Name
App/src/libs/actions/Report.ts
Lines 665 to 667 in 169a3aa
Note:we can keep errors here too.
What alternative solutions did you explore? (Optional)
In
clearPolicyRoomNameErrorsalso clear errors or create a new function to use hereApp/src/libs/actions/Report.ts
Lines 2220 to 2229 in c244fa1
puneetlath commentedon May 29, 2024
Doesn't seem blocker-worthy to me. Let's treat as a regular bug.
67 remaining items
melvin-bot commentedon Aug 7, 2024
Current assignee @rojiphil is eligible for the External assigner, not assigning anyone new.
mallenexpensify commentedon Aug 7, 2024
@rojiphil @Nodebrute , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01f34a445311dae423
Nodebrute commentedon Aug 8, 2024
@mallenexpensify I haven’t received the Upwork offer yet. Can you send the contract manually when you get a chance?
mallenexpensify commentedon Aug 8, 2024
Musta forgot to invite ¯_(ツ)_/¯, plz accept meow 🐱
https://www.upwork.com/jobs/~01f34a445311dae423
Nodebrute commentedon Aug 9, 2024
@mallenexpensify thank you, accepted.
rojiphil commentedon Aug 10, 2024
@mallenexpensify Accepted offer. Thanks.
danieldoglas commentedon Aug 12, 2024
payment in progress
mallenexpensify commentedon Aug 12, 2024
Contributor: @Nodebrute paid $250 via Upwork
Contributor+: @rojiphil paid $250 via NewDot
@rojiphil do we want a regression test for this? If not, why not? Thx
rojiphil commentedon Aug 13, 2024
@mallenexpensify As mentioned in BZ checklist here, I think we can skip the regression test as this is an edge case.
mallenexpensify commentedon Aug 13, 2024
@rojiphil , it looks like you just checked the box there. We also want reasoning if we don't create a test case. We want to err on the side of creating more test cases because the QA will know if it's needed. They also have a separate monthly test for edge cases.
I created a test case using the steps in the PR
rojiphil commentedon Aug 14, 2024
@mallenexpensify Ok. Got it and noted too. Thanks.