Skip to content

[$250] [HOLD for payment 2024-08-01] Group name - RBR doesn't disappear from LHN after removing error message #42765

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.77-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41826

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a group chat
  3. Go offline
  4. Rename the group to something invalid for example "adoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoaỏ"
  5. Go online
  6. Follow the RBR and remove the error message

Expected Result:

RBR on LHN gets removed from LHN as well

Actual Result:

RBR stays on LHN even after removing error message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6495078_1716985565573.bandicam_2024-05-29_15-20-11-422.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f34a445311dae423
  • Upwork Job ID: 1821299949503498320
  • Last Price Increase: 2024-08-07
Issue OwnerCurrent Issue Owner: @rojiphil

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on May 29, 2024
  2. melvin-bot commented on May 29, 2024

    @melvin-bot

    Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on May 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on May 29, 2024

    @lanitochka17
    Author

    @danieldoglas FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on May 29, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  6. Nodebrute commented on May 29, 2024

    @Nodebrute
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    RBR doesn't disappear from LHN after removing error message

    What is the root cause of that problem?

    Here we call clearPolicyRoomNameErrors

    onClose={() => ReportActions.clearPolicyRoomNameErrors(reportID)}

    and in clearPolicyRoomNameErrors we only clear errorFields but not errors

    App/src/libs/actions/Report.ts

    Lines 2220 to 2229 in c244fa1

    function clearPolicyRoomNameErrors(reportID: string) {
    Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {
    errorFields: {
    reportName: null,
    },
    pendingFields: {
    reportName: null,
    },
    });
    }

    and here when we fail we set errors to common.genericErrorMessage
    errors: {
    reportName: Localize.translateLocal('common.genericErrorMessage'),
    },

    So the RCA is when "x" is pressed we clear errorFields but not errors

    What changes do you think we should make in order to solve the problem?

    Solution 1
    Instead of setting errors here set "errorFields" error to invalid Name

    errors: {
    reportName: Localize.translateLocal('common.genericErrorMessage'),
    },

    Note:we can keep errors here too.

    What alternative solutions did you explore? (Optional)

    In clearPolicyRoomNameErrors also clear errors or create a new function to use here

    App/src/libs/actions/Report.ts

    Lines 2220 to 2229 in c244fa1

    function clearPolicyRoomNameErrors(reportID: string) {
    Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {
    errorFields: {
    reportName: null,
    },
    pendingFields: {
    reportName: null,
    },
    });
    }

            errors: {
                        reportName: 'null',
                    },
    
  7. puneetlath commented on May 29, 2024

    @puneetlath
    Contributor

    Doesn't seem blocker-worthy to me. Let's treat as a regular bug.

  8. 67 remaining items

  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 7, 2024
  10. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    Current assignee @rojiphil is eligible for the External assigner, not assigning anyone new.

  11. mallenexpensify commented on Aug 7, 2024

    @mallenexpensify
    Contributor

    @rojiphil @Nodebrute , can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~01f34a445311dae423

  12. Nodebrute commented on Aug 8, 2024

    @Nodebrute
    Contributor

    @mallenexpensify I haven’t received the Upwork offer yet. Can you send the contract manually when you get a chance?

  13. mallenexpensify commented on Aug 8, 2024

    @mallenexpensify
    Contributor

    Musta forgot to invite ¯_(ツ)_/¯, plz accept meow 🐱
    https://www.upwork.com/jobs/~01f34a445311dae423

  14. Nodebrute commented on Aug 9, 2024

    @Nodebrute
    Contributor

    @mallenexpensify thank you, accepted.

  15. rojiphil commented on Aug 10, 2024

    @rojiphil
    Contributor

    @mallenexpensify Accepted offer. Thanks.

  16. danieldoglas commented on Aug 12, 2024

    @danieldoglas
    Contributor

    payment in progress

  17. mallenexpensify commented on Aug 12, 2024

    @mallenexpensify
    Contributor

    Contributor: @Nodebrute paid $250 via Upwork
    Contributor+: @rojiphil paid $250 via NewDot

    @rojiphil do we want a regression test for this? If not, why not? Thx

  18. rojiphil commented on Aug 13, 2024

    @rojiphil
    Contributor

    Contributor: @Nodebrute paid $250 via Upwork Contributor+: @rojiphil paid $250 via NewDot

    @rojiphil do we want a regression test for this? If not, why not? Thx

    @mallenexpensify As mentioned in BZ checklist here, I think we can skip the regression test as this is an edge case.

  19. mallenexpensify commented on Aug 13, 2024

    @mallenexpensify
    Contributor

    BZ checklist #42765 (comment),

    @rojiphil , it looks like you just checked the box there. We also want reasoning if we don't create a test case. We want to err on the side of creating more test cases because the QA will know if it's needed. They also have a separate monthly test for edge cases.

    I created a test case using the steps in the PR

  20. rojiphil commented on Aug 14, 2024

    @rojiphil
    Contributor

    We want to err on the side of creating more test cases because the QA will know if it's needed. They also have a separate monthly test for edge cases.

    @mallenexpensify Ok. Got it and noted too. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions