Pusher is subscribing to a private-user-accountID-undefined channel

[marcaaron]

Problem:

Solution:

Not sure, but probably can happen when currentUserAccountID is undefined here when the Homepage component mounts.

Not too sure what urgency to place this at. It could be indicative of a larger problem or totally benign. We should at the very least not subscribe to this channel ever.

[sketchydroide]

will take a look into this

[sketchydroide]

I would say that maybe it's from when the user was still logged out. If I understand correctly HomePage is the main app itself and should already exist (and mount) even when the user is not logged in, correct?

[marcaaron]

I think the issue is that HomePage is very briefly accessed and mounts before we are redirected to the SignIn page when the user is not logged in? The Expensify component owns the routing logic for whether we go to the HomePage or the SignIn page. Some options might be to only subscribe when we have a valid authToken, but we must make sure the HomePage will re-mount in that case after sign in.

[marcaaron]

Another way of looking at this issue is that we should maybe not be seeing the HomePage at all unless we have an authToken set.

[sketchydroide]

should maybe not be seeing the HomePage at all unless we have an authToken set.

I agree with this, and I think would be the best approach. once we do we can reroute to the HomePage

[sketchydroide]

I also noticed that logging out does not cleat the authtoken out of the Ion state, this does not seem right

[sketchydroide]

will wait for this one to be merged in, and then we can separate the routes, and we will always have a cleared authToken when redirecting to SignIn, and no longer call the pusher with a undefined authToken

[marcaaron]

Sorry, I think we are now fixing this in #426

[marcaaron]

But maybe not 🤔 let's see

[mallenexpensify]

Per a chat with @marcaaron and @sketchydroide , this appears to be fixed. If someone finds it's not, please comment and reopen