You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Login - Entering incorrect and short password will return wrong error message #4292
Throw ExpException - a06cf65ac10bfccdfafc24d069935cfb ~~ message: '402 Missing partnerUserSecret' exceptionMessage: 'Auth Authenticate returned an error'
That leads me to believe that, even though the password is being entered, it is not being passed to the backend for authentication. However, if that were the case, nobody would be able to enter a password and log in.
So...I'm really not sure what is causing this at the moment.
This is also reproducible when entering 1 or 2 characters in the password field. As a side note, I'm also able to log with with my account (isagoicotest@gmail.com) when entering the correct password.
If I enter an incorrect password that is 3 characters or less I get the following message:
If I enter an incorrect password that is 4 characters or more I get the correct error message:
I would expect that I should not be getting that incorrect first message at all, because we have a minimum for the password length set in auth as 1 character:
Activity
MelvinBot commentedon Jul 29, 2021
Triggered auto assignment to @joelbettner (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.aman-atg commentedon Jul 29, 2021
The API's returning Status
402for short passwords instead of401or403(preferred)This needs to be fixed on the backend.
joelbettner commentedon Jul 29, 2021
@isagoico just to confirm, this happened when you were attempting to log in with gI3utest@gmail.com, correct?
(I can't tell if the second letter is a lower-case "L" or an upper-case "I")
isagoico commentedon Jul 29, 2021
Mm let me confirm with the tester. I was also able to reproduce this with my account isagoicotest@gmail.com
Edit: is a lowercase L
joelbettner commentedon Jul 29, 2021
I think I found the logs for this:
https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%226761fa61de42601e-GRU%22)+AND+timestamp:[2021-07-28T22:44:54.625Z+TO+2021-07-29T00:44:54.625Z]&index=logs_expensify-011753
I'm confused, though. It is showing that we threw a
402because there was nopartnerUserSecretincluded in the request (and that means we threw from this check: https://github.com/Expensify/Auth/blob/master/auth/command/Authenticate.cpp#L84)That leads me to believe that, even though the password is being entered, it is not being passed to the backend for authentication. However, if that were the case, nobody would be able to enter a password and log in.
So...I'm really not sure what is causing this at the moment.
isagoico commentedon Jul 29, 2021
This is also reproducible when entering 1 or 2 characters in the password field. As a side note, I'm also able to log with with my account (isagoicotest@gmail.com) when entering the correct password.
joelbettner commentedon Jul 29, 2021
So, there is a threshold over which the correct error message is shown.
I'll keep digging, but something funky is happening here...
joelbettner commentedon Jul 29, 2021
If I enter an incorrect password that is 3 characters or less I get the following message:

If I enter an incorrect password that is 4 characters or more I get the correct error message:

I would expect that I should not be getting that incorrect first message at all, because we have a minimum for the password length set in auth as 1 character:
joelbettner commentedon Jul 29, 2021
Ok...I've found out what is going on...
The WAF is preventing passwords that are less than 4 characters from being passed from a client to the API, and in that case simply passes an empty password:
https://github.com/Expensify/Web-Expensify/blame/master/_inputrules.php#L19
I've got a fix coming...
isagoico commentedon Aug 4, 2021
@joelbettner issue is fixed! I think we are good to close this one 🎉
MelvinBot commentedon Aug 6, 2021
@joelbettner Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
MelvinBot commentedon Aug 10, 2021
@joelbettner Still overdue 6 days?! Let's take care of this!
MelvinBot commentedon Aug 12, 2021
@joelbettner 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!