You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Accounting-Renaming Customers/Projects tag doesn't work and has weird behavior while offline #42957
Version Number: 1.4.78-2 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Pre-requisite:
Account must have a workspace connected with a QBO
Navigate to staging.new.expensify.com
Go to settings > Workspace and select the workspace you have QBO setup with
Go to tags
Go to Customers/Projects tag
Open any tag and rename it
Go offline
Go to Customers/Projects tag again and rename a tag
Go to Classes tag
Expected Result:
On step 5 after renaming the tag the renamed tag must appear in the tag list, and on step 8 the renamed tag on step 7 should not appear on Classes tag
Actual Result:
On step 5 after renaming the tag it is not being reflected on the tag list. And on step 8 while the user is offline and tries to rename the tag in Customers/Projects the renamed tag is visible on Classes tag list.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][HOLD for payment 2024-06-18] [$250] Accounting-Renaming Customers/Projects tag doesn't work and has weird behavior while offline[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Accounting-Renaming Customers/Projects tag doesn't work and has weird behavior while offline[/+]on Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
[@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hayata-suenaga] Determine if we should create a regression test for this bug.
[@hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
This is a new feature. We just didn't account for multi tag before.
[@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
N/A
[@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
No need for discussion
[@hayata-suenaga] Determine if we should create a regression test for this bug.
N/A
[@hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Jun 1, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jun 1, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jun 1, 2024
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.31 remaining items
[-][HOLD for payment 2024-06-18] [$250] Accounting-Renaming Customers/Projects tag doesn't work and has weird behavior while offline[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Accounting-Renaming Customers/Projects tag doesn't work and has weird behavior while offline[/+]melvin-bot commentedon Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
melvin-bot commentedon Jun 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
hayata-suenaga commentedon Jun 14, 2024
This is a new feature. We just didn't account for multi tag before.
N/A
No need for discussion
N/A
N/A
melvin-bot commentedon Jun 20, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
sakluger commentedon Jun 20, 2024
@s77rt do you need to be paid here for the PR review, or are you being paid somewhere else?
s77rt commentedon Jun 20, 2024
@sakluger I'm due payment here
sakluger commentedon Jun 21, 2024
Summarizing payment on this issue:
Contributor+: @s77rt $250, please request via Newdot
JmillsExpensify commentedon Jun 22, 2024
$250 approved for @s77rt