Skip to content

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code #43004

Closed

Description

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717433997016439

Action Performed:

Break down in numbered steps

  1. Have a report with invalid currency code
  2. You can locally merge in incorrect data to an expense report
  3. Open the report

Expected Result:

Describe what you think should've happened

We will handle this issue gracefully

Actual Result:

Describe what actually happened

The app crashes
image

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01365ad3a139cd53cd
  • Upwork Job ID: 1797682414465474560
  • Last Price Increase: 2024-06-20
  • Automatic offers:
    • ahmedGaber93 | Reviewer | 102595642
    • b4s36t4 | Contributor | 102595648
Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 3, 2024
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 3, 2024
  3. melvin-bot commented on Jun 3, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

  4. melvin-bot commented on Jun 3, 2024

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. mountiny commented on Jun 3, 2024

    @mountiny
    ContributorAuthor

    Looking for proposals

  6. changed the title [-][CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/-] [+][$250] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/+] on Jun 3, 2024
  7. melvin-bot commented on Jun 3, 2024

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 3, 2024
  9. 61 remaining items

  10. changed the title [-][HOLD for payment 2024-06-18] [$250] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/-] [+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/+] on Jun 13, 2024
  11. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-20. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
    • [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ahmedGaber93] Determine if we should create a regression test for this bug.
    • [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. CortneyOfstad commented on Jun 19, 2024

    @CortneyOfstad
    Contributor

    @ahmedGaber93 can you complete the checklist before EOD today so we're not delayed with payment tomorrow? Thanks!

  14. b4s36t4 commented on Jun 19, 2024

    @b4s36t4
    Contributor

    @CortneyOfstad doesn't the payment due date is yesterday which is the first that the resolution is deployed on?

  15. b4s36t4 commented on Jun 19, 2024

    @b4s36t4
    Contributor

    Also about the amount, shouldn't this come under critical issues which are eligible for 500$? I'm sorry if it's not!

  16. ahmedGaber93 commented on Jun 19, 2024

    @ahmedGaber93
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR: N/A. the main issue is in backend.
    • [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@ahmedGaber93] Determine if we should create a regression test for this bug. Yes
    • [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Open any report
    2. Click (+) icon > Submit expense then submit an expense
    3. Open the expense report that you created it in step 2 and Verify the app is not crashed

    extra steps for Web and Desktop only

    1. Open your browser console and type Onyx.merge("report_<your_report_id>",{currency: null}) then press Enter. You can get your_report_id from browser link.
    2. Verify the app is not crashed

    Do we agree 👍 or 👎

  17. CortneyOfstad commented on Jun 20, 2024

    @CortneyOfstad
    Contributor

    Payment Summary

    @ahmedGaber93 — paid $500 (Critical) via Upwork
    @b4s36t4 — paid $500 (Critical) via Upwork

    Regression

    https://github.com/Expensify/Expensify/issues/406381

  18. changed the title [-][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/-] [+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/+] on Jun 20, 2024
  19. melvin-bot commented on Jun 20, 2024

    @melvin-bot

    Upwork job price has been updated to $500

  20. mallenexpensify commented on Jul 9, 2024

    @mallenexpensify
    Contributor

    Heads up, in case anyone uses this as a reference for prices increases for 'critical' type issues. From #expensify-open-source

    There have been questions about what constitutes a job being auto-increased to $500. These jobs are only the ones that have the High Priority label added to them (ie. issue with HIGH or CRITICAL in the title or project status/priority are not auto-increased to $500).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions