You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code #43004
changed the title [-][CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/-][+][$250] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/+]on Jun 3, 2024
changed the title [-][HOLD for payment 2024-06-18] [$250] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/+]on Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
[@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ahmedGaber93] Determine if we should create a regression test for this bug.
[@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR: N/A. the main issue is in backend.
[@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@ahmedGaber93] Determine if we should create a regression test for this bug. Yes
[@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Open any report
Click (+) icon > Submit expense then submit an expense
Open the expense report that you created it in step 2 and Verify the app is not crashed
extra steps for Web and Desktop only
Open your browser console and type Onyx.merge("report_<your_report_id>",{currency: null}) then press Enter. You can get your_report_id from browser link.
changed the title [-][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/+]on Jun 20, 2024
Heads up, in case anyone uses this as a reference for prices increases for 'critical' type issues. From #expensify-open-source
There have been questions about what constitutes a job being auto-increased to $500. These jobs are only the ones that have the High Priority label added to them (ie. issue with HIGH or CRITICAL in the title or project status/priority are not auto-increased to $500).
Activity
melvin-bot commentedon Jun 3, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (
External)melvin-bot commentedon Jun 3, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mountiny commentedon Jun 3, 2024
Looking for proposals
[-][CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/-][+][$250] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/+]melvin-bot commentedon Jun 3, 2024
61 remaining items
[-][HOLD for payment 2024-06-18] [$250] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/+]melvin-bot commentedon Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
CortneyOfstad commentedon Jun 19, 2024
@ahmedGaber93 can you complete the checklist before EOD today so we're not delayed with payment tomorrow? Thanks!
b4s36t4 commentedon Jun 19, 2024
@CortneyOfstad doesn't the payment due date is yesterday which is the first that the resolution is deployed on?
b4s36t4 commentedon Jun 19, 2024
Also about the amount, shouldn't this come under critical issues which are eligible for 500$? I'm sorry if it's not!
ahmedGaber93 commentedon Jun 19, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test Proposal
extra steps for Web and Desktop only
Do we agree 👍 or 👎
CortneyOfstad commentedon Jun 20, 2024
Payment Summary
@ahmedGaber93 — paid $500 (Critical) via Upwork
@b4s36t4 — paid $500 (Critical) via Upwork
Regression
https://github.com/Expensify/Expensify/issues/406381
[-][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code[/+]melvin-bot commentedon Jun 20, 2024
Upwork job price has been updated to $500
mallenexpensify commentedon Jul 9, 2024
Heads up, in case anyone uses this as a reference for prices increases for 'critical' type issues. From #expensify-open-source