Skip to content

[HOLD for payment 2024-07-10] [$500] [One expense reports] The expense details are shown at the top, and then a report preview in the comments #43034

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.78-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717176771231389

Action Performed:

  1. Have a HT account as admin
  2. Create a policy with some violation (category required) and leave the submission frequency as instantly
  3. Invite a member A
  4. As a member A create a report with only one expense
  5. Log in as HT admin
  6. Open the report

Expected Result:

Expense report preview should not appear in the expense details page

Actual Result:

Expense details showing at the top, and then a report preview of the same in the comments

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

CleanShot 2024-05-31 at 11 31 43@2x (1)

Recording.159.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016087f922551bb586
  • Upwork Job ID: 1798510897494771226
  • Last Price Increase: 2024-06-18
  • Automatic offers:
    • wildan-m | Contributor | 102862232
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 4, 2024
  2. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. trjExpensify commented on Jun 6, 2024

    @trjExpensify
    Contributor

    I'm struggling to reproduce this myself, but given that Jason runs into it a lot and QA have reproduced. I'm going to move it forward.

    Sounds like a perfect storm of HT account and slow internet connection are in play.

  4. changed the title [-]One expense report is shows the expense details at the top, and then a report preview of the same in the comments[/-] [+][One expense reports] The expense details are shown at the top, and then a report preview in the comments[/+] on Jun 6, 2024
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 6, 2024
  6. melvin-bot commented on Jun 6, 2024

    @melvin-bot
  7. changed the title [-][One expense reports] The expense details are shown at the top, and then a report preview in the comments[/-] [+][$250] [One expense reports] The expense details are shown at the top, and then a report preview in the comments[/+] on Jun 6, 2024
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 6, 2024
  9. melvin-bot commented on Jun 6, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

  10. moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collecton Jun 6, 2024
  11. marcus-cook commented on Jun 6, 2024

    @marcus-cook

    I do have a feeling this has something to do with the JS. I would need access to recreate the issue and inspect elements on said page to really dial in exactly what is going on. Inspecting your main page, This is the only possible thing I could think of.

  12. 38 remaining items

  13. changed the title [-][$500] [One expense reports] The expense details are shown at the top, and then a report preview in the comments[/-] [+][HOLD for payment 2024-07-10] [$500] [One expense reports] The expense details are shown at the top, and then a report preview in the comments[/+] on Jul 3, 2024
  14. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-10. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
    • [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Pujan92] Determine if we should create a regression test for this bug.
    • [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. trjExpensify commented on Jul 10, 2024

    @trjExpensify
    Contributor

    👋 checklist time!

  18. Pujan92 commented on Jul 10, 2024

    @Pujan92
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Steps

    1. Create a collect policy
    2. Invite a member A
    3. Login as a member A and submit an expense within that policy
    4. Log in as admin
    5. Open that report
    6. Verify that the IOU preview does not appear on that one expense report
  19. JmillsExpensify commented on Jul 11, 2024

    @JmillsExpensify
    Contributor

    Ready to pay this once I get a payment summary.

  20. trjExpensify commented on Jul 11, 2024

    @trjExpensify
    Contributor

    Thanks, Pujan! Payment summary as follows:

    • $500 to @Pujan92 for the C+ review (go ahead and request)
    • $500 to @wildan-m for the fix (paid!)

    Closing!

  21. moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collecton Jul 11, 2024
  22. JmillsExpensify commented on Jul 11, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @Pujan92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions