You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [$500] [One expense reports] The expense details are shown at the top, and then a report preview in the comments #43034
changed the title [-]One expense report is shows the expense details at the top, and then a report preview of the same in the comments[/-][+][One expense reports] The expense details are shown at the top, and then a report preview in the comments[/+]on Jun 6, 2024
changed the title [-][One expense reports] The expense details are shown at the top, and then a report preview in the comments[/-][+][$250] [One expense reports] The expense details are shown at the top, and then a report preview in the comments[/+]on Jun 6, 2024
I do have a feeling this has something to do with the JS. I would need access to recreate the issue and inspect elements on said page to really dial in exactly what is going on. Inspecting your main page, This is the only possible thing I could think of.
changed the title [-][$500] [One expense reports] The expense details are shown at the top, and then a report preview in the comments[/-][+][HOLD for payment 2024-07-10] [$500] [One expense reports] The expense details are shown at the top, and then a report preview in the comments[/+]on Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
[@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Pujan92] Determine if we should create a regression test for this bug.
[@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@Pujan92] Determine if we should create a regression test for this bug. Yes
[@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Create a collect policy
Invite a member A
Login as a member A and submit an expense within that policy
Log in as admin
Open that report
Verify that the IOU preview does not appear on that one expense report
Activity
melvin-bot commentedon Jun 4, 2024
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.trjExpensify commentedon Jun 6, 2024
I'm struggling to reproduce this myself, but given that Jason runs into it a lot and QA have reproduced. I'm going to move it forward.
Sounds like a perfect storm of HT account and slow internet connection are in play.
[-]One expense report is shows the expense details at the top, and then a report preview of the same in the comments[/-][+][One expense reports] The expense details are shown at the top, and then a report preview in the comments[/+]melvin-bot commentedon Jun 6, 2024
Job added to Upwork: https://www.upwork.com/jobs/~016087f922551bb586
[-][One expense reports] The expense details are shown at the top, and then a report preview in the comments[/-][+][$250] [One expense reports] The expense details are shown at the top, and then a report preview in the comments[/+]melvin-bot commentedon Jun 6, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (
External)marcus-cook commentedon Jun 6, 2024
I do have a feeling this has something to do with the JS. I would need access to recreate the issue and inspect elements on said page to really dial in exactly what is going on. Inspecting your main page, This is the only possible thing I could think of.
38 remaining items
[-][$500] [One expense reports] The expense details are shown at the top, and then a report preview in the comments[/-][+][HOLD for payment 2024-07-10] [$500] [One expense reports] The expense details are shown at the top, and then a report preview in the comments[/+]melvin-bot commentedon Jul 3, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
trjExpensify commentedon Jul 10, 2024
👋 checklist time!
Pujan92 commentedon Jul 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test Steps
JmillsExpensify commentedon Jul 11, 2024
Ready to pay this once I get a payment summary.
trjExpensify commentedon Jul 11, 2024
Thanks, Pujan! Payment summary as follows:
Closing!
JmillsExpensify commentedon Jul 11, 2024
$500 approved for @Pujan92