You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-28] [$250] Web - Categorizing - Folder icon in empty state screen is not centered #43064
Version Number: 1.4-79-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
[@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jjcoffee] Determine if we should create a regression test for this bug.
[@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-06-24] [$250] Web - Categorizing - Folder icon in empty state screen is not centered[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Web - Categorizing - Folder icon in empty state screen is not centered[/+]on Jun 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
[@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jjcoffee] Determine if we should create a regression test for this bug.
[@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Web - Categorizing - Folder icon in empty state screen is not centered[/-][+][HOLD for payment 2024-06-28] [$250] Web - Categorizing - Folder icon in empty state screen is not centered[/+]on Jun 24, 2024
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Jun 4, 2024
Triggered auto assignment to @hayata-suenaga (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 4, 2024
@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
hayata-suenaga commentedon Jun 5, 2024
missed this. working on it right now
hayata-suenaga commentedon Jun 5, 2024
I don't think we have to block deploy for this. removing the deploy blocker label
47 remaining items
melvin-bot commentedon Jun 17, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-06-24] [$250] Web - Categorizing - Folder icon in empty state screen is not centered[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Web - Categorizing - Folder icon in empty state screen is not centered[/+]melvin-bot commentedon Jun 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 21, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Web - Categorizing - Folder icon in empty state screen is not centered[/-][+][HOLD for payment 2024-06-28] [$250] Web - Categorizing - Folder icon in empty state screen is not centered[/+]abekkala commentedon Jun 25, 2024
PAYMENT SUMMARY FOR JUN 28
please complete checklist
jjcoffee commentedon Jun 26, 2024
Regression Test Proposal
Categorize itfrom the actionable whisperDo we agree 👍 or 👎
abekkala commentedon Jun 28, 2024
@tienifr @jjcoffee - payments sent and contracts ended - thank you! 🎉