You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Track Expense - Hmm..not here page on selecting category with no existing workspace #43073
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Reproduced it locally. I think this PR is really suspicious given the timing and the area of the codebase. Reverting that PR locally doesn't fix it though, so that doesn't seem like its the root cause.
Not 100% sure if this is backend or frontend, seems like frontend because I can't find any wonky network requests or logs that are giving me any leads. Though maybe it has to do with bad handling of onyx updates in the backend. Not sure.
I think this might be backend related, since I went back about a week and a half in App history and its still an issue. Stuck on how to debug this. Can't seem to figure out where it is going wrong.
In the meantime I think we can demote as this is no longer reproducing for me on staging or locally. Should probably figure out what the exact cause was, but seems to be fixed.
@mananjadhav@CortneyOfstad@blimpich this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Apologies for the delay here. I've been trying to reproduce this on staging and the latest main. But I haven't been able to reproduce the bug. Earlier when it was reported I was able to, but not recently. @kbecciv@CortneyOfstad@blimpich Are you able to consistently reproduce this?
Here's the video from Web
web-not-found-on-categorize.mov
iPhone Safari
mweb-safari-not-found-on-categorize.mp4
and I've tried this on Native, Mobile Web, Mac Safari. Tried it with 3 different new accounts.
@CortneyOfstad@blimpich I do see Not found when we click on the Workspace name. I am assuming that is expected as the workspace is not created yet. May be that shouldn't be clickable? But definitely a separate issue.
Activity
melvin-bot commentedon Jun 4, 2024
Triggered auto assignment to @blimpich (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
kbecciv commentedon Jun 4, 2024
We think that this bug might be related to #vip-vsb
blimpich commentedon Jun 4, 2024
Looking into this.
blimpich commentedon Jun 4, 2024
Reproduced it locally. I think this PR is really suspicious given the timing and the area of the codebase. Reverting that PR locally doesn't fix it though, so that doesn't seem like its the root cause.
Not 100% sure if this is backend or frontend, seems like frontend because I can't find any wonky network requests or logs that are giving me any leads. Though maybe it has to do with bad handling of onyx updates in the backend. Not sure.
Reached out in #expensify-opensource (link)
blimpich commentedon Jun 4, 2024
I think this might be backend related, since I went back about a week and a half in App history and its still an issue. Stuck on how to debug this. Can't seem to figure out where it is going wrong.
blimpich commentedon Jun 4, 2024
Huh, well when I actually try to reproduce this on staging it doesn't reproduce, so maybe someone put out a fix that is related to this.
blimpich commentedon Jun 4, 2024
Weird, yup, pulled everything and now its working locally on main.
blimpich commentedon Jun 4, 2024
Asked QA to retest
In the meantime I think we can demote as this is no longer reproducing for me on staging or locally. Should probably figure out what the exact cause was, but seems to be fixed.
24 remaining items
mananjadhav commentedon Jun 11, 2024
Reviewing proposals.
mananjadhav commentedon Jun 13, 2024
I am testing the proposals to see if it works and doesn't break anything. I'll have an update before EOD today.
CortneyOfstad commentedon Jun 17, 2024
@mananjadhav any update on the testing?
melvin-bot commentedon Jun 17, 2024
@mananjadhav, @CortneyOfstad, @blimpich Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jun 18, 2024
@mananjadhav @CortneyOfstad @blimpich this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
mananjadhav commentedon Jun 19, 2024
I was out sick past 3-4 days. I'll post an update today/tomorrow.
CortneyOfstad commentedon Jun 19, 2024
Thanks @mananjadhav and hope you're feeling better!
mananjadhav commentedon Jun 23, 2024
Apologies for the delay here. I've been trying to reproduce this on staging and the latest main. But I haven't been able to reproduce the bug. Earlier when it was reported I was able to, but not recently. @kbecciv @CortneyOfstad @blimpich Are you able to consistently reproduce this?
Here's the video from Web
web-not-found-on-categorize.mov
iPhone Safari
mweb-safari-not-found-on-categorize.mp4
and I've tried this on Native, Mobile Web, Mac Safari. Tried it with 3 different new accounts.
@CortneyOfstad @blimpich I do see
Not foundwhen we click on the Workspace name. I am assuming that is expected as the workspace is not created yet. May be that shouldn't be clickable? But definitely a separate issue.blimpich commentedon Jun 24, 2024
I can no longer reproduce this either, seems to have been fixed elsewhere. Closing.