Skip to content

[HOLD for payment 2024-06-28] [$250] [CRITICAL] [UX Reliability] The chat finder page shows duplicated result for a moment  #43094

Closed

Description

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1717508731782149

Action Performed:

Break down in numbered steps

  1. Create Workspace as Alice
  2. Add couple members including Bob
  3. Create couple rooms on that workspace
  4. Sign into an account off Bob
  5. Turn on the focus mode
  6. Sign out and sign back in as bob
  7. In chat search page search for the name of the room on the policy
  8. Open it the room from the Search page

Expected Result:

Describe what you think should've happened

There should only be one row for that chat

Actual Result:

Describe what actually happened

The specific chat is duplicated in the search results

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0157768929ce5b2314
  • Upwork Job ID: 1798292023932084224
  • Last Price Increase: 2024-06-05
  • Automatic offers:
    • ahmedGaber93 | Reviewer | 102621261
Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 5, 2024
  2. melvin-bot commented on Jun 5, 2024

    @melvin-bot
  3. changed the title [-][CRITICAL] [UX Reliability] The chat finder page shows duplicated result for a moment [/-] [+][$250] [CRITICAL] [UX Reliability] The chat finder page shows duplicated result for a moment [/+] on Jun 5, 2024
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 5, 2024
  5. melvin-bot commented on Jun 5, 2024

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. melvin-bot commented on Jun 5, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

  7. dragnoir commented on Jun 5, 2024

    @dragnoir
    Contributor

    I think it's a dupe of #43049

  8. gedu commented on Jun 5, 2024

    @gedu
    Contributor

    Hey, I'm Edu from Callstack, I can take this issue

  9. tienifr commented on Jun 5, 2024

    @tienifr
    Contributor

    @gedu I already had the proposal in #43049 (comment). cc @ahmedGaber93

  10. mountiny commented on Jun 5, 2024

    @mountiny
    ContributorAuthor

    Nice @gedu can you check out the proposal if it matches your findings?

  11. 33 remaining items

  12. changed the title [-][$250] [CRITICAL] [UX Reliability] The chat finder page shows duplicated result for a moment [/-] [+][HOLD for payment 2024-06-28] [$250] [CRITICAL] [UX Reliability] The chat finder page shows duplicated result for a moment [/+] on Jun 21, 2024
  13. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-28. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
    • [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ahmedGaber93] Determine if we should create a regression test for this bug.
    • [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. ahmedGaber93 commented on Jun 30, 2024

    @ahmedGaber93
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Proposal

    1. Open the App
    2. Click Account Settings > Workspaces > and create new workspace
    3. Click fab icon > Start chat > Room tab
    4. Fill room name and select the workspace you create it in step 1 then click create room
    5. Open Search page and Verify that the room you created in step 4 appear once in search result

    Do we agree 👍 or 👎

  17. dylanexpensify commented on Jul 1, 2024

    @dylanexpensify
    Contributor

    Payment summary:

    Please apply, request!

  18. dylanexpensify commented on Jul 1, 2024

    @dylanexpensify
    Contributor

    Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions