Skip to content

[HOLD for payment 2024-06-20] Change icon of the hub connections. #43314

Closed

Description

@rushatgabhane

Slack: https://expensify.slack.com/archives/C02QSAC6BJ8/p1717772156939879

Following these steps: https://github.com/Expensify/App/tree/main/docs#how-to-change-icon-of-a-hub

We have to change the illustration of connections hub for both platforms - Expensify Classic and New Expensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 7, 2024
  2. melvin-bot commented on Jun 7, 2024

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. dannymcclain commented on Jun 7, 2024

    @dannymcclain
    Contributor

    Hey @dylanexpensify, this isn't really a bug, just a quick design update, so I unassigned you and assigned myself.

    @rushatgabhane thanks for the guidance!

  4. dannymcclain commented on Jun 7, 2024

    @dannymcclain
    Contributor

    cc @maddylewis just so you have eyes on this. I should be able to get to it Monday.

  5. dannymcclain commented on Jun 10, 2024

    @dannymcclain
    Contributor

    PR open ☝️

  6. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 13, 2024
  7. changed the title [-]Change icon of the hub connections.[/-] [+][HOLD for payment 2024-06-20] Change icon of the hub connections.[/+] on Jun 13, 2024
  8. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-20. 🎊

  10. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [] The PR that introduced the bug has been identified. Link to the PR:
    • [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [] Determine if we should create a regression test for this bug.
    • [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. rushatgabhane commented on Jun 16, 2024

    @rushatgabhane
    MemberAuthor

    checklist / payment not applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions