Skip to content

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Composer focus is lost if a new message is received while typing #43351

Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.81-1
Reproducible in staging?: Yes
Reproducible in production?: NO

Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1718015667516489

Action Performed:

Tip: To easily test this, log in with 2 accounts in different devices (e.g: Web & iOS)

  1. As account A start typing something in the compose box
  2. As account B, sent a message to A while they're typing

Expected Result:

Compose box focus should remain while receiving a new message.

Actual Result:

Compose box focus is lost if the user is typing and a new message is received.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

lost.focus.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b0384bb7db3c3ab2
  • Upwork Job ID: 1800145000444915700
  • Last Price Increase: 2024-06-10
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 10, 2024
  2. melvin-bot commented on Jun 10, 2024

    @melvin-bot

    Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 10, 2024

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jun 10, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. mountiny commented on Jun 10, 2024

    @mountiny
    Contributor

    I dont think this is a backend bug

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 10, 2024
  7. 12 remaining items

  8. luacmartins commented on Jun 10, 2024

    @luacmartins
    Contributor

    This was fixed by this revert #43431

  9. luacmartins commented on Jun 10, 2024

    @luacmartins
    Contributor

    Fixed in staging. Closing.

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 11, 2024
  11. changed the title [-][$250] Composer focus is lost if a new message is received while typing[/-] [+][HOLD for payment 2024-06-18] [$250] Composer focus is lost if a new message is received while typing[/+] on Jun 11, 2024
  12. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-18. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Ollyws requires payment through NewDot Manual Requests
    • @SzymczakJ does not require payment (Contractor)
  13. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
    • [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Ollyws] Determine if we should create a regression test for this bug.
    • [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. changed the title [-][HOLD for payment 2024-06-18] [$250] Composer focus is lost if a new message is received while typing[/-] [+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Composer focus is lost if a new message is received while typing[/+] on Jun 13, 2024
  15. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-20. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Ollyws requires payment through NewDot Manual Requests
    • @SzymczakJ does not require payment (Contractor)
  16. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
    • [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Ollyws] Determine if we should create a regression test for this bug.
    • [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions